SuccessChanges

Summary

  1. [AMDGPU] Adding mutex to guard lld::elf::link interface use (details)
  2. [MS] On x86_32, pass overaligned, non-copyable arguments indirectly (details)
  3. [AMDGPU] Fixed typo in intrinsic comment. NFC. (details)
Commit f87ceb63eb011e5cd653218af619097b58bf568f by zhuoryin
[AMDGPU] Adding mutex to guard lld::elf::link interface use

check-mlir target run tests simultaneously with multiple threads. This caused multiple threads to invoke the `lld::elf::link()` interface at the same time. Since the interface does not have a thread-safe implementation, add a metex to prevent multi-threaded access.

I discovered this by looking the the failure stack trace. lld/ELF/symbolTable.cpp, SymbolTable::insert() hit into an assert with related to Epoch Trackers. The root cause is to due to there is no protection around the symMap (update) which is implemented in non-thread safe data structure: denseMap.

Differential Revision: https://reviews.llvm.org/D88038
The file was modifiedmlir/tools/mlir-rocm-runner/mlir-rocm-runner.cpp (diff)
Commit 3b3a16548568f5b6c4146ca5129eb6af5000e4ff by rnk
[MS] On x86_32, pass overaligned, non-copyable arguments indirectly

This updates the C++ ABI argument classification code to use the logic
from D72114, fixing an ABI incompatibility with MSVC.

Part of PR44395.

Differential Revision: https://reviews.llvm.org/D87923
The file was modifiedclang/lib/CodeGen/MicrosoftCXXABI.cpp (diff)
The file was modifiedclang/test/CodeGenCXX/inalloca-overaligned.cpp (diff)
Commit e8951474b1940bd81bc3bac8d506e08880ee35ea by Stanislav.Mekhanoshin
[AMDGPU] Fixed typo in intrinsic comment. NFC.
The file was modifiedllvm/include/llvm/IR/IntrinsicsAMDGPU.td (diff)