FailedChanges

Summary

  1. Add REQUIRES to embed-bitcode-noopt.ll (details)
  2. [EarlyCSE] Fix crash with expensive checks after D87691 (details)
  3. Revert D87970 "[ThinLTO] Avoid temporaries when loading global decl attachment metadata" (details)
  4. Break long line accidentally left in the previous commit (details)
  5. [Driver] Check whether Gentoo-specific configuration directory exists (details)
  6. Re-apply https://reviews.llvm.org/D87921, was reverted to triage a PPC bot failure. (details)
  7. Enhance TableGen so that backends can produce better error messages. (details)
  8. [ms] [llvm-ml] Add support for .radix directive, and accept all radix specifiers (details)
  9. [TTI] add wrapper for matching vector reduction to reduce code duplication; NFC (details)
  10. Fix include location (accidentally committed a local variation) (details)
  11. [X86] Improve demanded bits for X86ISD::BEXTR. (details)
  12. [SLP] Make HorizontalReduction::getOperationData take an Instruction* instead of a Value*. NFCI (details)
  13. Revert "[ms] [llvm-ml] Add support for .radix directive, and accept all radix specifiers" (details)
  14. Update Phabricator doc to remove the warning on "arc land": tags a properly handled server side now (details)
  15. Document the `--verbatim` flag from arc to update the description for a phabricator revision (details)
  16. [lsan] On Fuchsia, don't use atexit hook for leak checks (details)
Commit 271928792e8016109fdd909889dc6bb582aa6f46 by mtrofin
Add REQUIRES to embed-bitcode-noopt.ll
The file was modifiedclang/test/Frontend/embed-bitcode-noopt.ll (diff)
Commit e976fb1e54f30403ca31764da69cba3769487e6a by kparzysz
[EarlyCSE] Fix crash with expensive checks after D87691

D87691 reordered some checks, which turned out to be unsafe. More
specifically, when examining a store instruction, the check against
getOrCreateResult should be done before attempting to call
isSameMemGeneration. Otherwise a crash in MSSA walker can occur.

This patch restores the order of these calls to what it was originally.
The file was addedllvm/test/Transforms/EarlyCSE/getmatchingvalue-crash.ll
The file was modifiedllvm/lib/Transforms/Scalar/EarlyCSE.cpp (diff)
Commit 01b9deba76a950f04574b656c7c31ae389104f2d by i
Revert D87970 "[ThinLTO] Avoid temporaries when loading global decl attachment metadata"

This reverts commit ab1b4810b55279bcf6fdd87be74a403440be3991.

It caused an issue in llvm::lto::thinBackend for a -fsanitize=cfi build.

```
AbbrevNo is 0 => "Invalid abbrev number"
0  llvm::BitstreamCursor::getAbbrev (this=0x9db4c8, AbbrevID=4) at llvm/include/llvm/Bitstream/BitstreamReader.h:528
1  0x00007f5f777a6eb4 in llvm::BitstreamCursor::readRecord (this=0x9db4c8, AbbrevID=4, Vals=llvm::SmallVector of Size 0, Capacity 64, Blob=0x7ffcd0e26558) at
usr/local/google/home/maskray/llvm/llvm/lib/Bitstream/Reader/BitstreamReader.cpp:228
2  0x00007f5f796bf633 in llvm::MetadataLoader::MetadataLoaderImpl::lazyLoadOneMetadata (this=0x9db3a0, ID=188, Placeholders=...) at /usr/local/google/home/mas
ray/llvm/llvm/lib/Bitcode/Reader/MetadataLoader.cpp:1091
3  0x00007f5f796c2527 in llvm::MetadataLoader::MetadataLoaderImpl::getMetadataFwdRefOrLoad (this=0x9db3a0, ID=188) at llvm
lib/Bitcode/Reader/MetadataLoader.cpp:668
4  0x00007f5f796bfff3 in llvm::MetadataLoader::getMetadataFwdRefOrLoad (this=0xd31580, Idx=188) at llvm/lib/Bitcode/Reader
MetadataLoader.cpp:2290
5  0x00007f5f79638265 in (anonymous namespace)::BitcodeReader::parseFunctionBody (this=0xd312e0, F=0x9de758) at llvm/lib/B
tcode/Reader/BitcodeReader.cpp:3938
6  0x00007f5f79635d32 in (anonymous namespace)::BitcodeReader::materialize (this=0xd312e0, GV=0x9de758) at llvm/lib/Bitcod
/Reader/BitcodeReader.cpp:5408
7  0x00007f5f7f8dbe3e in llvm::Module::materialize (this=0x9b92c0, GV=0x9de758) at llvm/lib/IR/Module.cpp:442
8  0x00007f5f7f7f8fbe in llvm::GlobalValue::materialize (this=0x9de758) at llvm/lib/IR/Globals.cpp:50
9  0x00007f5f83b9b5f5 in llvm::FunctionImporter::importFunctions (this=0x7ffcd0e2a730, DestModule=..., ImportList=...) at
llvm/lib/Transforms/IPO/FunctionImport.cpp:1182
```
The file was modifiedllvm/test/ThinLTO/X86/devirt2.ll (diff)
The file was modifiedllvm/lib/Bitcode/Reader/MetadataLoader.cpp (diff)
Commit 76e8c1899e7c9f9462ba08387472899d7de965af by kparzysz
Break long line accidentally left in the previous commit
The file was modifiedllvm/lib/Transforms/Scalar/EarlyCSE.cpp (diff)
Commit d882ca7f1f1dee7d812d6b1ae060b5f671ab9ebc by dmantipov
[Driver] Check whether Gentoo-specific configuration directory exists

Check whether /etc/env.d/gcc exists before trying to read from any
file from there. This saves a few OS calls on a non-Gentoo system.

Differential Revision: https://reviews.llvm.org/D87143
The file was modifiedclang/lib/Driver/ToolChains/Gnu.h (diff)
The file was modifiedclang/lib/Driver/ToolChains/Gnu.cpp (diff)
Commit 7d0bbe40901cf60558c619c3174d71d7c53ca144 by tmsriram
Re-apply https://reviews.llvm.org/D87921, was reverted to triage a PPC bot failure.

D87921 was reverted in commit b89059a31347dd09b55a96b99b3dbe38d7749908
as it was causing an unknown llvm PPC bot failure.  Reapplying the patch
after confirming that this is not responsible. Build bot failure:
https://reviews.llvm.org/D87921#2286644  which caused the revert.

The wrong placement of add pass with optimizations led to
-funique-internal-linkage-names being disabled.

Fixed the placement of the MPM.addpass for UniqueInternalLinkageNames to make it
work correctly with -O2 and new pass manager. Updated the tests to explicitly
check O0 and O1.

Differential Revision: https://reviews.llvm.org/D87921
The file was modifiedclang/test/CodeGen/unique-internal-linkage-names.cpp (diff)
The file was modifiedclang/lib/CodeGen/BackendUtil.cpp (diff)
Commit b3931188fdc84ce2bd93a0770ddc8182d18c5010 by paul
Enhance TableGen so that backends can produce better error messages.

Modify SearchableTableEmitter.cpp to take advantage.
Clean up formatting and capitalization issues.
The file was modifiedllvm/lib/TableGen/TGParser.cpp (diff)
The file was modifiedllvm/test/TableGen/getsetop.td (diff)
The file was modifiedllvm/include/llvm/TableGen/Record.h (diff)
The file was modifiedllvm/test/TableGen/cond-type.td (diff)
The file was modifiedllvm/utils/TableGen/SearchableTableEmitter.cpp (diff)
The file was modifiedllvm/test/TableGen/self-reference-typeerror.td (diff)
The file was modifiedllvm/lib/TableGen/Error.cpp (diff)
The file was modifiedllvm/include/llvm/TableGen/Error.h (diff)
The file was modifiedllvm/test/TableGen/generic-tables.td (diff)
The file was modifiedllvm/lib/TableGen/Record.cpp (diff)
The file was modifiedllvm/test/TableGen/if-type.td (diff)
Commit 5dd1b6d612655c9006ba97a8b6487ded80719b48 by epastor
[ms] [llvm-ml] Add support for .radix directive, and accept all radix specifiers

Add support for .radix directive, and radix specifiers [yY] (binary), [oOqQ] (octal), and [tT] (decimal).

Also, when lexing MASM integers, require radix specifier; MASM requires that all literals without a radix specifier be treated as in the default radix. (e.g., 0100 = 100)

Reviewed By: thakis

Differential Revision: https://reviews.llvm.org/D87400
The file was modifiedllvm/lib/MC/MCParser/AsmLexer.cpp (diff)
The file was modifiedllvm/include/llvm/MC/MCParser/MCAsmLexer.h (diff)
The file was addedllvm/test/tools/llvm-ml/radix_errors.test
The file was modifiedllvm/lib/Target/X86/AsmParser/X86AsmParser.cpp (diff)
The file was modifiedllvm/lib/MC/MCParser/MasmParser.cpp (diff)
The file was addedllvm/test/tools/llvm-ml/radix.test
The file was modifiedllvm/lib/MC/MCParser/COFFMasmParser.cpp (diff)
Commit 6189a8d9f56ac9434eac94d6c515d3e460fdecd0 by spatel
[TTI] add wrapper for matching vector reduction to reduce code duplication; NFC

I'm not sure what this means, but the order in which we try
the matches makes a difference on at least 1 regression test...
The file was modifiedllvm/include/llvm/Analysis/TargetTransformInfo.h (diff)
The file was modifiedllvm/lib/Analysis/TargetTransformInfo.cpp (diff)
The file was modifiedllvm/include/llvm/Analysis/TargetTransformInfoImpl.h (diff)
Commit aca7105db9ae1a42d7cbf48934abb51169945425 by epastor
Fix include location (accidentally committed a local variation)
The file was modifiedllvm/lib/MC/MCParser/AsmLexer.cpp (diff)
Commit f21f835ee8e52f128281697d66f8b11a50a6d5dd by craig.topper
[X86] Improve demanded bits for X86ISD::BEXTR.

If the control is constant we can figure out exactly which bits
of the input are demanded.

Differential Revision: https://reviews.llvm.org/D88072
The file was modifiedllvm/lib/Target/X86/X86ISelLowering.cpp (diff)
The file was modifiedllvm/test/CodeGen/X86/tbm-intrinsics.ll (diff)
Commit 7a3c643c35590df67716dfe3e3c60195ae385e43 by craig.topper
[SLP] Make HorizontalReduction::getOperationData take an Instruction* instead of a Value*. NFCI

All of the callers already have an Instruction *. Many of them
from a dyn_cast.

Also update the OperationData constructor to use a Instruction&
to remove a dyn_cast and make it clear that the pointer is non-null.

Differential Revision: https://reviews.llvm.org/D88132
The file was modifiedllvm/lib/Transforms/Vectorize/SLPVectorizer.cpp (diff)
Commit b901b6ab173ac77edfe97e0dbd138410b940b4bc by epastor
Revert "[ms] [llvm-ml] Add support for .radix directive, and accept all radix specifiers"

This reverts commit 5dd1b6d612655c9006ba97a8b6487ded80719b48.
The file was removedllvm/test/tools/llvm-ml/radix.test
The file was modifiedllvm/lib/MC/MCParser/COFFMasmParser.cpp (diff)
The file was modifiedllvm/lib/MC/MCParser/AsmLexer.cpp (diff)
The file was removedllvm/test/tools/llvm-ml/radix_errors.test
The file was modifiedllvm/lib/Target/X86/AsmParser/X86AsmParser.cpp (diff)
The file was modifiedllvm/lib/MC/MCParser/MasmParser.cpp (diff)
The file was modifiedllvm/include/llvm/MC/MCParser/MCAsmLexer.h (diff)
Commit 55f5a0137f5bbfc8411bd11a5d2695ba84534345 by joker.eph
Update Phabricator doc to remove the warning on "arc land": tags a properly handled server side now
The file was modifiedllvm/docs/Phabricator.rst (diff)
Commit 5281ba1994bdd21309d694c44e43ed825294221c by joker.eph
Document the `--verbatim` flag from arc to update the description for a phabricator revision
The file was modifiedllvm/docs/Phabricator.rst (diff)
Commit 0caad9fe441d5ee562e96d8b30b5574b492a933a by mcgrathr
[lsan] On Fuchsia, don't use atexit hook for leak checks

Fuchsia's system libraries are instrumented and use the lsan
allocator for internal purposes.  So leak checking needs to run
after all atexit hooks and after the system libraries' internal
exit-time hooks.  The <zircon/sanitizer.h> hook API calls the
__sanitizer_process_exit_hook function at exactly the right time.

Reviewed By: vitalybuka, phosek

Differential Revision: https://reviews.llvm.org/D86171
The file was modifiedcompiler-rt/lib/lsan/lsan.h (diff)
The file was modifiedcompiler-rt/lib/asan/asan_posix.cpp (diff)
The file was modifiedcompiler-rt/lib/asan/asan_win.cpp (diff)
The file was modifiedcompiler-rt/lib/asan/asan_internal.h (diff)
The file was modifiedcompiler-rt/lib/asan/asan_fuchsia.cpp (diff)
The file was modifiedcompiler-rt/lib/asan/asan_rtl.cpp (diff)
The file was modifiedcompiler-rt/lib/lsan/lsan_fuchsia.cpp (diff)
The file was modifiedcompiler-rt/lib/lsan/lsan_common_fuchsia.cpp (diff)
The file was modifiedcompiler-rt/lib/lsan/lsan_posix.cpp (diff)
The file was modifiedcompiler-rt/lib/lsan/lsan.cpp (diff)