SuccessChanges

Changes from Git (git http://labmaster3.local/git/llvm-project.git)

Summary

  1. [LLDB] [test] Add a missing "REQUIRES: arm" line (details)
  2. [lldb][NFC] Make GetAsCXXRecordDecl static (details)
  3. [lldb][NFC] Remove forward declaration of PrivateAutoCompleteMembers (details)
  4. [clangd] Tweak the no-index error message for rename, NFC. (details)
  5. [clangd] Prefer the left character if the character on the right of the (details)
  6. [lldb][NFC] Remove unused CStringToDIEMap typedef (details)
  7. [clangd] Don't perform rename when the refs result from index is (details)
  8. [lldb] NFC: refactor CompileUnit::ResolveSymbolContext (details)
  9. [lldb][NFC] Use llvm::StringRef instead of C-strings as multimap key (details)
  10. [lldb][NFC] Remove unused STLUtil include and STLUtil.h header (details)
  11. [include-fixer] Python 3 support for clang-include-fixer.py (details)
  12. Revert "[lldb] NFC: refactor CompileUnit::ResolveSymbolContext" (details)
  13. [lldb] Simplify and improve FileSpecTest (details)
  14. [lldb] Add FileSpec::Equal unit tests (details)
  15. [lldb] refactor FileSpec::Equal (details)
  16. [lldb][NFC] Remove unused CompilerDecl::IsClang (details)
  17. [lldb][NFC] Simplify CompilerDecl and CompilerDeclContext initialization (details)
  18. [lldb][NFC] Remove unused variable in ClangASTSource::CompleteType (details)
  19. [lldb][NFC] Remove CompilerDeclContext::IsClang (details)
  20. [OpenMP][test] Fix test on MIPS-based buildbots (details)
  21. [AArch64][v8.3a] Don't emit LDRA '[xN]!' alias in disassembly. (details)
  22. AMDGPU: Reuse carry out register during FI elimination (details)
  23. [LLDB] Fix wrong argument in CommandObjectThreadStepWithTypeAndScope (details)
  24. [LLDB] On Windows, force error message formatting to English (details)
  25. [lldb] NFC: refactor CompileUnit::ResolveSymbolContext (details)
  26. [IVDescriptors] Skip FOR where we have multiple sink points for now. (details)
  27. [mips] Check that features required by built-ins are enabled (details)
  28. [ORC][JITLink] Add support for weak references, and improve handling of (details)
  29. [LegacyPassManager] Simplify PMStack pop (details)
  30. [Clang] Bypass distro detection on non-Linux hosts (details)
  31. [LegacyPassManager] Simplify FunctionPass::assignPassManager (details)
Commit f286f2dda4d2b05b61964f5c9373f36493fbb190 by martin
[LLDB] [test] Add a missing "REQUIRES: arm" line
The file was modifiedlldb/test/Shell/ObjectFile/PECOFF/disassemble-thumb.yaml
Commit 9d2679152a4bbe892f72802427657bfdca85a63b by Raphael Isemann
[lldb][NFC] Make GetAsCXXRecordDecl static
All other casting functions there are static, so this should be too.
The file was modifiedlldb/include/lldb/Symbol/ClangASTContext.h
Commit ee79feaec3ed44b21654936baf44561f5f726dfc by Raphael Isemann
[lldb][NFC] Remove forward declaration of PrivateAutoCompleteMembers
That's declared directly above the actual definition, so it serves no
use.
The file was modifiedlldb/source/Symbol/Variable.cpp
Commit 08cce03a6d959c899e07398603c85168a96f549c by hokein.wu
[clangd] Tweak the no-index error message for rename, NFC.
Summary: The current error message doesn't fit well for cross-file
rename.
Reviewers: ilya-biryukov
Subscribers: MaskRay, jkorous, arphaman, kadircet, usaxena95,
cfe-commits
Tags: #clang
Differential Revision: https://reviews.llvm.org/D70809
The file was modifiedclang-tools-extra/clangd/refactor/Rename.cpp
Commit 2330cee82f0aa06e8063189fe7a68db3e51f3054 by hokein.wu
[clangd] Prefer the left character if the character on the right of the
cursor is semicolon.
Summary: This would make go-to-def works on the cases like int A = abc^;
Reviewers: sammccall
Subscribers: ilya-biryukov, MaskRay, jkorous, arphaman, kadircet,
usaxena95, cfe-commits
Tags: #clang
Differential Revision: https://reviews.llvm.org/D70807
The file was modifiedclang-tools-extra/clangd/unittests/SelectionTests.cpp
The file was modifiedclang-tools-extra/clangd/Selection.cpp
The file was modifiedclang-tools-extra/clangd/unittests/SemanticSelectionTests.cpp
Commit 2e3c040ee062741472233c1de2dbf135bcee5c7a by Raphael Isemann
[lldb][NFC] Remove unused CStringToDIEMap typedef
The file was modifiedlldb/source/Plugins/SymbolFile/DWARF/DWARFDebugInfo.h
Commit 3c3aca245e67fa70b6f49b9062983fbdf120ba04 by hokein.wu
[clangd] Don't perform rename when the refs result from index is
incomplete.
Summary: Also do an early return if the number of affected files > limit
to save some unnecessary FileURI computations.
Reviewers: ilya-biryukov
Subscribers: MaskRay, jkorous, arphaman, kadircet, usaxena95,
cfe-commits
Tags: #clang
Differential Revision: https://reviews.llvm.org/D70811
The file was modifiedclang-tools-extra/clangd/unittests/RenameTests.cpp
The file was modifiedclang-tools-extra/clangd/refactor/Rename.cpp
Commit 373e2a4f69d623e59329ff801f261d8b299e12d2 by kkleine
[lldb] NFC: refactor CompileUnit::ResolveSymbolContext
Summary: I found the above named method hard to read because it had
a) many nested blocks and b) one return statement at the end with some
logic involved.
I decided to refactor this function by employing an early exit strategy.
In order to capture the logic in the return statement and to not have it
repeated more than once I chose to implement a very small lamda function
that captures all the variables it needs.
This is a non-functional change (NFC).
Reviewers: jdoerfert
Subscribers: lldb-commits
Tags: #lldb
Differential Revision: https://reviews.llvm.org/D70774
The file was modifiedlldb/include/lldb/Symbol/CompileUnit.h
The file was modifiedlldb/source/Symbol/CompileUnit.cpp
The file was modifiedlldb/source/API/SBThread.cpp
The file was modifiedlldb/source/Core/AddressResolverFileLine.cpp
Commit a54ef8af89c78f7296bea6ffabb7728ef563bec1 by Raphael Isemann
[lldb][NFC] Use llvm::StringRef instead of C-strings as multimap key
The file was modifiedlldb/source/Symbol/Symtab.cpp
Commit 42c857aa4783824183d55e8a6ede488d69349806 by Raphael Isemann
[lldb][NFC] Remove unused STLUtil include and STLUtil.h header
The file was removedlldb/include/lldb/Core/STLUtils.h
The file was modifiedlldb/include/lldb/Interpreter/CommandReturnObject.h
Commit 66237889a79f728fffc96394740b975774de26bf by benny.kra
[include-fixer] Python 3 support for clang-include-fixer.py
Patch by Yannick Brehon!
The file was modifiedclang-tools-extra/clang-include-fixer/tool/clang-include-fixer.py
Commit 50e2ffa18da4247e4d45f421c3271b58b936c869 by Raphael Isemann
Revert "[lldb] NFC: refactor CompileUnit::ResolveSymbolContext"
This reverts commit 373e2a4f69d623e59329ff801f261d8b299e12d2.
This broke breakpoint setting.
The file was modifiedlldb/include/lldb/Symbol/CompileUnit.h
The file was modifiedlldb/source/Core/AddressResolverFileLine.cpp
The file was modifiedlldb/source/API/SBThread.cpp
The file was modifiedlldb/source/Symbol/CompileUnit.cpp
Commit d1a561d446809cc3b5c11c163b9aa5ba4957af68 by pavel
[lldb] Simplify and improve FileSpecTest
Summary: A most of these tests create FileSpecs with a hardcoded style.
Add utility functions which create a file spec of a given style to
simplify things.
While in there add SCOPED_TRACE messages to tests which loop over
multiple inputs to ensure it's clear which of the inputs failed.
Reviewers: teemperor
Subscribers: lldb-commits
Tags: #lldb
Differential Revision: https://reviews.llvm.org/D70814
The file was modifiedlldb/unittests/Utility/FileSpecTest.cpp
Commit bf716eb807409adf6490cb1cf595fb51efbd3fe6 by pavel
[lldb] Add FileSpec::Equal unit tests
this is in preparation of a refactor of this method.
The file was modifiedlldb/unittests/Utility/FileSpecTest.cpp
Commit b18e190b7ca90c09566382a039887f6eafe63d0d by pavel
[lldb] refactor FileSpec::Equal
The logic of this function was quite hard to follow. Replace it with a
much simpler, equivalent, implementation.
The file was modifiedlldb/source/Utility/FileSpec.cpp
Commit 3cd8ba0e37a035a134dc01ce260040f1d57f4d40 by Raphael Isemann
[lldb][NFC] Remove unused CompilerDecl::IsClang
The file was modifiedlldb/source/Symbol/CompilerDecl.cpp
The file was modifiedlldb/include/lldb/Symbol/CompilerDecl.h
Commit e0203b25af92a3388580d6ef4eb386058720449e by Raphael Isemann
[lldb][NFC] Simplify CompilerDecl and CompilerDeclContext initialization
The file was modifiedlldb/include/lldb/Symbol/CompilerDeclContext.h
The file was modifiedlldb/include/lldb/Symbol/CompilerDecl.h
Commit f39277c1d370ccbbec2e20a20375ee6fb7281ae4 by Raphael Isemann
[lldb][NFC] Remove unused variable in ClangASTSource::CompleteType
Now that CompilerDeclContext is a trivial class, Clang started warning
that this unused variable is in fact unused. Let's remove it.
The file was modifiedlldb/source/Plugins/ExpressionParser/Clang/ClangASTSource.cpp
Commit c2dd84e396d091ca61b06b59c622b444ffc17234 by Raphael Isemann
[lldb][NFC] Remove CompilerDeclContext::IsClang
This method is only used in ClangASTContext.
Also removes the includes we only needed for the ClangASTContext RTTI
check in the CompilerDecl[Context].cpp files.
The file was modifiedlldb/include/lldb/Symbol/CompilerDeclContext.h
The file was modifiedlldb/source/Symbol/CompilerDecl.cpp
The file was modifiedlldb/source/Symbol/ClangASTContext.cpp
The file was modifiedlldb/source/Symbol/CompilerDeclContext.cpp
Commit ed864745c97ece86e29957cb94b5a3e8dee86859 by Milos.Stojanovic
[OpenMP][test] Fix test on MIPS-based buildbots
On MIPS `zeroext` or `signext` can appear in the output.
Differential Revision: https://reviews.llvm.org/D70820
The file was modifiedclang/test/OpenMP/parallel_codegen.cpp
Commit acd7fe8636ab1d892a935ca747ed9bb6420e2253 by simon.tatham
[AArch64][v8.3a] Don't emit LDRA '[xN]!' alias in disassembly.
Summary: In rG643ac6c0420b, the syntax `ldraa x1, [x0]!` was added as an
alias for `ldraa x1, [x0, #0]!`. That syntax is less obvious in meaning,
and also will not be accepted by assemblers that haven't been updated
yet. So it would be better not to emit it as the preferred disassembly
for that instruction.
This change lowers the EmitPriority of the new alias so that the more
explicit syntax `[x0, #0]!` is preferred by the disassembler. The new
syntax is still accepted by the assembler.
Reviewers: ab, ostannard
Reviewed By: ostannard
Subscribers: kristof.beyls, hiraditya, llvm-commits
Tags: #llvm
Differential Revision: https://reviews.llvm.org/D70813
The file was modifiedllvm/lib/Target/AArch64/AArch64InstrFormats.td
The file was modifiedllvm/test/MC/Disassembler/AArch64/armv8.3a-signed-pointer.txt
The file was modifiedllvm/test/MC/AArch64/armv8.3a-signed-pointer.s
Commit 256ad954a9e453e55b950207ca433da8da883a33 by Austin.Kerbow
AMDGPU: Reuse carry out register during FI elimination
Summary: Pre gfx9 we need to scavenge a 64-bit SGPR to use as the carry
out for an Add. If only one SGPR was available this crashed when trying
to scavenge another 32bit SGPR to materialize the offset.
Instead, reuse a 32-bit SGPR from the carry out as the offset register.
Also prefer to use vcc for the unused carry out when it is available.
Reviewers: arsenm, rampitec
Subscribers: kzhuravl, jvesely, wdng, nhaehnle, yaxunl, dstuttard, tpr,
t-tye, hiraditya, llvm-commits
Tags: #llvm
Differential Revision: https://reviews.llvm.org/D70614
The file was modifiedllvm/lib/Target/AMDGPU/SIRegisterInfo.cpp
The file was modifiedllvm/test/CodeGen/AMDGPU/pei-scavenge-sgpr-carry-out.mir
The file was modifiedllvm/lib/Target/AMDGPU/SIInstrInfo.cpp
Commit b4dfc5508f9239f50a3c44dd64e82a488b698b29 by alexandre.ganea
[LLDB] Fix wrong argument in CommandObjectThreadStepWithTypeAndScope
Differential Revision: https://reviews.llvm.org/D70448
The file was modifiedlldb/source/Commands/CommandObjectThread.cpp
Commit bdad3ec75ab35ade2433b1278689d483dcf9abc4 by alexandre.ganea
[LLDB] On Windows, force error message formatting to English
This fixes the Utility/StatusTest.ErrorWin32 unit test on non-English
locales.
Differential Revision: https://reviews.llvm.org/D70442
The file was modifiedlldb/source/Utility/Status.cpp
Commit c671639af6a96c31d3c0e5487051bef28bad1640 by kkleine
[lldb] NFC: refactor CompileUnit::ResolveSymbolContext
Summary: I found the above named method hard to read because it had
a) many nested blocks, b) one return statement at the end with some
logic involved, c) a duplicated while-loop with just small differences
in it.
I decided to refactor this function by employing an early exit strategy.
In order to capture the logic in the return statement and to not have it
repeated more than once I chose to implement a very small lamda function
that captures all the variables it needs. I also replaced the two
while-loops with just one.
This is a non-functional change (NFC).
Reviewers: jdoerfert, teemperor
Reviewed By: teemperor
Subscribers: labath, teemperor, lldb-commits
Tags: #lldb
Differential Revision: https://reviews.llvm.org/D70774
The file was modifiedlldb/include/lldb/Symbol/CompileUnit.h
The file was modifiedlldb/source/API/SBThread.cpp
The file was modifiedlldb/source/Core/AddressResolverFileLine.cpp
The file was modifiedlldb/source/Symbol/CompileUnit.cpp
Commit ec3efcf11ff2fcdb5a754e3bda942dd5bef0928e by florian_hahn
[IVDescriptors] Skip FOR where we have multiple sink points for now.
This fixes a crash with instructions where multiple operands are
first-order-recurrences.
The file was modifiedllvm/lib/Analysis/IVDescriptors.cpp
The file was modifiedllvm/test/Transforms/LoopVectorize/first-order-recurrence-complex.ll
Commit f4d32ae75bf515f443a2c99dce5c882f460c82bd by simon
[mips] Check that features required by built-ins are enabled
Now Clang does not check that features required by built-in functions
are enabled. That causes errors in the backend reported in PR44018.
This patch fixes this bug by checking that required features are
enabled.
This should fix PR44018.
Differential Revision: https://reviews.llvm.org/D70808
The file was addedclang/test/Sema/builtins-mips-features.c
The file was modifiedclang/lib/Basic/Targets/Mips.cpp
The file was modifiedclang/include/clang/Basic/DiagnosticSemaKinds.td
The file was modifiedclang/lib/Sema/SemaChecking.cpp
The file was modifiedclang/include/clang/Sema/Sema.h
The file was modifiedclang/test/CodeGen/builtins-mips-args.c
The file was modifiedclang/test/CodeGen/builtins-mips.c
Commit 674df13b5fa7ffbd273455d547eff4507a2fcaff by Lang Hames
[ORC][JITLink] Add support for weak references, and improve handling of
static libraries.
This patch substantially updates ORCv2's lookup API in order to support
weak references, and to better support static archives. Key changes:
-- Each symbol being looked for is now associated with a
SymbolLookupFlags
  value. If the associated value is SymbolLookupFlags::RequiredSymbol
then
  the symbol must be defined in one of the JITDylibs being searched (or
be
  able to be generated in one of these JITDylibs via an attached
definition
  generator) or the lookup will fail with an error. If the associated
value is
  SymbolLookupFlags::WeaklyReferencedSymbol then the symbol is permitted
to be
  undefined, in which case it will simply not appear in the resulting
  SymbolMap if the rest of the lookup succeeds.
   Since lookup now requires these flags for each symbol, the lookup
method now
  takes an instance of a new SymbolLookupSet type rather than a
SymbolNameSet.
  SymbolLookupSet is a vector-backed set of (name, flags) pairs. Clients
are
  responsible for ensuring that the set property (i.e. unique elements)
holds,
  though this is usually simple and SymbolLookupSet provides convenience
  methods to support this.
-- Lookups now have an associated LookupKind value, which is either
  LookupKind::Static or LookupKind::DLSym. Definition generators can
inspect
  the lookup kind when determining whether or not to generate new
definitions.
  The StaticLibraryDefinitionGenerator is updated to only pull in new
objects
  from the archive if the lookup kind is Static. This allows lookup to
be
  re-used to emulate dlsym for JIT'd symbols without pulling in new
objects
  from archives (which would not happen in a normal dlsym call).
-- JITLink is updated to allow externals to be assigned weak linkage,
and
  weak externals now use the SymbolLookupFlags::WeaklyReferencedSymbol
value
  for lookups. Unresolved weak references will be assigned the default
value of
  zero.
Since this patch was modifying the lookup API anyway, it alo replaces
all of the
"MatchNonExported" boolean arguments with a "JITDylibLookupFlags" enum
for readability. If a JITDylib's associated value is
JITDylibLookupFlags::MatchExportedSymbolsOnly then the lookup will only
match against exported (non-hidden) symbols in that JITDylib. If a
JITDylib's associated value is JITDylibLookupFlags::MatchAllSymbols then
the lookup will match against any symbol defined in the JITDylib.
The file was modifiedllvm/include/llvm/ExecutionEngine/JITLink/JITLink.h
The file was modifiedllvm/lib/ExecutionEngine/JITLink/JITLinkGeneric.h
The file was modifiedllvm/lib/ExecutionEngine/Orc/LLJIT.cpp
The file was modifiedllvm/tools/llvm-jitlink/llvm-jitlink.cpp
The file was modifiedllvm/include/llvm/ExecutionEngine/Orc/Core.h
The file was modifiedllvm/include/llvm/ExecutionEngine/Orc/Speculation.h
The file was modifiedllvm/lib/ExecutionEngine/Orc/ExecutionUtils.cpp
The file was addedllvm/test/ExecutionEngine/JITLink/X86/MachO_weak_references.s
The file was modifiedllvm/lib/ExecutionEngine/Orc/Core.cpp
The file was modifiedllvm/lib/ExecutionEngine/Orc/RTDyldObjectLinkingLayer.cpp
The file was modifiedllvm/lib/ExecutionEngine/Orc/CompileOnDemandLayer.cpp
The file was modifiedllvm/unittests/ExecutionEngine/Orc/RTDyldObjectLinkingLayerTest.cpp
The file was modifiedllvm/unittests/ExecutionEngine/Orc/LegacyAPIInteropTest.cpp
The file was modifiedllvm/lib/ExecutionEngine/Orc/IndirectionUtils.cpp
The file was modifiedllvm/lib/ExecutionEngine/JITLink/JITLinkGeneric.cpp
The file was modifiedllvm/lib/ExecutionEngine/Orc/ObjectLinkingLayer.cpp
The file was modifiedllvm/lib/ExecutionEngine/JITLink/MachOLinkGraphBuilder.cpp
The file was modifiedllvm/unittests/ExecutionEngine/Orc/CoreAPIsTest.cpp
The file was modifiedllvm/lib/ExecutionEngine/Orc/Legacy.cpp
The file was modifiedllvm/lib/ExecutionEngine/JITLink/JITLink.cpp
The file was modifiedllvm/lib/ExecutionEngine/Orc/LazyReexports.cpp
The file was modifiedllvm/include/llvm/ExecutionEngine/Orc/ExecutionUtils.h
Commit a7abe6eac061a999e88d651e4857872f5ec52e5d by maskray
[LegacyPassManager] Simplify PMStack pop
The file was modifiedllvm/lib/IR/LegacyPassManager.cpp
Commit 1abd4c94d7575e4cd288e0024c1ec79f17b048a9 by alexandre.ganea
[Clang] Bypass distro detection on non-Linux hosts
Skip distro detection when we're not running on Linux, or when the
target triple is not Linux. This saves a few OS calls for each
invocation of clang.exe.
Differential Revision: https://reviews.llvm.org/D70467
The file was modifiedclang/lib/Driver/Distro.cpp
The file was modifiedclang/unittests/Driver/DistroTest.cpp
The file was modifiedclang/lib/Driver/ToolChains/Clang.cpp
The file was modifiedclang/lib/Driver/ToolChains/Cuda.cpp
The file was modifiedclang/lib/Driver/ToolChains/Linux.cpp
The file was modifiedclang/include/clang/Driver/Distro.h
Commit 4adddbd8ad4f71e8ce4cb4a38c755b126c5e9eff by maskray
[LegacyPassManager] Simplify FunctionPass::assignPassManager
And make it clear the parameter PreferredType is unused for
FunctionPass.
The file was modifiedllvm/lib/IR/LegacyPassManager.cpp