FailedChanges

Summary

  1. Revert r374657: "[lit] Try again to fix new tests that fail on Windows (details)
  2. [lit] Try yet again to fix new tests that fail on Windows bots (details)
Commit 8259f7ca120734b6fba0e67ae445492009f9871d by jdenny.ornl
Revert r374657: "[lit] Try again to fix new tests that fail on Windows
bots"
llvm-svn: 374664
The file was modifiedllvm/utils/lit/lit/builtin_commands/diff.py (diff)
The file was modifiedllvm/utils/lit/tests/shtest-shell.py (diff)
Commit a271acbf79326da83cab36a02938fc6cd5740b1b by jdenny.ornl
[lit] Try yet again to fix new tests that fail on Windows bots
I seem to have misread the bot logs on my last attempt.  When lit's
internal diff runs on Windows under Python 2.7, it's text diffs not
binary diffs that need decoding to avoid this error when writing the
diff to stdout:
``` UnicodeEncodeError: 'ascii' codec can't encode characters in
position 7-8: ordinal not in range(128)
```
There is no `decode` attribute in this case under Python 3.6.8 under
Ubuntu, so this patch checks for the `decode` attribute before using it
here.  Hopefully nothing else is needed when `decode` isn't available.
It might take a couple more attempts to figure out what error handling,
if any, is needed for this decoding.
llvm-svn: 374665
The file was modifiedllvm/utils/lit/lit/builtin_commands/diff.py (diff)