FailedChanges

Summary

  1. [LV] Merge LLVM_DEBUG blocks. (details)
  2. [Attributor] Extend anonymous namespace. NFC. (details)
  3. Reland r374388: [lit] Make internal diff work in pipelines (details)
  4. Reland r374389: [lit] Clean up internal diff's encoding handling (details)
  5. Reland r374390: [lit] Extend internal diff to support `-` argument (details)
  6. Reland r374392: [lit] Extend internal diff to support -U (details)
  7. [lit] Fix internal diff's --strip-trailing-cr and use it (details)
  8. [lit] Fix a few oversights in r374651 that broke some bots (details)
  9. [lit] Try to fix new tests that fail on Windows bots (details)
  10. [CostModel][X86] Improve sum reduction costs. (details)
  11. Revert r374654: "[lit] Try to fix new tests that fail on Windows bots" (details)
  12. [lit] Try again to fix new tests that fail on Windows bots (details)
Commit 97c9804e06395f94ee303bc1ae17d81776ead003 by benny.kra
[LV] Merge LLVM_DEBUG blocks.
Avoids unused variable warnings about the range-based for loops in
there. NFCI.
llvm-svn: 374646
The file was modifiedllvm/lib/Transforms/Vectorize/LoopVectorize.cpp
Commit c5d1d56731d810f99dc57fbea68826ae60027128 by benny.kra
[Attributor] Extend anonymous namespace. NFC.
llvm-svn: 374647
The file was modifiedllvm/lib/Transforms/IPO/Attributor.cpp
Commit daf42dc36dc2e1092dc6a14a4bb0bce307de58ba by jdenny.ornl
Reland r374388: [lit] Make internal diff work in pipelines
To avoid breaking some tests, D66574, D68664, D67643, and D68668 landed
together.  However, D68664 introduced an issue now addressed by D68839,
with which these are now all relanding.
Differential Revision: https://reviews.llvm.org/D66574
llvm-svn: 374648
The file was removedllvm/utils/lit/tests/Inputs/shtest-shell/diff-error-0.txt
The file was modifiedllvm/utils/lit/lit/TestRunner.py
The file was addedllvm/utils/lit/lit/builtin_commands/diff.py
The file was modifiedllvm/utils/lit/tests/shtest-shell.py
The file was addedllvm/utils/lit/tests/Inputs/shtest-shell/diff-pipes.txt
Commit e4f11a31927e7ca67ff54897de37ef75e31e05ff by jdenny.ornl
Reland r374389: [lit] Clean up internal diff's encoding handling
To avoid breaking some tests, D66574, D68664, D67643, and D68668 landed
together.  However, D68664 introduced an issue now addressed by D68839,
with which these are now all relanding.
Differential Revision: https://reviews.llvm.org/D68664
llvm-svn: 374649
The file was addedllvm/utils/lit/tests/Inputs/shtest-shell/diff-in.utf16
The file was addedllvm/utils/lit/tests/Inputs/shtest-shell/diff-in.bin
The file was addedllvm/utils/lit/tests/Inputs/shtest-shell/diff-encodings.txt
The file was addedllvm/utils/lit/tests/Inputs/shtest-shell/diff-in.utf8
The file was modifiedllvm/utils/lit/lit/builtin_commands/diff.py
The file was modifiedllvm/utils/lit/tests/shtest-shell.py
The file was modifiedllvm/utils/lit/tests/max-failures.py
Commit 32096a86b240a8f4be64094f58162137a17f72d7 by jdenny.ornl
Reland r374390: [lit] Extend internal diff to support `-` argument
To avoid breaking some tests, D66574, D68664, D67643, and D68668 landed
together.  However, D68664 introduced an issue now addressed by D68839,
with which these are now all relanding.
Differential Revision: https://reviews.llvm.org/D67643
llvm-svn: 374650
The file was modifiedllvm/utils/lit/tests/max-failures.py
The file was modifiedllvm/utils/lit/tests/shtest-shell.py
The file was modifiedllvm/utils/lit/lit/builtin_commands/diff.py
The file was modifiedllvm/utils/lit/tests/Inputs/shtest-shell/diff-encodings.txt
The file was modifiedllvm/utils/lit/tests/Inputs/shtest-shell/diff-pipes.txt
The file was addedllvm/utils/lit/tests/Inputs/shtest-shell/diff-r-error-7.txt
The file was addedllvm/utils/lit/tests/Inputs/shtest-shell/diff-r-error-8.txt
Commit 92a8294f9eda2d9b3f7718cba68269a4fc8eea10 by jdenny.ornl
Reland r374392: [lit] Extend internal diff to support -U
To avoid breaking some tests, D66574, D68664, D67643, and D68668 landed
together.  However, D68664 introduced an issue now addressed by D68839,
with which these are now all relanding.
Differential Revision: https://reviews.llvm.org/D68668
llvm-svn: 374651
The file was modifiedllvm/utils/lit/tests/max-failures.py
The file was addedllvm/utils/lit/tests/Inputs/shtest-shell/diff-unified.txt
The file was modifiedllvm/utils/lit/lit/builtin_commands/diff.py
The file was modifiedllvm/utils/lit/tests/shtest-shell.py
Commit 0f80927316c7b12e5c170adec26608dda449497c by jdenny.ornl
[lit] Fix internal diff's --strip-trailing-cr and use it
Using GNU diff, `--strip-trailing-cr` removes a `\r` appearing before a
`\n` at the end of a line.  Without this patch, lit's internal diff only
removes `\r` if it appears as the last character.  That seems useless.
This patch fixes that.
This patch also adds `--strip-trailing-cr` to some tests that fail on
Windows bots when D68664 is applied.  Based on what I see in the bot
logs, I think the following is happening.  In each test there, lit diff
is comparing a file with `\r\n` line endings to a file with `\n` line
endings.  Without D68664, lit diff reads those files with Python's
universal newlines support activated, causing `\r` to be dropped.
However, with D68664, lit diff reads the files in binary mode instead
and thus reports that every line is different, just as GNU diff does (at
least under Ubuntu).  Adding `--strip-trailing-cr` to those tests
restores the previous behavior while permitting the behavior of lit diff
to be more like GNU diff.
Reviewed By: rnk
Differential Revision: https://reviews.llvm.org/D68839
llvm-svn: 374652
The file was modifiedllvm/utils/lit/lit/builtin_commands/diff.py
The file was modifiedllvm/test/tools/llvm-cxxmap/remap.test
The file was modifiedllvm/test/tools/llvm-profdata/sample-remap.test
The file was addedllvm/utils/lit/tests/Inputs/shtest-shell/diff-in.unix
The file was modifiedllvm/test/MC/AsmParser/preserve-comments.s
The file was modifiedllvm/utils/lit/tests/shtest-shell.py
The file was modifiedllvm/test/tools/llvm-profdata/roundtrip.test
The file was modifiedllvm/test/tools/llvm-profdata/profile-symbol-list.test
The file was modifiedllvm/utils/lit/tests/max-failures.py
The file was addedllvm/utils/lit/tests/Inputs/shtest-shell/diff-strip-trailing-cr.txt
The file was addedllvm/utils/lit/tests/Inputs/shtest-shell/diff-in.dos
Commit 648875bbcff72997dbaf951cc3880224c0336f7e by jdenny.ornl
[lit] Fix a few oversights in r374651 that broke some bots
llvm-svn: 374653
The file was modifiedllvm/test/MC/ARM/preserve-comments-arm.s
The file was modifiedllvm/utils/lit/tests/shtest-shell.py
Commit ba229557dd208a39086c5e2bd8db619dca7d9b45 by jdenny.ornl
[lit] Try to fix new tests that fail on Windows bots
llvm-svn: 374654
The file was modifiedllvm/utils/lit/tests/shtest-shell.py
Commit 1b59a16c0b8bd89445b97eee0fde2a152001dbaf by llvm-dev
[CostModel][X86] Improve sum reduction costs.
I can't see any notable differences in costs between SSE2 and SSE42
arches for FADD/ADD reduction, so I've lowered the target to just SSE2.
I've also added vXi8 sum reduction costs in line with the PSADBW codegen
and discussions on PR42674.
llvm-svn: 374655
The file was modifiedllvm/test/Analysis/CostModel/X86/reduce-add.ll
The file was modifiedllvm/test/Transforms/SLPVectorizer/X86/remark_horcost.ll
The file was modifiedllvm/lib/Target/X86/X86TargetTransformInfo.cpp
The file was modifiedllvm/test/Analysis/CostModel/X86/reduction.ll
Commit 0e22cb6ce39b139d35118a7b198390a4e536f0a0 by jdenny.ornl
Revert r374654: "[lit] Try to fix new tests that fail on Windows bots"
llvm-svn: 374656
The file was modifiedllvm/utils/lit/tests/shtest-shell.py
Commit 1f5823b788037b0dc8c846a22ef6a5a8a0714af7 by jdenny.ornl
[lit] Try again to fix new tests that fail on Windows bots
Based on the bot logs, when lit's internal diff runs on Windows, it
looks like binary diffs must be decoded also for Python 2.7. Otherwise,
writing the diff to stdout fails with:
``` UnicodeEncodeError: 'ascii' codec can't encode characters in
position 7-8: ordinal not in range(128)
```
I did not need to decode using Python 2.7.15 under Ubuntu.  When I do it
anyway in that case, `errors="backslashreplace"` fails for me:
``` TypeError: don't know how to handle UnicodeDecodeError in error
callback
```
However, `errors="ignore"` works, so this patch uses that, hoping it'll
work on Windows as well.
This patch leaves `errors="backslashreplace"` for Python >= 3.5 as
there's no evidence yet that doesn't work and it produces more
informative binary diffs.  This patch also adjusts some lit tests to
succeed for either error handler.
This patch adjusts changes introduced by D68664.
llvm-svn: 374657
The file was modifiedllvm/utils/lit/tests/shtest-shell.py
The file was modifiedllvm/utils/lit/lit/builtin_commands/diff.py