FailedChanges

Summary

  1. Change `asan/TestCases/Darwin/malloc_zone-protected.cpp` to call abort (details)
  2. [llvm/runtimes] Add runtimes as a dependency of clang-bootstrap-deps (details)
  3. [LoopUtils] Updated deleteDeadLoop() to handle loop nest. (details)
  4. [LoopUtils] Updated deleteDeadLoop() to handle loop nest. (details)
  5. gn build: Merge c066ff11d84 (details)
  6. [libomptarget][nfc] Wrap cuda min() in target_impl (details)
  7. Run all threads when extending a next range over a call. (details)
  8. [c++20] Add deprecation warnings for the expression forms deprecated by (details)
  9. If constant evaluation fails due to an unspecified pointer comparison, (details)
  10. [c++20] P1959R0: Remove support for std::*_equality. (details)
  11. [SelectionDAG] Add the fpexcept flag to the SelectionDAG dumping output (details)
  12. Explicitly specify -std=c++11 and include <mutex> and (details)
  13. [libomptarget][nfc] Move timer functions behind target_impl (details)
  14. Check whether the destination is a complete type in a static_cast (or (details)
Commit e2bcc33b50f6ca8f37ce2d501b88119fc21eb783 by dan
Change `asan/TestCases/Darwin/malloc_zone-protected.cpp` to call abort
so that it **always crashes**.
Summary: This is needed because on some platforms we can't install
signal handlers and so the application just traps (i.e. crashes) rather
than being intercepted by ASan's signal handler which in the default
Darwin config doesn't exit with a crashing exit code.
rdar://problem/57984547
Reviewers: yln, kubamracek, jfb
Subscribers: #sanitizers, llvm-commits
Tags: #sanitizers, #llvm
Differential Revision: https://reviews.llvm.org/D71573
The file was modifiedcompiler-rt/test/asan/TestCases/Darwin/malloc_zone-protected.cpp
Commit d6777207b4fd4868a4409cc39936156ec3aa3c50 by apl
[llvm/runtimes] Add runtimes as a dependency of clang-bootstrap-deps
Summary: With the new LLVM_ENABLE_RUNTIMES option introduced in
https://reviews.llvm.org/D40233, compiler-rt can now be included as a
runtime. Since compiler-rt is needed for PGO, runtimes needs to be
included as a dependency of clang-bootstrap-deps when building the
stage1 compiler.
Reviewers: beanz, phosek, compnerd, smeenai, plotfi, xiaobai
Reviewed By: phosek
Subscribers: smeenai, beanz, phosek, mgorny, llvm-commits
Tags: #llvm
Differential Revision: https://reviews.llvm.org/D71430
The file was modifiedllvm/runtimes/CMakeLists.txt
Commit c066ff11d84a7797503ad5a44c4129136926dc85 by whitneyt
[LoopUtils] Updated deleteDeadLoop() to handle loop nest.
Reviewer: kariddi, sanjoy, reames, Meinersbur, bmahjour, etiotto,
kbarton Reviewed By: Meinersbur Subscribers: mgorny, hiraditya,
llvm-commits Tag: LLVM Differential Revision:
https://reviews.llvm.org/D70939
The file was modifiedllvm/unittests/Transforms/Utils/CMakeLists.txt
The file was modifiedllvm/lib/Transforms/Utils/LoopUtils.cpp
Commit cd09fee3d63296dd2df0bbb1fae363ca9f311d44 by whitneyt
[LoopUtils] Updated deleteDeadLoop() to handle loop nest.
Reviewer: kariddi, sanjoy, reames, Meinersbur, bmahjour, etiotto,
kbarton Reviewed By: Meinersbur Subscribers: mgorny, hiraditya,
llvm-commits Tag: LLVM Differential Revision:
https://reviews.llvm.org/D70939
The file was addedllvm/unittests/Transforms/Utils/LoopUtilsTest.cpp
Commit 7a31678b71465da7e6a69bb3d1987823f41589d6 by llvmgnsyncbot
gn build: Merge c066ff11d84
The file was modifiedllvm/utils/gn/secondary/llvm/unittests/Transforms/Utils/BUILD.gn
Commit 53bcd1e1413c878d2d988df80142a430a9abf24a by jonathanchesterfield
[libomptarget][nfc] Wrap cuda min() in target_impl
Summary:
[libomptarget][nfc] Wrap cuda min() in target_impl
nvptx forwards to cuda min, amdgcn implements directly. Sufficient to
build parallel.cu for amdgcn, added to CMakeLists.
All call sites are homogenous except one that passes a uint32_t and an
int32_t. This could be smoothed over by taking two type parameters and
some care over the return type, but overall I think the inline
<uint32_t> calling attention to what was an implicit sign conversion is
cleaner.
Reviewers: ABataev, jdoerfert
Reviewed By: jdoerfert
Subscribers: jvesely, mgorny, openmp-commits
Tags: #openmp
Differential Revision: https://reviews.llvm.org/D71580
The file was modifiedopenmp/libomptarget/deviceRTLs/common/src/parallel.cu
The file was modifiedopenmp/libomptarget/deviceRTLs/nvptx/src/target_impl.h
The file was modifiedopenmp/libomptarget/deviceRTLs/nvptx/src/reduction.cu
The file was modifiedopenmp/libomptarget/deviceRTLs/amdgcn/src/target_impl.h
The file was modifiedopenmp/libomptarget/deviceRTLs/amdgcn/CMakeLists.txt
Commit 434905b97d961531286d4b49c7ee1969f7cbea0e by jingham
Run all threads when extending a next range over a call.
If you don't do this you end up running arbitrary code with only one
thread allowed to run, which can cause deadlocks.
<rdar://problem/56422478>
Differential Revision: https://reviews.llvm.org/D71440
The file was removedlldb/packages/Python/lldbsuite/test/commands/expression/no-deadlock/locking.c
The file was addedlldb/packages/Python/lldbsuite/test/lang/c/step_over_no_deadlock/locking.cpp
The file was modifiedlldb/source/Target/ThreadPlanStepRange.cpp
The file was modifiedlldb/packages/Python/lldbsuite/test/commands/expression/no-deadlock/Makefile
The file was modifiedlldb/packages/Python/lldbsuite/test/commands/expression/no-deadlock/TestExprDoesntBlock.py
The file was addedlldb/packages/Python/lldbsuite/test/commands/expression/no-deadlock/locking.cpp
The file was addedlldb/packages/Python/lldbsuite/test/lang/c/step_over_no_deadlock/Makefile
The file was addedlldb/packages/Python/lldbsuite/test/lang/c/step_over_no_deadlock/TestStepOverDoesntBlock.py
The file was modifiedlldb/include/lldb/Target/ThreadPlanStepRange.h
The file was modifiedlldb/source/Target/Process.cpp
The file was modifiedlldb/include/lldb/Core/Disassembler.h
The file was modifiedlldb/source/Core/Disassembler.cpp
Commit 4b0029995853fe37d1dc95ef96f46697c743fcad by richard
[c++20] Add deprecation warnings for the expression forms deprecated by
P1120R0.
This covers:
* usual arithmetic conversions (comparisons, arithmetic, conditionals)
  between different enumeration types
* usual arithmetic conversions between enums and floating-point types
* comparisons between two operands of array type
The deprecation warnings are on-by-default (in C++20 compilations); it
seems likely that these forms will become ill-formed in C++23, so
warning on them now by default seems wise.
For the first two bullets, off-by-default warnings were also added for
all the cases where we didn't already have warnings (covering language
modes prior to C++20). These warnings are in subgroups of the existing
-Wenum-conversion (except that the first case is not warned on if either
enumeration type is anonymous, consistent with our existing
-Wenum-conversion warnings).
The file was modifiedclang/include/clang/Basic/DiagnosticSemaKinds.td
The file was modifiedclang/lib/Sema/SemaExpr.cpp
The file was modifiedclang/lib/Sema/SemaExprCXX.cpp
The file was modifiedclang/include/clang/Basic/DiagnosticGroups.td
The file was modifiedclang/test/Sema/warn-conditional-emum-types-mismatch.c
The file was modifiedclang/test/SemaCXX/warn-enum-compare.cpp
The file was modifiedclang/www/cxx_status.html
The file was modifiedclang/test/SemaCXX/self-comparison.cpp
The file was modifiedclang/test/Sema/switch.c
The file was modifiedclang/lib/Sema/SemaChecking.cpp
The file was modifiedclang/include/clang/Sema/Sema.h
The file was addedclang/test/CXX/expr/expr.arith.conv/p2.cpp
The file was modifiedclang/include/clang/AST/Type.h
The file was modifiedclang/lib/AST/Type.cpp
The file was modifiedclang/test/SemaCXX/deprecated.cpp
Commit 4e9f1379b9cd7ddce8cf182707e976ebceb72b05 by richard
If constant evaluation fails due to an unspecified pointer comparison,
produce a note saying that rather than the default "evaluation failed"
note.
The file was modifiedclang/test/SemaCXX/constant-expression-cxx11.cpp
The file was modifiedclang/test/CXX/expr/expr.const/p2-0x.cpp
The file was modifiedclang/include/clang/Basic/DiagnosticASTKinds.td
The file was modifiedclang/lib/AST/ExprConstant.cpp
The file was modifiedclang/test/SemaCXX/constant-expression-cxx2a.cpp
Commit f495de43bd5da50286da6020e508d106cfc60f57 by richard
[c++20] P1959R0: Remove support for std::*_equality.
The file was modifiedclang/lib/AST/ExprConstant.cpp
The file was modifiedclang/test/CodeGenCXX/cxx2a-compare.cpp
The file was modifiedclang/lib/AST/ComparisonCategories.cpp
The file was modifiedclang/test/CodeGenCXX/Inputs/std-compare.h
The file was modifiedclang/www/cxx_status.html
The file was modifiedclang/include/clang/Basic/DiagnosticSemaKinds.td
The file was modifiedclang/lib/Sema/SemaExpr.cpp
The file was modifiedclang/test/SemaCXX/compare-cxx2a.cpp
The file was modifiedclang/lib/AST/Interp/Interp.h
The file was modifiedclang/test/PCH/Inputs/std-compare.h
The file was modifiedclang/lib/Sema/SemaOverload.cpp
The file was modifiedclang/test/SemaCXX/constant-expression-cxx2a.cpp
The file was modifiedclang/test/SemaCXX/std-compare-cxx2a.cpp
The file was modifiedclang/lib/CodeGen/CGExprAgg.cpp
The file was modifiedclang/include/clang/AST/ComparisonCategories.h
The file was modifiedclang/include/clang/AST/Type.h
The file was modifiedclang/test/SemaCXX/Inputs/std-compare.h
Commit 4e48513b472bddf239fc4a9953b0e8c856f284ef by craig.topper
[SelectionDAG] Add the fpexcept flag to the SelectionDAG dumping output
so we can better see when its not propagating.
We're currently losing this flag in type legalization and probably other
places when we expand strict fp nodes. This will make reading logs
easier.
The file was modifiedllvm/lib/CodeGen/SelectionDAG/SelectionDAGDumper.cpp
Commit 9e9c5f0a6346ef02e31d5e8b91e6aab16a2e9370 by jingham
Explicitly specify -std=c++11 and include <mutex> and
<condition_variable>.
These files built on macos but not on Debian Linux.  Let's see if this
fixes it.
The file was modifiedlldb/packages/Python/lldbsuite/test/commands/expression/no-deadlock/Makefile
The file was modifiedlldb/packages/Python/lldbsuite/test/commands/expression/no-deadlock/locking.cpp
The file was modifiedlldb/packages/Python/lldbsuite/test/lang/c/step_over_no_deadlock/Makefile
The file was modifiedlldb/packages/Python/lldbsuite/test/lang/c/step_over_no_deadlock/locking.cpp
Commit ce12a523b0e1a64cea63ba099642d7f3492a3791 by jonathanchesterfield
[libomptarget][nfc] Move timer functions behind target_impl
Summary: [libomptarget][nfc] Move timer functions behind target_impl
Reviewers: jdoerfert, ABataev, grokos
Reviewed By: jdoerfert
Subscribers: jvesely, openmp-commits
Tags: #openmp
Differential Revision: https://reviews.llvm.org/D71584
The file was modifiedopenmp/libomptarget/deviceRTLs/nvptx/src/target_impl.h
The file was modifiedopenmp/libomptarget/deviceRTLs/amdgcn/src/target_impl.h
The file was modifiedopenmp/libomptarget/deviceRTLs/nvptx/src/libcall.cu
Commit eea8ba097c4a86632b88291bea51eb710f8ae4fb by richard
Check whether the destination is a complete type in a static_cast (or
C-style cast) to an enumeration type.
We previously forgot to check this, and happened to get away with it
(with bad diagnostics) only because we misclassified incomplete
enumeration types as not being unscoped enumeration types. This also
fixes the misclassification.
The file was modifiedclang/lib/AST/Type.cpp
The file was modifiedclang/lib/Sema/SemaCast.cpp
The file was modifiedclang/include/clang/Basic/DiagnosticSemaKinds.td
The file was modifiedclang/test/SemaCXX/enum.cpp