SuccessChanges

Summary

  1. [lldb/Plugin] Remove PLUGIN from Process POSIX & Linux (details)
  2. Fix modules build after https://reviews.llvm.org/D73835 (IRBuilder virtualization change) (details)
  3. GlobalISel: Allow running localizer earlier (details)
  4. Revert "Add LazyCallGraph API to add function to RefSCC" (details)
  5. [X86] Move '0-x == y --> x+y == 0' and similar combines to EmitCmp. (details)
  6. [X86] Change how the alignment for the stack object is created in LowerFLT_ROUNDS_. (details)
Commit deaa6916d3424ff9c9dfd81379dc9f4906d915f4 by Jonas Devlieghere
[lldb/Plugin] Remove PLUGIN from Process POSIX & Linux

ProcessPOSIX and ProcessLinux are not real plugins and should not be
marked as such. This should fix the Linux bots.
The file was modifiedlldb/source/Plugins/Process/POSIX/CMakeLists.txt (diff)
The file was modifiedlldb/source/Plugins/Process/Linux/CMakeLists.txt (diff)
Commit 7424705157ba051d8e2f21815f5e051c4d786b94 by Vedant Kumar
Fix modules build after https://reviews.llvm.org/D73835 (IRBuilder virtualization change)

I readily admit that I don't know why this fixes the modules build, but
it seems to get things building again. Previously I saw the error
message:

http://lab.llvm.org:8080/green/view/LLDB/job/lldb-cmake/9404/consoleFull#-361314398a1ca8a51-895e-46c6-af87-ce24fa4cd561

```
/Users/buildslave/jenkins/workspace/lldb-cmake/llvm-project/llvm/include/llvm/IR/IRBuilderFolder.h:18:10: fatal error: cyclic dependency in module 'LLVM_intrinsic_gen': LLVM_intrinsic_gen -> LLVM_IR -> LLVM_intrinsic_gen

         ^
While building module 'LLVM_intrinsic_gen' imported from /Users/buildslave/jenkins/workspace/lldb-cmake/llvm-project/llvm/lib/IR/IRBuilder.cpp:14:
In file included from <module-includes>:1:
/Users/buildslave/jenkins/workspace/lldb-cmake/llvm-project/llvm/include/llvm/IR/Argument.h:19:10: fatal error: could not build module 'LLVM_IR'
~~~~~~~~^~~~~~~~~~~~~~~~~
/Users/buildslave/jenkins/workspace/lldb-cmake/llvm-project/llvm/lib/IR/IRBuilder.cpp:14:10: fatal error: could not build module 'LLVM_intrinsic_gen'
```

And reproduced with:

cmake -G Ninja /Users/vsk/src/llvm-backup-master/llvm -DCLANG_ENABLE_ARCMT=Off -DCLANG_ENABLE_STATIC_ANALYZER=Off -DLLVM_ENABLE_PROJECTS='clang;clang-tools-extra;lld;libcxx;libcxxabi;compiler-rt;libunwind;lldb' -DLLDB_USE_SYSTEM_DEBUGSERVER=On -DCMAKE_BUILD_TYPE=RelWithDebInfo -DLLVM_ENABLE_ASSERTIONS=On -DLLVM_ENABLE_MODULES=On
The file was modifiedllvm/include/llvm/module.modulemap (diff)
Commit 54137bbaaf185553ad82107e011b80c0381912b9 by Matthew.Arsenault
GlobalISel: Allow running localizer earlier

This required legal and regbankselected MIR for seemingly no
reason. For AMDGPU this wouldn't see legalized G_GLOBAL_VALUEs.
The file was modifiedllvm/lib/Target/AMDGPU/AMDGPUTargetMachine.cpp (diff)
The file was modifiedllvm/test/CodeGen/AMDGPU/GlobalISel/localizer.ll (diff)
The file was modifiedllvm/include/llvm/CodeGen/GlobalISel/Localizer.h (diff)
The file was modifiedllvm/test/CodeGen/AMDGPU/GlobalISel/divergent-control-flow.ll (diff)
The file was modifiedllvm/test/CodeGen/AMDGPU/GlobalISel/llvm.amdgcn.s.buffer.load.ll (diff)
Commit 28213680b2a7d1fdeea16aa3f3a368879472c72a by modocache
Revert "Add LazyCallGraph API to add function to RefSCC"

This reverts commit https://reviews.llvm.org/rG449a13509190b1c57e5fcf5cd7e8f0f647f564b4,
due to buildbot failures such as
http://lab.llvm.org:8011/builders/clang-cmake-x86_64-avx2-linux/builds/13251.
The file was modifiedllvm/lib/Analysis/LazyCallGraph.cpp (diff)
The file was modifiedllvm/unittests/Analysis/CGSCCPassManagerTest.cpp (diff)
The file was modifiedllvm/unittests/Analysis/LazyCallGraphTest.cpp (diff)
The file was modifiedllvm/include/llvm/Analysis/LazyCallGraph.h (diff)
Commit b62de210cf50ccb6822260e4075dd93333adb23e by craig.topper
[X86] Move '0-x == y --> x+y == 0' and similar combines to EmitCmp.

AArch64 handles this pattern in their lowering code. By emitting
CMN. ARM handles it as an isel pattern.
The file was modifiedllvm/lib/Target/X86/X86ISelLowering.cpp (diff)
Commit 43e948c4b77f1da88511bac38cfcf4752bc19d37 by craig.topper
[X86] Change how the alignment for the stack object is created in LowerFLT_ROUNDS_.

We don't need FrameInfo's concept of the stack alignment. We just
need to tell it the desired alignment. Which in this case is 2.
The file was modifiedllvm/test/CodeGen/X86/flt-rounds.ll (diff)
The file was modifiedllvm/lib/Target/X86/X86ISelLowering.cpp (diff)