SuccessChanges

Summary

  1. Revert "Change clang option -ffp-model=precise to select ffp-contract=on" (details)
  2. [AMDGPU] Fixed subreg use in sdwa-scalar-ops.mir. NFC (details)
  3. [Utils] Allow "on-the-fly" argument changes for update_test_check scripts (details)
  4. [X86] Don't disable code in combineHorizontalPredicateResult just because we have avx512 (details)
  5. Use C++14-style return type deduction in clang. (details)
  6. [mlir] Start Shape dialect (details)
  7. [NFC] Fix spelling (details)
  8. [NFC] Fix warning: comparison of integers of different signs. (details)
  9. [MachO] Pad section data to pointer size bytes (details)
  10. AMDGPU: Don't create potentially dead rcp declarations (details)
  11. AMDGPU: Directly use rcp intrinsic in idiv expansions (details)
  12. AMDGPU: Fix crash on v3i15 kernel arguments (details)
  13. AMDGPU: Add baseline tests for CGP div expansion (details)
  14. [OpenMP] Switch default C++ standard to C++ 14 (details)
  15. Use std::foo_t rather than std::foo in LLVM. (details)
  16. [llvm-objcopy][WebAssembly] Add dump/add/remove-section support (details)
  17. AMDGPU: Don't report 2-byte alignment as fast (details)
  18. [lldb/Plugins] Move PlatformRemoteiOS into PlatformMacOSX (NFCI) (details)
  19. Fix MSVC build with C++ EH enabled (details)
  20. AMDGPU: Don't expand more special div cases in IR (details)
  21. Rewrite default "could not attach" msg to point to hints (details)
  22. Reverted the remainings of c1c9819ef91aab51b5a23fb3027adac5a2f551cc (details)
  23. [lldb/Plugins] Rename OSPython plugin to OperatingSystemPython (NFC) (details)
Commit 99c5bcbce89f07e68ccd89891a0300346705d013 by melanie.blower
Revert "Change clang option -ffp-model=precise to select ffp-contract=on"

This reverts commit 3fcdf2fa945aca5849c5587c55de4186c7d81b8a.
Sorry I was too hasty with my commit, I will review Andy's comments
and resubmit.
The file was modifiedclang/test/Driver/fp-model.c
The file was modifiedclang/docs/UsersManual.rst
The file was modifiedclang/test/CodeGen/ppc-emmintrin.c
The file was modifiedclang/lib/Driver/ToolChains/Clang.cpp
The file was modifiedclang/test/CodeGen/ppc-xmmintrin.c
Commit d538dc05f3b50653b97c13b446121ac16c364a14 by Stanislav.Mekhanoshin
[AMDGPU] Fixed subreg use in sdwa-scalar-ops.mir. NFC
The file was modifiedllvm/test/CodeGen/AMDGPU/sdwa-scalar-ops.mir
Commit 1698cc7ebabe47be6cf225960e55ddb8a884d118 by johannes
[Utils] Allow "on-the-fly" argument changes for update_test_check scripts

Update test scripts were limited because they performed a single action
on the entire file and if that action was controlled by arguments, like
the one introduced in D68819, there was no record of it.

This patch introduces the capability of changing the arguments passed to
the script "on-the-fly" while processing a test file. In addition, an
"on/off" switch was added so that processing can be disabled for parts
of the file where the content is simply copied. The last extension is a
record of the invocation arguments in the auto generated NOTE. These
arguments are also picked up in a subsequent invocation, allowing
updates with special options enabled without user interaction.

To change the arguments the string `UTC_ARGS:` has to be present in a
line, followed by "additional command line arguments". That is
everything that follows `UTC_ARGS:` will be added to a growing list
of "command line arguments" which is reparsed after every update.

Reviewed By: arichardson

Differential Revision: https://reviews.llvm.org/D69701
The file was addedllvm/test/tools/UpdateTestChecks/update_test_checks/Inputs/on_the_fly_arg_change.ll
The file was modifiedllvm/test/Transforms/Attributor/liveness.ll
The file was modifiedllvm/test/tools/UpdateTestChecks/update_test_checks/Inputs/basic.ll.funcsig.expected
The file was modifiedllvm/utils/update_test_checks.py
The file was modifiedllvm/test/Transforms/Attributor/align.ll
The file was modifiedllvm/test/tools/UpdateTestChecks/update_test_checks/scrub_attrs.test
The file was addedllvm/test/tools/UpdateTestChecks/update_test_checks/Inputs/on_the_fly_arg_change.ll.expected
The file was addedllvm/test/tools/UpdateTestChecks/update_test_checks/on_the_fly_arg_change.test
The file was modifiedllvm/test/tools/UpdateTestChecks/update_test_checks/Inputs/scrub_attrs.ll.scrub.expected
The file was modifiedllvm/test/tools/UpdateTestChecks/update_test_checks/Inputs/argument_name_reuse.ll.expected
The file was modifiedllvm/test/tools/UpdateTestChecks/update_test_checks/basic.test
The file was modifiedllvm/utils/UpdateTestChecks/common.py
Commit 846d0ac43eb95c7f2f7e98b076b42c8c3208f506 by craig.topper
[X86] Don't disable code in combineHorizontalPredicateResult just because we have avx512

We aren't doing a good job of optimizing AVX512 outside of this code. So remove the bail out for AVX512 and replace with a FIXME. This at least gets us the AVX2 codegen.

Differential Revision: https://reviews.llvm.org/D74431
The file was modifiedllvm/test/CodeGen/X86/vector-compare-all_of.ll
The file was modifiedllvm/test/CodeGen/X86/vector-compare-any_of.ll
The file was modifiedllvm/lib/Target/X86/X86ISelLowering.cpp
Commit ac66c61bf9463bf419102ad8b6565dcbc495b0ab by jlebar
Use C++14-style return type deduction in clang.

Summary:
Simplifies the C++11-style "-> decltype(...)" return-type deduction.

Note that you have to be careful about whether the function return type
is `auto` or `decltype(auto)`.  The difference is that bare `auto`
strips const and reference, just like lambda return type deduction.  In
some cases that's what we want (or more likely, we know that the return
type is a value type), but whenever we're wrapping a templated function
which might return a reference, we need to be sure that the return type
is decltype(auto).

No functional change.

Reviewers: bkramer, MaskRay, martong, shafik

Subscribers: martong, cfe-commits

Tags: #clang

Differential Revision: https://reviews.llvm.org/D74423
The file was modifiedclang/lib/StaticAnalyzer/Checkers/GCDAntipatternChecker.cpp
The file was modifiedclang/lib/StaticAnalyzer/Checkers/OSObjectCStyleCast.cpp
The file was modifiedclang/lib/StaticAnalyzer/Checkers/ObjCAutoreleaseWriteChecker.cpp
The file was modifiedclang/lib/AST/ASTImporter.cpp
The file was modifiedclang/lib/StaticAnalyzer/Checkers/PointerSortingChecker.cpp
Commit 7baf2a434c8675752efeb185984ca01dbc03f7a4 by jpienaar
[mlir] Start Shape dialect

* Add basic skeleton for Shape dialect;
* Add description of types and ops to be used;

Differential Revision: https://reviews.llvm.org/D73944
The file was modifiedmlir/include/mlir/Dialect/CMakeLists.txt
The file was addedmlir/include/mlir/Dialect/Shape/CMakeLists.txt
The file was modifiedmlir/lib/Dialect/CMakeLists.txt
The file was addedmlir/include/mlir/Dialect/Shape/IR/ShapeOps.td
The file was addedmlir/lib/Dialect/Shape/CMakeLists.txt
The file was addedmlir/include/mlir/Dialect/Shape/IR/CMakeLists.txt
The file was addedmlir/include/mlir/Dialect/Shape/IR/Shape.h
The file was modifiedmlir/include/mlir/IR/DialectSymbolRegistry.def
The file was addedmlir/lib/Dialect/Shape/DialectRegistration.cpp
Commit 1217ea502edb4884c2438692bfcad1dde6e14bf9 by johannes
[NFC] Fix spelling
The file was modifiedllvm/utils/update_test_checks.py
Commit aedda89f656b286cff44756a4dcb50117051ebe9 by huihuiz
[NFC] Fix warning: comparison of integers of different signs.

../polly/lib/Transform/ScheduleOptimizer.cpp:812:54: warning: comparison of integers of different signs: 'isl_size' (aka 'int') and 'const unsigned int' [-Wsign-compare]
         isl_schedule_node_band_n_member(Node.get()) >
         ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ ^
The file was modifiedpolly/lib/Transform/ScheduleOptimizer.cpp
Commit bdc3c73454aa04eda74dff2e5061482e13ed4ee7 by aditya_nandakumar
[MachO] Pad section data to pointer size bytes

https://reviews.llvm.org/D74273

Pad macho section data to pointer size bytes, so that relocation
table and symbol table following section data will be pointer size
aligned.

Patch by pguo.
The file was modifiedllvm/lib/MC/MachObjectWriter.cpp
The file was modifiedllvm/test/MC/MachO/darwin-x86_64-diff-relocs.s
The file was modifiedllvm/test/MC/MachO/variable-exprs.s
Commit b87e3e2d0db8b0eb7a8f26525dad74cc7014b85f by arsenm2
AMDGPU: Don't create potentially dead rcp declarations

This will introduce unused declarations if this doesn't reach any of
the paths that will really use it.
The file was modifiedllvm/lib/Target/AMDGPU/AMDGPUCodeGenPrepare.cpp
Commit 92c62582fc546c56b73f78402291337a24acf54e by arsenm2
AMDGPU: Directly use rcp intrinsic in idiv expansions

Since natural fdiv lowering is now more conservative even with
denormals disabled, we get a slower expansion from just a plain
1.0/fdiv. Directly emit the rcp intrinsic when using it to implement
integer division to avoid a pointlessly complex sequence.
The file was modifiedllvm/test/CodeGen/AMDGPU/amdgpu-codegenprepare-fold-binop-select.ll
The file was modifiedllvm/lib/Target/AMDGPU/AMDGPUCodeGenPrepare.cpp
The file was modifiedllvm/test/CodeGen/AMDGPU/divrem24-assume.ll
The file was modifiedllvm/test/CodeGen/AMDGPU/amdgpu-codegenprepare-idiv.ll
Commit f734ce0488d45c8073892abb6805c9fd9d99fd46 by arsenm2
AMDGPU: Fix crash on v3i15 kernel arguments

This was split into 3 i15 arguments. The i15 piece needs to be rounded
to a simple MVT for the memory type.
The file was modifiedllvm/lib/Target/AMDGPU/AMDGPUISelLowering.cpp
The file was modifiedllvm/test/CodeGen/AMDGPU/kernel-argument-dag-lowering.ll
Commit d3a96fc082bef6a15f1ce8aed1849ff4122636dc by arsenm2
AMDGPU: Add baseline tests for CGP div expansion

These cases are harmed by expanding division early in the IR, before
DAGCombiner.
The file was modifiedllvm/test/CodeGen/AMDGPU/amdgpu-codegenprepare-idiv.ll
Commit 3ff4e2eee8c39fd4ae13b1df412f0af219fbf382 by johannes
[OpenMP] Switch default C++ standard to C++ 14

Reviewed By: JonChesterfield

Differential Revision: https://reviews.llvm.org/D74258
The file was modifiedopenmp/libomptarget/cmake/Modules/LibomptargetNVPTXBitcodeLibrary.cmake
The file was modifiedopenmp/CMakeLists.txt
The file was modifiedopenmp/cmake/HandleOpenMPOptions.cmake
The file was modifiedopenmp/cmake/config-ix.cmake
The file was modifiedopenmp/libomptarget/deviceRTLs/amdgcn/CMakeLists.txt
The file was modifiedopenmp/tools/archer/tests/lit.cfg
The file was modifiedopenmp/runtime/test/lit.cfg
Commit 1bd6123b781120c9190b9ba58b900cdcb718cdd1 by jlebar
Use std::foo_t rather than std::foo in LLVM.

Summary: C++14 migration. No functional change.

Reviewers: bkramer, JDevlieghere, lebedev.ri

Subscribers: MatzeB, hiraditya, jkorous, dexonsmith, arphaman, kadircet, lebedev.ri, usaxena95, cfe-commits, llvm-commits

Tags: #clang, #llvm

Differential Revision: https://reviews.llvm.org/D74384
The file was modifiedllvm/include/llvm/Support/GenericIteratedDominanceFrontier.h
The file was modifiedllvm/include/llvm/ADT/APFloat.h
The file was modifiedllvm/include/llvm/IR/Metadata.h
The file was modifiedllvm/include/llvm/ADT/DenseMap.h
The file was modifiedllvm/tools/dsymutil/CFBundle.cpp
The file was modifiedllvm/lib/Support/ItaniumManglingCanonicalizer.cpp
The file was modifiedllvm/utils/benchmark/include/benchmark/benchmark.h
The file was modifiedllvm/include/llvm/Support/AllocatorBase.h
The file was modifiedllvm/include/llvm/Support/Casting.h
The file was modifiedllvm/include/llvm/ExecutionEngine/Orc/Core.h
The file was modifiedllvm/include/llvm/IR/Constants.h
The file was modifiedllvm/include/llvm/Support/TaskQueue.h
The file was modifiedllvm/include/llvm/ADT/Any.h
The file was modifiedllvm/include/llvm/Support/BinaryStreamReader.h
The file was modifiedllvm/include/llvm/Support/Chrono.h
The file was modifiedllvm/include/llvm/Object/ELFTypes.h
The file was modifiedllvm/include/llvm/Support/MSVCErrorWorkarounds.h
The file was modifiedllvm/include/llvm/ADT/StringRef.h
The file was modifiedllvm/include/llvm/Support/BinaryStreamWriter.h
The file was modifiedllvm/include/llvm/FuzzMutate/Random.h
The file was modifiedllvm/include/llvm/Support/Endian.h
The file was modifiedllvm/include/llvm/Support/TrailingObjects.h
The file was modifiedllvm/include/llvm/ADT/STLExtras.h
The file was modifiedllvm/include/llvm/ADT/ilist_iterator.h
The file was modifiedllvm/utils/unittest/googlemock/include/gmock/gmock-matchers.h
The file was modifiedllvm/include/llvm/ExecutionEngine/Orc/OrcRemoteTargetServer.h
The file was modifiedllvm/include/llvm/ExecutionEngine/Orc/RPC/RPCSerialization.h
The file was modifiedllvm/include/llvm/ADT/ArrayRef.h
The file was modifiedllvm/utils/benchmark/src/sysinfo.cc
The file was modifiedllvm/include/llvm/IR/ValueMap.h
The file was modifiedllvm/lib/Target/AArch64/MCTargetDesc/AArch64InstPrinter.cpp
The file was modifiedllvm/include/llvm/ExecutionEngine/Orc/RPC/RawByteChannel.h
The file was modifiedllvm/include/llvm/Support/MathExtras.h
The file was modifiedllvm/lib/Support/NativeFormatting.cpp
The file was modifiedllvm/unittests/XRay/GraphTest.cpp
The file was modifiedllvm/include/llvm/ExecutionEngine/JITSymbol.h
The file was modifiedclang-tools-extra/clang-tidy/ClangTidyCheck.h
The file was modifiedllvm/include/llvm/ADT/PriorityWorklist.h
The file was modifiedllvm/include/llvm/ADT/SmallVector.h
The file was modifiedllvm/include/llvm/Support/ErrorOr.h
The file was modifiedllvm/include/llvm/IR/DiagnosticInfo.h
The file was modifiedllvm/lib/Demangle/ItaniumDemangle.cpp
The file was modifiedllvm/include/llvm/ADT/Hashing.h
The file was modifiedllvm/tools/llvm-xray/trie-node.h
The file was modifiedllvm/include/llvm/DebugInfo/CodeView/CodeViewRecordIO.h
The file was modifiedllvm/include/llvm/ADT/BitmaskEnum.h
The file was modifiedllvm/include/llvm/Support/JSON.h
The file was modifiedllvm/include/llvm/CodeGen/LiveInterval.h
The file was modifiedllvm/include/llvm/Support/raw_ostream.h
The file was modifiedllvm/include/llvm/Support/YAMLTraits.h
The file was modifiedllvm/include/llvm/Support/type_traits.h
The file was modifiedllvm/include/llvm/Support/Error.h
The file was modifiedllvm/include/llvm/XRay/Graph.h
The file was modifiedllvm/lib/Target/AArch64/AsmParser/AArch64AsmParser.cpp
The file was modifiedllvm/include/llvm/CodeGen/MachineInstrBundleIterator.h
The file was modifiedllvm/include/llvm/ExecutionEngine/Orc/Legacy.h
The file was modifiedllvm/include/llvm/Analysis/RegionInfo.h
The file was modifiedclang-tools-extra/clangd/Shutdown.h
The file was modifiedllvm/include/llvm/Support/FormatVariadicDetails.h
The file was modifiedllvm/include/llvm/ADT/iterator.h
The file was modifiedllvm/include/llvm/BinaryFormat/Dwarf.h
The file was modifiedllvm/include/llvm/Support/CommandLine.h
The file was modifiedllvm/include/llvm/IR/DerivedTypes.h
The file was modifiedllvm/include/llvm/Analysis/RegionInfoImpl.h
The file was modifiedllvm/include/llvm/ADT/AllocatorList.h
The file was modifiedllvm/include/llvm/Support/GenericDomTree.h
The file was modifiedllvm/tools/llvm-pdbutil/FormatUtil.h
The file was modifiedllvm/include/llvm/Support/SwapByteOrder.h
The file was modifiedllvm/unittests/IR/PatternMatch.cpp
The file was modifiedllvm/include/llvm/Support/FormatProviders.h
The file was modifiedllvm/include/llvm/Support/CheckedArithmetic.h
The file was modifiedllvm/unittests/ADT/DenseSetTest.cpp
The file was modifiedllvm/lib/XRay/FDRTraceWriter.cpp
The file was modifiedllvm/lib/Target/AArch64/MCTargetDesc/AArch64AddressingModes.h
The file was modifiedllvm/include/llvm/ADT/TinyPtrVector.h
The file was modifiedllvm/include/llvm/ExecutionEngine/Orc/OrcRemoteTargetRPCAPI.h
The file was modifiedllvm/include/llvm/ExecutionEngine/Orc/RPC/RPCUtils.h
Commit b2c44de956cca22efa374cfb587912b38c41ed67 by dschuff
[llvm-objcopy][WebAssembly] Add dump/add/remove-section support

Add support for adding, removing, and dumping wasm sections to objcopy

Differential Revision: https://reviews.llvm.org/D70970
The file was addedllvm/test/tools/llvm-objcopy/wasm/dump-section.test
The file was addedllvm/test/tools/llvm-objcopy/wasm/remove-section.test
The file was modifiedllvm/utils/gn/secondary/llvm/tools/llvm-objcopy/BUILD.gn
The file was addedllvm/test/tools/llvm-objcopy/wasm/add-section.test
The file was modifiedllvm/tools/llvm-objcopy/wasm/Object.h
The file was addedllvm/tools/llvm-objcopy/wasm/Object.cpp
The file was modifiedllvm/tools/llvm-objcopy/CMakeLists.txt
The file was modifiedllvm/tools/llvm-objcopy/wasm/WasmObjcopy.cpp
Commit 86f9117d476bcef2f5e0eabae4781e99877ce7b5 by arsenm2
AMDGPU: Don't report 2-byte alignment as fast

This is apparently worse than 1-byte alignment. This does not attempt
to decompose 2-byte aligned wide stores, but will stop trying to
produce them.

Also fix bug in LoadStoreVectorizer which was decreasing the alignment
and vectorizing stack accesses. It was assuming a stack object was an
alloca that could have its base alignment changed, which is not true
if the pointer is derived from a function argument.
The file was addedllvm/test/CodeGen/AMDGPU/fast-unaligned-load-store.private.ll
The file was modifiedllvm/test/Transforms/LoadStoreVectorizer/AMDGPU/merge-stores-private.ll
The file was modifiedllvm/lib/Target/AMDGPU/SIISelLowering.cpp
The file was modifiedllvm/lib/Transforms/Vectorize/LoadStoreVectorizer.cpp
The file was modifiedllvm/test/CodeGen/AMDGPU/chain-hi-to-lo.ll
The file was modifiedllvm/test/Transforms/LoadStoreVectorizer/AMDGPU/adjust-alloca-alignment.ll
The file was modifiedllvm/test/Transforms/LoadStoreVectorizer/AMDGPU/merge-stores.ll
The file was addedllvm/test/CodeGen/AMDGPU/fast-unaligned-load-store.global.ll
The file was modifiedllvm/test/CodeGen/AMDGPU/unaligned-load-store.ll
Commit 2d3ecade3892fb0d0713350e06522a94734733b7 by Jonas Devlieghere
[lldb/Plugins] Move PlatformRemoteiOS into PlatformMacOSX (NFCI)

Move the logic for initialization and termination for PlatformRemoteiOS
into PlatformMacOSX, like we did for the other Darwin platforms in
a731c6ba94d0464c6a122de1af70ab88ffb5c1a6.
The file was modifiedlldb/source/API/SystemInitializerFull.cpp
The file was modifiedlldb/tools/lldb-test/SystemInitializerTest.cpp
The file was modifiedlldb/source/Plugins/Platform/MacOSX/PlatformMacOSX.cpp
Commit a349c09162a8260bdf691c4f7ab72a16c33975f6 by rnk
Fix MSVC build with C++ EH enabled

Mark the CrashRecoveryContextImpl constructor noexcept, so that MSVC
won't emit an unwind helper to clean up the allocation from `new` if the
constructor throws an exception.

Otherwise, MSVC complains:
  llvm\lib\Support\CrashRecoveryContext.cpp(220): error C2712: \
  Cannot use __try in functions that require object unwinding

The other simple fix would be to wrap `new` in a static helper or
lambda.

Users have reported that Tensorflow builds LLVM with /EHsc.
The file was modifiedllvm/lib/Support/CrashRecoveryContext.cpp
Commit b30e1223334b3fb4246acfe0a476a836d788c623 by arsenm2
AMDGPU: Don't expand more special div cases in IR

These have nicer expansions implemented in the DAG. Ideally we would
either directly implement all of these special expansions, or stop
expanding division in the IR.
The file was modifiedllvm/lib/Target/AMDGPU/AMDGPUCodeGenPrepare.cpp
The file was modifiedllvm/test/CodeGen/AMDGPU/amdgpu-codegenprepare-idiv.ll
Commit f9fdd1172c8b326126463f1efcfee721e5222334 by Jason Molenda
Rewrite default "could not attach" msg to point to hints
about where more information can be found about why it
may have failed.
<rdar://problem/59277928>
The file was modifiedlldb/tools/debugserver/source/RNBRemote.cpp
Commit f9219e644ac601ed00487bd6cb285503df5589dd by gkistanova
Reverted the remainings of c1c9819ef91aab51b5a23fb3027adac5a2f551cc
as it has left broken llvm-clang-lld-x86_64-scei-ps4-ubuntu-fast buildbot for long time.

Differential Revision: https://reviews.llvm.org/D73840
The file was modifiedllvm/tools/bugpoint-passes/CMakeLists.txt
The file was modifiedllvm/examples/Bye/CMakeLists.txt
Commit 413307d4560441b47261ced5db5f8e29c8811277 by Jonas Devlieghere
[lldb/Plugins] Rename OSPython plugin to OperatingSystemPython (NFC)

Rename the plugin to match both the directory structure and the class.
The file was modifiedlldb/source/Plugins/OperatingSystem/Python/CMakeLists.txt