Changes

Summary

  1. [mlir] Expose region utils functions (details)
  2. [clang-tidy] fix debug-only test failure (details)
  3. [flang] Fix printing of constc and parsing of  #fir.real (details)
  4. [clang-tidy] Fix false positive in readability-identifier-naming check involving override attribute (details)
Commit 78d69182b7eb70e61711c805cb1956e462a29000 by clementval
[mlir] Expose region utils functions

As discussed in D109579, this patch exposes `runRegionDCE` and
`eraseUnreachableBlocks` so they can be used as separate utilities in
other passes.

Reviewed By: rriddle, mehdi_amini

Differential Revision: https://reviews.llvm.org/D114160
The file was modifiedmlir/lib/Transforms/Utils/RegionUtils.cpp
The file was modifiedmlir/include/mlir/Transforms/RegionUtils.h
Commit 85e03cb7ebac50a13a9a9ac92a0b184a3bba9be1 by kbobyrev
[clang-tidy] fix debug-only test failure

The clang-tidy/infrastructure/pr37091.cpp test inherits the top-level .clang-tidy configuration because it doesn't specify its own checks. It'd be a more stable test if it operates independently of the top-level .clang-tidy settings.

I've made the clang-tidy/infrastructure/pr37091.cpp test independent of the top-level .clang-tidy (picked an arbitrary check that I saw another clang-tidy/infrastructure test was also using: clang-tidy/infrastructure/temporaries.cpp)

Reviewed By: kbobyrev

Differential Revision: https://reviews.llvm.org/D114034
The file was modifiedclang-tools-extra/test/clang-tidy/infrastructure/pr37091.cpp
Commit ca3795541f49d96371f75a307363baef59478786 by diana.picus
[flang] Fix printing of constc and parsing of  #fir.real

Printing and parsing of constc didn't agree with each other. This patch
treats the parsing of constc as the final word and fixes the printing
accordingly.

More concretely, this patch prints the RealAttrs that make up the
ConstcOp directly instead of casting to mlir::FloatAttr (which blows
up). It also fixes parseFirRealAttr to invoke APFloat's method for
getting the size of a floating point type instead of computing it as
8 * kind (which blows up for BFloat, with kind == 3 and size == 16).

Kudos to Kiran Chandramohan <kiran.chandramohan@arm.com> for noticing
that we were missing tests for constc in fir-ops.fir.

Differential Revision: https://reviews.llvm.org/D114081
The file was modifiedflang/lib/Optimizer/Dialect/FIROps.cpp
The file was modifiedflang/lib/Optimizer/Dialect/FIRAttr.cpp
The file was modifiedflang/test/Fir/fir-ops.fir
Commit 6259016361345e09f0607ef4e037e00bcbe4bd40 by mail
[clang-tidy] Fix false positive in readability-identifier-naming check involving override attribute

Overriding methods should not get a readability-identifier-naming
warning because the issue can only be fixed in the base class; but the
current check for whether a method is overriding does not take the
override attribute into account.

Differential Revision: https://reviews.llvm.org/D113830
The file was modifiedclang-tools-extra/clang-tidy/readability/IdentifierNamingCheck.cpp
The file was modifiedclang-tools-extra/test/clang-tidy/checkers/readability-identifier-naming.cpp