Changes

Summary

  1. [NewGVN][NFC] precommit tests for PR53277 (details)
  2. [llvm] Fix header guards (NFC) (details)
  3. [Commands] Remove redundant member initialization (NFC) (details)
  4. [Object] Remove a redundant return statement (NFC) (details)
  5. [MLIR][Presburger] Clean PresburgerSet identifier interface to match IntegerPolyhedron's interface (details)
  6. [RISCV] Adjust the header comment in RISCVInstrInfoZb.td to better integrate Zbk* extensions. (details)
  7. [X86] LowerFunnelShift - use supportedVectorShiftWithBaseAmnt to check for supported scalar shifts (details)
  8. [clang] Move the definition of ASTDiff (NFC) (details)
  9. [clang] Forward-declare DynTypedNode (NFC) (details)
  10. [clang] Remove unused forward declarations (NFC) (details)
  11. [X86] LowerFunnelShift - always lower vXi8 fshl by constant amounts as unpack(y,x) << zext(z) (details)
  12. [RISCV] Add bitreverse tests to bswap-ctlz-cttz-ctpop.ll. Add Zbb command lines. NFC (details)
  13. [RISCV] Add tests that do a bitreverse before or after a bswap. NFC (details)
  14. [mlir] Ensure a newline at the end of a file (NFC) (details)
  15. [Sema] Fix a bugprone argument comment (NFC) (details)
  16. [Analysis] Remove a redundant const from a return type (NFC) (details)
  17. DebugInfo: Don't put types in type units if they reference internal linkage types (details)
  18. [X86] Add some basic tests for PR46809 (details)
  19. DebugInfo: Include template parameters for simplified template decls in type units (details)
  20. [C++20] [Module] fix bug 47716 and implement [module.interface]/p6 (details)
  21. [RISCV][NFC] Remove tailing whitespaces in RISCVInstrInfoVSDPatterns.td and RISCVInstrInfoVVLPatterns.td (details)
  22. [NFC] [Coroutines] Rename tests in coro-align (details)
Commit 1a5dea9e2b97a74a277e82bfe010d521f1690eea by nuno.lopes
[NewGVN][NFC] precommit tests for PR53277
The file was addedllvm/test/Transforms/NewGVN/phi-of-ops-loads.ll
Commit 7a29b0b58383e8ceb751144fe638c46cacc6fe40 by kazu
[llvm] Fix header guards (NFC)

Identified with llvm-header-guard.
The file was modifiedllvm/include/llvm/Demangle/StringView.h
The file was modifiedllvm/include/llvm/Analysis/NoInferenceModelRunner.h
The file was modifiedllvm/include/llvm/Analysis/ReleaseModeModelRunner.h
The file was modifiedllvm/include/llvm/ProfileData/MemProfData.inc
The file was modifiedllvm/include/llvm/Demangle/Utility.h
The file was modifiedllvm/include/llvm/Demangle/ItaniumDemangle.h
Commit abb0ed44957cb4ba1bc94d19202860f10369cea1 by kazu
[Commands] Remove redundant member initialization (NFC)

Identified with readability-redundant-member-init.
The file was modifiedlldb/source/Commands/CommandObjectDisassemble.cpp
The file was modifiedlldb/source/Commands/CommandObjectTrace.cpp
The file was modifiedlldb/source/Commands/CommandCompletions.cpp
The file was modifiedlldb/source/Commands/CommandObjectBreakpoint.cpp
The file was modifiedlldb/source/Commands/CommandObjectPlatform.cpp
The file was modifiedlldb/source/Commands/CommandObjectLog.cpp
The file was modifiedlldb/source/Commands/CommandObjectWatchpointCommand.cpp
The file was modifiedlldb/source/Commands/CommandObjectSettings.cpp
The file was modifiedlldb/source/Commands/CommandObjectStats.cpp
The file was modifiedlldb/source/Commands/CommandObjectCommands.cpp
The file was modifiedlldb/source/Commands/CommandObjectTarget.cpp
The file was modifiedlldb/source/Commands/CommandObjectBreakpointCommand.cpp
The file was modifiedlldb/source/Commands/CommandObjectExpression.cpp
The file was modifiedlldb/source/Commands/CommandObjectThread.cpp
The file was modifiedlldb/source/Commands/CommandObjectFrame.cpp
The file was modifiedlldb/source/Commands/CommandObjectRegister.cpp
The file was modifiedlldb/source/Commands/CommandOptionsProcessLaunch.h
The file was modifiedlldb/source/Commands/CommandObjectHelp.cpp
The file was modifiedlldb/source/Commands/CommandObjectScript.h
The file was modifiedlldb/source/Commands/CommandObjectMemoryTag.cpp
The file was modifiedlldb/source/Commands/CommandObjectMemory.cpp
The file was modifiedlldb/source/Commands/CommandObjectSource.cpp
The file was modifiedlldb/source/Commands/CommandObjectType.cpp
The file was modifiedlldb/source/Commands/CommandObjectRegexCommand.cpp
The file was modifiedlldb/source/Commands/CommandObjectReproducer.cpp
The file was modifiedlldb/source/Commands/CommandObjectProcess.cpp
The file was modifiedlldb/source/Commands/CommandObjectWatchpoint.cpp
The file was modifiedlldb/source/Commands/CommandObjectHelp.h
The file was modifiedlldb/source/Commands/CommandObjectSession.cpp
Commit f8ddcb4131256fcb1777cba617d3c5277024f9ec by kazu
[Object] Remove a redundant return statement (NFC)

Identified with readability-redundant-control-flow.
The file was modifiedllvm/lib/Object/Archive.cpp
Commit ad36f37ce2b4ab6b1aadf318456fb2b8bb141d71 by groverkss
[MLIR][Presburger] Clean PresburgerSet identifier interface to match IntegerPolyhedron's interface

This patch changes names of identifiers and their corresponding getters in
PresburgerSet to match those of IntegerPolyhedron.

Reviewed By: arjunp

Differential Revision: https://reviews.llvm.org/D117998
The file was modifiedmlir/include/mlir/Analysis/Presburger/PresburgerSet.h
The file was modifiedmlir/lib/Analysis/Presburger/PresburgerSet.cpp
Commit 413684313d9dd7c83ab0c40830cccbd31a94bd7c by craig.topper
[RISCV] Adjust the header comment in RISCVInstrInfoZb.td to better integrate Zbk* extensions.

The Zbk* extensions have some overlap with Zb so have been placed in this file.

Reviewed By: VincentWu

Differential Revision: https://reviews.llvm.org/D117958
The file was modifiedllvm/lib/Target/RISCV/RISCVInstrInfoZb.td
Commit 32dc14f876c4b196dccb5b8db56510e401fa91ab by llvm-dev
[X86] LowerFunnelShift - use supportedVectorShiftWithBaseAmnt to check for supported scalar shifts

Allows us to reuse the ISD shift opcode instead of a mixture of ISD/X86ISD variants
The file was modifiedllvm/lib/Target/X86/X86ISelLowering.cpp
Commit ab1add6adc444371268ddbcb169a509559abd9dc by kazu
[clang] Move the definition of ASTDiff (NFC)

This patch moves the definition of ASTDiff later within the header
file.

Without this patch, the header depends on the forward decalrations of
SyntaxTree and ComparisonOptions from another header file, which is
not desirable.  Since SyntaxTree and ComparisonOptions are defined in
ASTDiff.h, we can move the definition of ASTDiff later and stop
relying on the forward declarations from another header file.
The file was modifiedclang/include/clang/Tooling/ASTDiff/ASTDiff.h
Commit ee591a64a795995fad96d8c16484baa7cacce99f by kazu
[clang] Forward-declare DynTypedNode (NFC)

This patch adds a forward declaraiton of DynTypedNode.

DumpAST.h is relying on the forward declaration of DynTypedNode in
ASTContext.h, which is undesirable.
The file was modifiedclang-tools-extra/clangd/DumpAST.h
Commit e59964b67e026cde7a1438a8e91ca077a90810e0 by kazu
[clang] Remove unused forward declarations (NFC)
The file was modifiedclang/include/clang/AST/ASTContext.h
The file was modifiedclang/include/clang/Tooling/ASTDiff/ASTDiffInternal.h
Commit 4762c077e7102326306c7788494e3ea16e0f4cec by llvm-dev
[X86] LowerFunnelShift - always lower vXi8 fshl by constant amounts as unpack(y,x) << zext(z)

This can always be lowered as PMULLW+PSRLWI+PACKUSWB
The file was modifiedllvm/lib/Target/X86/X86ISelLowering.cpp
The file was modifiedllvm/test/CodeGen/X86/vector-fshl-512.ll
The file was modifiedllvm/test/CodeGen/X86/vector-fshl-128.ll
The file was modifiedllvm/test/CodeGen/X86/vector-fshl-256.ll
Commit 88f33cff4bee87ea31e129f734df232274098a78 by craig.topper
[RISCV] Add bitreverse tests to bswap-ctlz-cttz-ctpop.ll. Add Zbb command lines. NFC

Rename to include bitreverse. Add additional tests and Zbb command lines.

There's some overlapping tests with rv32zbb.ll and rv64zbb.ll. Maybe
I'll clean that up in a future patch.
The file was removedllvm/test/CodeGen/RISCV/bswap-ctlz-cttz-ctpop.ll
The file was addedllvm/test/CodeGen/RISCV/bswap-bitreverse-ctlz-cttz-ctpop.ll
Commit 3575700b286f8c3150abb3de7968a9f36dd1cceb by craig.topper
[RISCV] Add tests that do a bitreverse before or after a bswap. NFC

We don't optimize this as well as we could. Bitreverse is always
expanded to bswap and a shift/and/or sequence to swap bits within a
byte. The newly created bswap will either becomes a shift/and/or
sequence or rev8 instruction. We don't always realize the bswap is
redundant with another bswap before or after the bitreverse.

Found while thinking about the brev8 instruction from the
Cryptography extension. It's equivalent to bswap(bitreverse(x)) or
bitreverse(bswap(x)).
The file was modifiedllvm/test/CodeGen/RISCV/bswap-bitreverse-ctlz-cttz-ctpop.ll
Commit 47d7e922d8438c801198a2901a01fcd2cfbdb353 by kazu
[mlir] Ensure a newline at the end of a file (NFC)
The file was modifiedmlir/lib/CMakeLists.txt
Commit fa90fc6e0566a245cafa0afa4da4967cf4831779 by kazu
[Sema] Fix a bugprone argument comment (NFC)

Identified with bugprone-argument-comment.
The file was modifiedclang/lib/Sema/SemaTemplateDeduction.cpp
Commit 448d0dfab701ab00d081136d8373304fd91693a0 by kazu
[Analysis] Remove a redundant const from a return type (NFC)

Identified with readability-const-return-type.
The file was modifiedllvm/lib/Analysis/ScalarEvolution.cpp
Commit ab4756338c5b2216d52d9152b2f7e65f233c4dac by dblaikie
DebugInfo: Don't put types in type units if they reference internal linkage types

Doing this causes a declaration of the internal linkage (anonymous
namespace) type to be emitted in the type unit, which would then be
ambiguous as to which internal linkage definition it refers to (since
the name is only valid internally).

It's possible these internal linkage types could be resolved relative to
the unit the TU is referred to from - but that doesn't seem ideal, and
there's no reason to put the type in a type unit since it can only be
defined in one CU anyway (since otherwise it'd be an ODR violation) & so
avoiding the type unit should be a smaller DWARF encoding anyway.

This also addresses an issue with Simplified Template Names where the
template parameter could not be rebuilt from the declaration emitted
into the TU (specifically for an enum non-type template parameter, where
looking up the enumerators is necessary to rebuild the full template
name)
The file was modifiedllvm/lib/CodeGen/AsmPrinter/DwarfDebug.h
The file was modifiedllvm/lib/CodeGen/AsmPrinter/DwarfUnit.cpp
The file was modifiedllvm/lib/CodeGen/AsmPrinter/DwarfDebug.cpp
The file was modifiedllvm/test/DebugInfo/X86/tu-to-non-tu.ll
Commit 7c77df1528c8ef6ab430bca18661aaf578066b96 by llvm-dev
[X86] Add some basic tests for PR46809
The file was addedllvm/test/CodeGen/X86/select-lea.ll
Commit 2e58a18910867ba6795066e044293e6daf89edf5 by dblaikie
DebugInfo: Include template parameters for simplified template decls in type units

LLVM DebugInfo CodeGen synthesizes type declarations in type units when
referencing types that are not in type units. When those synthesized
types are templates and simplified template names (or mangled simplified
template names) are in use, the template arguments must be attached to
those declarations.

A deeper fix (with a CU or DICompositeType flag) that would also support
other uses of clang's -debug-forward-template-args (such as Sony's
platform) could/should be implemented to fix this more broadly.
The file was modifiedllvm/lib/CodeGen/AsmPrinter/DwarfUnit.cpp
The file was modifiedllvm/test/DebugInfo/X86/tu-to-non-tu.ll
Commit 3a3af2bbc97e7db045eccb8683e93b9aa7ef562b by yedeng.yd
[C++20] [Module] fix bug 47716 and implement [module.interface]/p6

This fixes bug 47716.

According to [module.interface]p2, it is meaningless to export an entity
which is not in namespace scope.
The reason why the compiler crashes is that the compiler missed
ExportDecl when the compiler traverse the subclass of DeclContext. So
here is the crash.

Also, the patch implements [module.interface]p6 in
Sema::CheckRedeclaration* functions.

Reviewed By: aaron.ballman, urnathan

Differential Revision: https://reviews.llvm.org/D112903
The file was modifiedclang/lib/Sema/SemaDeclCXX.cpp
The file was addedclang/test/CXX/module/module.interface/p2-2.cpp
The file was modifiedclang/lib/AST/DeclBase.cpp
The file was modifiedclang/lib/Sema/SemaDecl.cpp
The file was modifiedclang/include/clang/Sema/Sema.h
The file was modifiedclang/include/clang/Basic/DiagnosticSemaKinds.td
The file was addedclang/test/CXX/module/module.interface/p6.cpp
The file was modifiedclang/include/clang/AST/DeclBase.h
The file was modifiedclang/lib/Sema/SemaTemplate.cpp
Commit 3f24cdec2572741f018457d5f24ef479e1291f1c by jim
[RISCV][NFC] Remove tailing whitespaces in RISCVInstrInfoVSDPatterns.td and RISCVInstrInfoVVLPatterns.td
The file was modifiedllvm/lib/Target/RISCV/RISCVInstrInfoVSDPatterns.td
The file was modifiedllvm/lib/Target/RISCV/RISCVInstrInfoVVLPatterns.td
Commit b574048239bc6fbd9dd356fbaa8bd475fa4b64e6 by yedeng.yd
[NFC] [Coroutines] Rename tests in coro-align

This is required by ychen. See https://reviews.llvm.org/D117542
The file was removedllvm/test/Transforms/Coroutines/coro-align-01.ll
The file was addedllvm/test/Transforms/Coroutines/coro-align64-02.ll
The file was addedllvm/test/Transforms/Coroutines/coro-align8.ll
The file was removedllvm/test/Transforms/Coroutines/coro-align-02.ll
The file was addedllvm/test/Transforms/Coroutines/coro-align16.ll
The file was removedllvm/test/Transforms/Coroutines/coro-align-04.ll
The file was removedllvm/test/Transforms/Coroutines/coro-align-03.ll
The file was removedllvm/test/Transforms/Coroutines/coro-align-05.ll
The file was addedllvm/test/Transforms/Coroutines/coro-align32.ll
The file was addedllvm/test/Transforms/Coroutines/coro-align64.ll
The file was addedllvm/test/Transforms/Coroutines/coro-align8-02.ll