Changes

[mlir] LLVM import: handle function-typed constants
The current implementation of the LLVM-to-MLIR translation could not
handle functions used as constant values in instructions. The handling
is added trivially as `llvm.mlir.constant` can define constants of
function type using SymbolRef attributes, which works even for functions
that have not been declared yet.

[FPEnv] Address post-commit review comment for D71467
Remove a bit of code duplication between CreateFCmp and CreateFCmpS by
creating a shared helper function.

[clangd] Show hower info for expressions
Summary: This currently populates only the Name with the expression's
type and Value if expression is evaluatable.
Fixes https://github.com/clangd/clangd/issues/56
Reviewers: sammccall
Subscribers: ilya-biryukov, MaskRay, jkorous, arphaman, usaxena95,
cfe-commits
Tags: #clang
Differential Revision: https://reviews.llvm.org/D72500

[ELF] Avoid false-positive assert in getErrPlace()
This assertion was added as part of D70659 but did not account for .bss 
input sections. I noticed that this assert was incorrectly triggering 
while building FreeBSD for MIPS64. Fixed by relaxing the assert to also 
account for SHT_NOBITS input sections and adjust the test 
mips-jalr-non-function.s to link a file with a .bss section first.
Reviewed By: MaskRay, grimar Differential Revision:
https://reviews.llvm.org/D72567

[mlir][EDSC] Refactor dependencies involving EDSCs.
Summary: This diff removes the dependency of LinalgOps and VectorOps on
EDSCs.
Reviewers: jpienaar, ftynse
Reviewed By: ftynse
Subscribers: merge_guards_bot, mgorny, mehdi_amini, rriddle, burmako,
shauheen, antiagainst, csigg, arpith-jacob, mgester, lucyrfox, herhut,
llvm-commits
Tags: #llvm
Differential Revision: https://reviews.llvm.org/D72481

[gn build] (manually) port b4a99a061f51 better

[clangd] Add a ruler after header in hover
Reviewers: sammccall
Subscribers: ilya-biryukov, MaskRay, jkorous, arphaman, usaxena95,
cfe-commits
Tags: #clang
Differential Revision: https://reviews.llvm.org/D72622

[clangd] Rearrange type, returntype and parameters in hover card
Summary: Moves type/returntype into its own line as it is more readable
in cases where the type is long.
Also gives parameter lists a heading, `Parameters:` to make them stand
out.
Leaves the `right arrow` instead of `Returns: ` before Return Type to
make output more symmetric.
``` function foo
Returns: ret_type Parameters:
- int x
```
vs
``` function foo
🡺 ret_type Parameters:
- int x
```
Reviewers: sammccall, ilya-biryukov
Subscribers: MaskRay, jkorous, arphaman, usaxena95, cfe-commits
Tags: #clang
Differential Revision: https://reviews.llvm.org/D72623

[clang] New __attribute__((__clang_arm_mve_strict_polymorphism)).
This is applied to the vector types defined in <arm_mve.h> for use with
the intrinsics for the ARM MVE vector architecture.
Its purpose is to inhibit lax vector conversions, but only in the 
context of overload resolution of the MVE polymorphic intrinsic 
functions. This solves an ambiguity problem with polymorphic MVE 
intrinsics that take a vector and a scalar argument: the scalar argument
can often have the wrong integer type due to default integer promotions
or unsuffixed literals, and therefore, the type of the vector argument
should be considered trustworthy when resolving MVE polymorphism.
As part of the same change, I've added the new attribute to the 
declarations generated by the MveEmitter Tablegen backend (and corrected
a namespace issue with the other attribute while I was there).
Reviewers: aaron.ballman, dmgreen
Reviewed By: aaron.ballman
Subscribers: kristof.beyls, JDevlieghere, cfe-commits
Tags: #clang
Differential Revision: https://reviews.llvm.org/D72518

[gn build] find mistakes like the one fixed in 72b5989e0d1 at build time

[clangd] Fix windows buildbots

Restore "[ThinLTO] Add additional ThinLTO pipeline testing with new PM"
This restores 2af97be8027a0823b88d4b6a07fc5eedb440bc1f (reverted at 
6288f86e870c7bb7fe47cc138320b9eb34c93941), with all the fixes I had 
applied at the time, along with a new fix for non-determinism in the 
ordering of a couple of passes due to being accessed as parameters on 
the same call.
I've also added --dump-input=fail to the new tests so I can more 
thoroughly fix any additional failures.

[llvm-readobj][test] - Cleanup SHT_RELR sections testing.
After recent changes (D71872) in yaml2obj, it is possible so cleanup 
testing of the SHT_RELR sections.
Differential revision: https://reviews.llvm.org/D71874

[mlir][Linalg] NFC - Hotfix for gcc-5 build

[CMake] Enable -qfuncsect when building with IBM XL
Summary: The IBM XL compiler uses `-qfuncsect` for
`-ffunction-sections`.
The comment about sanitizers and `-f[no-]function-sections` is corrected 
also, as it is pertinent to this patch.
The sanitizer-related use of `-fno-function-sections` is associated with 
powerpc64le, a target for which there is an IBM XL compiler, so that use 
is updated in this patch to apply `-qnofuncsect` in case a build using 
the XL compiler is viable on that platform.
This patch has been verified with the XL compiler on AIX only.
Reviewers: daltenty, stevewan
Reviewed By: daltenty
Subscribers: mgorny, steven.zhang, #sanitizers, llvm-commits
Tags: #sanitizers, #llvm
Differential Revision: https://reviews.llvm.org/D72335

DWARFDebugLine.cpp: Format unknown line number standard opcodes
Summary: This patch implements `formatv()` formatting for
`dwarf::LineNumberOps` and makes use of it for the `llvm-dwarfdump
--debug-line` dump.
Previously, unknown line number standard opcodes would lead to undefined 
behaviour. The code would attempt to format the data pointer of an empty
`StringRef` (a null pointer) using `%s`. According to the description 
for `format()`, use of that interface carries the "risk of `printf`". 
Passing a null pointer in place of an array to a C library function 
results in undefined behaviour.
Reviewers: jhenderson, daltenty, stevewan
Reviewed By: jhenderson
Subscribers: aprantl, hiraditya, llvm-commits
Tags: #llvm
Differential Revision: https://reviews.llvm.org/D72369

[ORC] Update lazyReexports to support aliases with different symbol
names.
A bug in the existing implementation meant that lazyReexports would not
work if the aliased name differed from the alias's name, i.e. all lazy
reexports had to be of the form (lib1, name) -> (lib2, name). This patch
fixes the issue by capturing the alias's name in the NotifyResolved
callback. To simplify this capture, and the LazyCallThroughManager code
in general, the NotifyResolved callback is updated to use
llvm::unique_function rather than a custom class.
No test case yet: This can only be tested at runtime, and the only
in-tree client (lli) always uses aliases with matching names. I will add
a new LLJIT example shortly that will directly test the lazyReexports
API and the non-trivial alias use case.

[ORC] Simplify use of lazyReexports with LLJIT.
This patch makes the target triple available via the LLJIT interface,
and moves the IRTransformLayer from LLLazyJIT down into LLJIT. Together
these changes make it easier to use the lazyReexports utility with
LLJIT, and to apply IR transforms to code as it is compiled in LLJIT
(rather than requiring transforms to be applied manually before code is
added). An code example is added in 
llvm/examples/LLJITExamples/LLJITWithLazyReexports

[mlir][Linalg] NFC - Cleanup Linalg Pass locations and namespacing
Summary: This diff moves the conversion pass declaration closer to its
definition and makes the namespacing of passes consistent with the rest
of the infrastructure (i.e. `mlir::linalg::createXXXPass` ->
`mlir::createXXXPass`).
Reviewers: ftynse, jpienaar, mehdi_amini
Subscribers: rriddle, burmako, shauheen, antiagainst, arpith-jacob,
mgester, lucyrfox, aartbik, liufengdb, llvm-commits
Tags: #llvm
Differential Revision: https://reviews.llvm.org/D72766

[mlir][Linalg] NFC - Hotfix for gcc-5 build

[InstCombine] reassociate fsub+fsub into fsub+fadd
As discussed in the motivating PR44509: 
https://bugs.llvm.org/show_bug.cgi?id=44509
...we can end up with worse code using fast-math than without. This is
because the reassociate pass greedily transforms fsub into fneg/fadd and
apparently (based on the regression tests seen here) expects instcombine
to clean that up if it wasn't profitable. But we were missing this fold:
(X - Y) - Z --> X - (Y + Z)
There's another, more specific case that I think we should handle as
shown in the "fake" fneg test (but missed with a real fneg), but that's
another patch. That may be tricky to get right without conflicting with
existing transforms for fneg.
Differential Revision: https://reviews.llvm.org/D72521

[Loop Peeling] Add possibility to enable peeling on loop nests.
Summary: Current peeling implementation bails out in case of loop nests. 
The patch introduces a field in TargetTransformInfo structure that 
certain targets can use to relax the constraints if it's profitable
(disabled by default). Also additional option is added to enable peeling
manually for experimenting and testing purposes.
Reviewers: fhahn, lebedev.ri, xbolva00
Reviewed By: xbolva00
Subscribers: xbolva00, hiraditya, zzheng, llvm-commits
Differential Revision: https://reviews.llvm.org/D70304

[ThinLTO] Always import constants
This patch imports constant variables even when they can't be
internalized
(which results in promotion). This offers some extra constant folding 
opportunities.
Differential revision: https://reviews.llvm.org/D70404

Fix bot by adjusting wildcard matching
I noticed one bot failure due to 
24a00ef2404104e9ca6fbd7eb523a8a340be9d99 because the wildcard matching 
was not working as intended, fixed it to act similar to other checks of 
CGSCCToFunctionPassAdaptor.

Revert "[mlir] Create a gpu.module operation for the GPU Dialect."
This reverts commit 4624a1e8ac8a3f69cc887403b976f538f587744a. Causing 
problems downstream.

[clangd] Extract string literals in macro arguments to unbreak gcc
buildbots

[ARM][MVE][Intrinsics] Add VMINAQ, VMINNMAQ, VMAXAQ, VMAXNMAQ
intrinsics.
Summary: Add VMINAQ, VMINNMAQ, VMAXAQ, VMAXNMAQ intrinsics and unit
tests.
Reviewers: simon_tatham, miyuki, dmgreen
Subscribers: kristof.beyls, hiraditya, cfe-commits, llvm-commits
Tags: #clang, #llvm
Differential Revision: https://reviews.llvm.org/D72761

Replace CLANG_SPAWN_CC1 env var with a driver mode flag
Flags are clang's default UI is flags.
We can have an env var in addition to that, but in D69825 nobody has yet 
mentioned why this needs an env var, so omit it for now.  If someone 
needs to set the flag via env var, the existing CCC_OVERRIDE_OPTIONS 
mechanism works for it (set CCC_OVERRIDE_OPTIONS=+-fno-integrated-cc1 
for example).
Also mention the cc1-in-process change in the release notes.
Also spruce up the test a bit so it actually tests something :)
Differential Revision: https://reviews.llvm.org/D72769

[gn build] Reformat all build files
Ran `git ls-files '*.gn' '*.gni' | xargs llvm/utils/gn/gn.py format`. 
The motivation is to reformat them with trunk gn again right after. 
Trunk gn changed formatting of some single-element lists.

Revert "Revert rG6078f2fedcac5797ac39ee5ef3fd7a35ef1202d5 -
"[AArch64][GlobalISel]: Support @llvm.{return,frame}address selection.""
The original change wasn't constraining the operand regclasses which
broke EXPENSIVE_CHECKS.

[ORC] Set setCloneToNewContextOnEmit on LLJIT's transform layer when
needed.
Based on Don Hinton's patch in https://reviews.llvm.org/D72406. This
feature was accidentally left out of
e9e26c01cd865da678b1af6ba5f417c713956a66, and would have pessimized
concurrent compilation in the default case.
Thanks for spotting this Don!

[Mips] Add FileCheck to a test that just tested for a crash.
I believe the generated code here can suffer from double rounding. So I
wanted to capture the existing codegen so we can make decisions about
how to fix it.

[gn build] make "gn format" comment slightly more concise

[gn build] add multi-line forcing comments in more places

[gn build] re-run "gn format" with trunk gn

[docs][ORC] Update the laziness section of the ORCv2 design doc.
This updates the discussion of lazy reexports, fixes a TBD for a usage
example, and adds a reference to the fully worked lazy reexports example
that was added in e9e26c01cd865da678b1af6ba5f417c713956a66.