SuccessChanges

Summary

  1. [InstCombine] avoid infinite loop in demanded bits for select (details)
  2. AMDGPU/GlobalISel: Add subtarget to a test (details)
  3. [lldb/Interpreter][NFC] Remove more deleted const char* overloads (details)
  4. [lldb/Interpreter][NFC] Replace default constructors/destructors bodies with "=default" (details)
  5. [lldb/Interpreter][NFC] Remove explicit default initialization of members and base classes (details)
  6. [lldb][NFC] Make OptionValueArgs::GetArgs constant (details)
  7. [lldb] OptionValueProperties::Get[Set]PropertyAtIndexAsArgs should handle OptionValueArgs (details)
  8. [lldb/Interpreter] Fix deep copying for OptionValue classes (details)
  9. [lldb/Target] Remove outdated code (details)
  10. [DAGCombiner] Don't skip no overflow check on UMULO if the first computeKnownBits call doesn't return any 0 bits. (details)
Commit 9502061bcc86982641772f45b7e7a0eb7437f054 by spatel
[InstCombine] avoid infinite loop in demanded bits for select

https://llvm.org/PR49205
The file was modifiedllvm/lib/Transforms/InstCombine/InstCombineSimplifyDemanded.cpp
The file was modifiedllvm/test/Transforms/InstCombine/select-imm-canon.ll
Commit 25e60f645ac8bf09e00bfff95c9d20d63616d687 by Matthew.Arsenault
AMDGPU/GlobalISel: Add subtarget to a test

SelectionDAG forces us to have a weird ABI for 16-bit values without
legal 16-bit operations, but currently GlobalISel bypasses this and
sometimes ends up using the gfx8+ ABI in some contexts. Make sure
we're testing the normal ABI to avoid a test change in a future patch.
The file was modifiedllvm/test/CodeGen/AMDGPU/GlobalISel/function-returns.ll
Commit 9182117861896a03499bbca3612fc66ca4d36944 by Tatyana Krasnukha
[lldb/Interpreter][NFC] Remove more deleted const char* overloads

A follow-up commit to D96861.
The file was modifiedlldb/include/lldb/Interpreter/OptionGroupUInt64.h
The file was modifiedlldb/include/lldb/Interpreter/OptionValueUInt64.h
The file was modifiedlldb/include/lldb/Interpreter/OptionGroupUUID.h
The file was modifiedlldb/include/lldb/Interpreter/OptionGroupWatchpoint.h
The file was modifiedlldb/include/lldb/Interpreter/OptionGroupFile.h
The file was modifiedlldb/include/lldb/Interpreter/OptionGroupValueObjectDisplay.h
The file was modifiedlldb/include/lldb/Interpreter/OptionGroupVariable.h
The file was modifiedlldb/include/lldb/Interpreter/OptionGroupBoolean.h
The file was modifiedlldb/include/lldb/Interpreter/OptionGroupPythonClassWithDict.h
The file was modifiedlldb/include/lldb/Interpreter/OptionValueString.h
The file was modifiedlldb/include/lldb/Interpreter/OptionGroupString.h
Commit 54d03a4985bc9a0a84c4dff835ec6ed0f607582f by Tatyana Krasnukha
[lldb/Interpreter][NFC] Replace default constructors/destructors bodies with "=default"
The file was modifiedlldb/source/Interpreter/OptionGroupPythonClassWithDict.cpp
The file was modifiedlldb/include/lldb/Interpreter/ScriptInterpreter.h
The file was modifiedlldb/source/Interpreter/OptionGroupArchitecture.cpp
The file was modifiedlldb/include/lldb/Interpreter/OptionGroupVariable.h
The file was modifiedlldb/include/lldb/Interpreter/OptionValueArch.h
The file was modifiedlldb/include/lldb/Interpreter/OptionValueDictionary.h
The file was modifiedlldb/include/lldb/Interpreter/OptionValueFormatEntity.h
The file was modifiedlldb/include/lldb/Interpreter/OptionValueLanguage.h
The file was modifiedlldb/include/lldb/Interpreter/OptionValueFileColonLine.h
The file was modifiedlldb/source/Interpreter/OptionGroupUInt64.cpp
The file was modifiedlldb/include/lldb/Interpreter/OptionValueString.h
The file was modifiedlldb/source/Interpreter/OptionGroupFile.cpp
The file was modifiedlldb/include/lldb/Interpreter/OptionValueFileSpec.h
The file was modifiedlldb/include/lldb/Interpreter/OptionGroupArchitecture.h
The file was modifiedlldb/source/Interpreter/CommandHistory.cpp
The file was modifiedlldb/source/Interpreter/OptionGroupOutputFile.cpp
The file was modifiedlldb/source/Interpreter/OptionGroupValueObjectDisplay.cpp
The file was modifiedlldb/include/lldb/Interpreter/OptionValueUUID.h
The file was modifiedlldb/include/lldb/Interpreter/OptionGroupFile.h
The file was modifiedlldb/source/Interpreter/CommandObject.cpp
The file was modifiedlldb/include/lldb/Interpreter/OptionGroupWatchpoint.h
The file was modifiedlldb/include/lldb/Interpreter/OptionGroupPythonClassWithDict.h
The file was modifiedlldb/include/lldb/Interpreter/CommandHistory.h
The file was modifiedlldb/include/lldb/Interpreter/OptionGroupBoolean.h
The file was modifiedlldb/include/lldb/Interpreter/OptionGroupValueObjectDisplay.h
The file was modifiedlldb/source/Interpreter/OptionGroupVariable.cpp
The file was modifiedlldb/include/lldb/Interpreter/OptionValueArgs.h
The file was modifiedlldb/source/Interpreter/Options.cpp
The file was modifiedlldb/include/lldb/Interpreter/OptionGroupString.h
The file was modifiedlldb/source/Interpreter/OptionGroupString.cpp
The file was modifiedlldb/include/lldb/Interpreter/OptionValueChar.h
The file was modifiedlldb/include/lldb/Interpreter/CommandObject.h
The file was modifiedlldb/include/lldb/Interpreter/OptionValueUInt64.h
The file was modifiedlldb/source/Interpreter/CommandReturnObject.cpp
The file was modifiedlldb/include/lldb/Interpreter/OptionGroupUInt64.h
The file was modifiedlldb/source/Interpreter/OptionGroupFormat.cpp
The file was modifiedlldb/include/lldb/Interpreter/OptionValueProperties.h
The file was modifiedlldb/source/Interpreter/ScriptInterpreter.cpp
The file was modifiedlldb/include/lldb/Interpreter/OptionValueBoolean.h
The file was modifiedlldb/source/Interpreter/OptionGroupUUID.cpp
The file was modifiedlldb/include/lldb/Interpreter/OptionValuePathMappings.h
The file was modifiedlldb/include/lldb/Interpreter/OptionValueFileSpecList.h
The file was modifiedlldb/include/lldb/Interpreter/OptionValueFormat.h
The file was modifiedlldb/include/lldb/Interpreter/OptionGroupUUID.h
The file was modifiedlldb/include/lldb/Interpreter/OptionGroupOutputFile.h
The file was modifiedlldb/include/lldb/Interpreter/OptionValueArray.h
The file was modifiedlldb/source/Interpreter/OptionGroupWatchpoint.cpp
The file was modifiedlldb/include/lldb/Interpreter/OptionGroupFormat.h
The file was modifiedlldb/include/lldb/Interpreter/OptionValueEnumeration.h
The file was modifiedlldb/source/Interpreter/OptionValueEnumeration.cpp
The file was modifiedlldb/include/lldb/Interpreter/CommandReturnObject.h
The file was modifiedlldb/include/lldb/Interpreter/OptionValueSInt64.h
The file was modifiedlldb/source/Interpreter/OptionGroupBoolean.cpp
Commit 8cdcd41e384b4901cd796f7be58c461647e54d18 by Tatyana Krasnukha
[lldb/Interpreter][NFC] Remove explicit default initialization of members and base classes

According to clang-tidy's readability-redundant-member-init.
The file was modifiedlldb/include/lldb/Interpreter/OptionValueUInt64.h
The file was modifiedlldb/source/Interpreter/OptionValueFileSpec.cpp
The file was modifiedlldb/include/lldb/Interpreter/OptionValueBoolean.h
The file was modifiedlldb/include/lldb/Interpreter/OptionGroupPlatform.h
The file was modifiedlldb/source/Interpreter/OptionValueProperties.cpp
The file was modifiedlldb/source/Interpreter/OptionGroupPythonClassWithDict.cpp
The file was modifiedlldb/source/Interpreter/OptionGroupVariable.cpp
The file was modifiedlldb/include/lldb/Interpreter/OptionValuePathMappings.h
The file was modifiedlldb/source/Interpreter/Property.cpp
The file was modifiedlldb/include/lldb/Interpreter/OptionValueChar.h
The file was modifiedlldb/include/lldb/Interpreter/OptionValueDictionary.h
The file was modifiedlldb/include/lldb/Interpreter/OptionValueArch.h
The file was modifiedlldb/source/Interpreter/OptionValueFileColonLine.cpp
The file was modifiedlldb/source/Interpreter/CommandAlias.cpp
The file was modifiedlldb/source/Interpreter/CommandObject.cpp
The file was modifiedlldb/include/lldb/Interpreter/OptionValueLanguage.h
The file was modifiedlldb/source/Interpreter/CommandInterpreter.cpp
The file was modifiedlldb/include/lldb/Interpreter/OptionValueFormat.h
The file was modifiedlldb/include/lldb/Interpreter/OptionValueSInt64.h
The file was modifiedlldb/source/Interpreter/OptionGroupFile.cpp
The file was modifiedlldb/source/Interpreter/OptionValueEnumeration.cpp
The file was modifiedlldb/include/lldb/Interpreter/OptionValueFileSpecList.h
The file was modifiedlldb/include/lldb/Interpreter/OptionValueUUID.h
The file was modifiedlldb/source/Interpreter/OptionValueFormatEntity.cpp
The file was modifiedlldb/source/Interpreter/Options.cpp
The file was modifiedlldb/include/lldb/Interpreter/OptionValueRegex.h
The file was modifiedlldb/include/lldb/Interpreter/OptionValueString.h
The file was modifiedlldb/source/Interpreter/OptionGroupOutputFile.cpp
The file was modifiedlldb/include/lldb/Interpreter/Options.h
Commit b2faf30189449a894b5c1cb2bb6b0cc04986c7fe by Tatyana Krasnukha
[lldb][NFC] Make OptionValueArgs::GetArgs constant
The file was modifiedlldb/source/Interpreter/OptionValueArgs.cpp
The file was modifiedlldb/include/lldb/Interpreter/OptionValueArgs.h
Commit ef447fe0088cacc38027028d4c43c1938d3eb9e7 by Tatyana Krasnukha
[lldb] OptionValueProperties::Get[Set]PropertyAtIndexAsArgs should handle OptionValueArgs
The file was modifiedlldb/source/Interpreter/OptionValueProperties.cpp
Commit f0f183ee4ad952d94234cf6971c69a044e05c9df by Tatyana Krasnukha
[lldb/Interpreter] Fix deep copying for OptionValue classes

Some implementations of the DeepCopy function called the copy constructor that copied m_parent member instead of setting a new parent. Others just leaved the base class's members (m_parent, m_callback, m_was_set) empty.
One more problem is that not all classes override this function, e.g. OptionValueArgs::DeepCopy produces OptionValueArray instance, and Target[Process/Thread]ValueProperty::DeepCopy produces OptionValueProperty. This makes downcasting via static_cast invalid.

The patch implements idiom "virtual constructor" to fix these issues.
Add a test that checks DeepCopy for correct copying/setting all data members of the base class.

Differential Revision: https://reviews.llvm.org/D96952
The file was modifiedlldb/source/Interpreter/OptionValueFileSpecList.cpp
The file was modifiedlldb/include/lldb/Interpreter/OptionValueUInt64.h
The file was modifiedlldb/source/Interpreter/OptionValueUInt64.cpp
The file was modifiedlldb/include/lldb/Interpreter/OptionValueDictionary.h
The file was modifiedlldb/source/Target/Thread.cpp
The file was modifiedlldb/include/lldb/Interpreter/OptionValueUUID.h
The file was modifiedlldb/include/lldb/Interpreter/OptionValue.h
The file was modifiedlldb/source/Interpreter/OptionValueFileSpec.cpp
The file was modifiedlldb/source/Interpreter/OptionValueFormatEntity.cpp
The file was modifiedlldb/include/lldb/Interpreter/OptionValueEnumeration.h
The file was modifiedlldb/include/lldb/Interpreter/OptionValueFileSpec.h
The file was modifiedlldb/source/Interpreter/OptionValueDictionary.cpp
The file was modifiedlldb/source/Interpreter/OptionValueFileColonLine.cpp
The file was modifiedlldb/unittests/Interpreter/CMakeLists.txt
The file was modifiedlldb/include/lldb/Interpreter/OptionValueSInt64.h
The file was modifiedlldb/source/Interpreter/OptionValueSInt64.cpp
The file was modifiedlldb/source/Target/Process.cpp
The file was modifiedlldb/source/Interpreter/OptionValueUUID.cpp
The file was modifiedlldb/include/lldb/Interpreter/OptionValuePathMappings.h
The file was modifiedlldb/include/lldb/Interpreter/OptionValueFileSpecList.h
The file was modifiedlldb/include/lldb/Interpreter/OptionValueFormatEntity.h
The file was addedlldb/include/lldb/Utility/Cloneable.h
The file was modifiedlldb/include/lldb/Interpreter/OptionValueArray.h
The file was modifiedlldb/source/Interpreter/OptionValueLanguage.cpp
The file was modifiedlldb/include/lldb/Interpreter/OptionValueArgs.h
The file was addedlldb/unittests/Interpreter/TestOptionValue.cpp
The file was modifiedlldb/include/lldb/Interpreter/OptionValueBoolean.h
The file was modifiedlldb/include/lldb/Interpreter/OptionValueRegex.h
The file was modifiedlldb/source/Target/Target.cpp
The file was modifiedlldb/source/Interpreter/OptionValuePathMappings.cpp
The file was modifiedlldb/source/Interpreter/OptionValueFormat.cpp
The file was modifiedlldb/include/lldb/Interpreter/OptionValueChar.h
The file was modifiedlldb/source/Interpreter/OptionValueEnumeration.cpp
The file was modifiedlldb/include/lldb/Interpreter/OptionValueArch.h
The file was modifiedlldb/include/lldb/Interpreter/OptionValueString.h
The file was modifiedlldb/source/Interpreter/OptionValueProperties.cpp
The file was modifiedlldb/source/Interpreter/OptionValueBoolean.cpp
The file was modifiedlldb/source/Interpreter/OptionValue.cpp
The file was modifiedlldb/include/lldb/Interpreter/OptionValueProperties.h
The file was modifiedlldb/test/API/commands/settings/TestSettings.py
The file was modifiedlldb/include/lldb/Interpreter/OptionValueFormat.h
The file was modifiedlldb/source/Interpreter/OptionValueArray.cpp
The file was modifiedlldb/source/Interpreter/OptionValueChar.cpp
The file was modifiedlldb/source/Interpreter/OptionValueRegex.cpp
The file was modifiedlldb/include/lldb/Interpreter/OptionValueLanguage.h
The file was modifiedlldb/include/lldb/Interpreter/OptionValueFileColonLine.h
The file was modifiedlldb/source/Interpreter/OptionValueString.cpp
The file was modifiedlldb/source/Interpreter/OptionValueArch.cpp
Commit 1d6a6f3b0c710ccd6558644d195cf939c4995d84 by Tatyana Krasnukha
[lldb/Target] Remove outdated code

Arg0 callback does work.
The file was modifiedlldb/include/lldb/Target/Target.h
The file was modifiedlldb/source/Target/Target.cpp
Commit ca5247bb1770a1dfa56b78303d99f1cc9a0a06ee by craig.topper
[DAGCombiner] Don't skip no overflow check on UMULO if the first computeKnownBits call doesn't return any 0 bits.

Even if the first computeKnownBits call doesn't have any zero
bits it is possible the other operand has bitwidth-1 leading zero.
In that case overflow is still impossible. So always call computeKnownBits
for both operands.
The file was modifiedllvm/test/CodeGen/X86/vec_umulo.ll
The file was modifiedllvm/test/CodeGen/AArch64/vec_umulo.ll
The file was modifiedllvm/lib/CodeGen/SelectionDAG/DAGCombiner.cpp