Changes

[InstCombine] Add extra tests for overflow_to_sat.ll. NFC

[InstCombine] Canonicalize sadd.with.overflow with clamp to sadd.sat
This adds to D69245, adding extra signed patterns for folding from a 
sadd_with_overflow to a sadd_sat. These are more complex than the 
unsigned patterns, as the overflow can occur in either direction.
For the add case, the positive overflow can only occur if both of the 
values are positive (same for both the values being negative). So there 
is an extra select on whether to use the positive or negative overflow 
limit.
Differential Revision: https://reviews.llvm.org/D69252

[InstCombine] Canonicalize ssub.with.overflow with clamp to ssub.sat
Working on top of D69252, this adds canonicalisation patterns for
ssub.with.overflow to ssub.sats.
Differential Revision: https://reviews.llvm.org/D69753

[SimplifyCFG] add tests for possible FP speculative select; NFC
It doesn't seem that there are any perf/param knobs that can be turned 
to create selects for the FP variants of the tests, but that may not 
always be true in the future. If it changes, we should propagate FMF.

[SimplifyCFG] add fast-math-flags to tests for better coverage; NFC
The conversion to select fails to propagate FMF.

[SimplifyCFG] propagate fast-math-flags (FMF) from phi to select
Similar to/extension of D70208 (rGee0882bdf866), but this one may
finally allow closing motivating bugs.
This is another step towards having FMF apply only to FP values rather
than those + fcmp. See PR38086 for one of the original 
discussions/motivations: https://bugs.llvm.org/show_bug.cgi?id=38086
And the test here is derived from PR39535: 
https://bugs.llvm.org/show_bug.cgi?id=39535
Currently, we lose FMF when converting any phi to select in SimplifyCFG.
There are a small number of similar changes needed to correct within
SimplifyCFG, so it should be quick to patch this pass up.
FMF was extended to select and phi with: D61917 D67564

[Attributor] Use nofree argument attribute for heap-to-stack conversion
Reviewers: jdoerfert, uenoku
Subscribers:
Differential Revision: https://reviews.llvm.org/D70140

[ConstantFold] Add some tests for binops with constants and undefs.
Precommit tests for D70169.

[ConstantFold] Handle identity folds at top of ConstantFoldBinaryInst
Currently we miss folds with undef and identity values for binary ops 
that do not fold to undef in general.
We can generalize the identity simplifications and do them before 
checking for undef in particular.
Alive checks:
* OR - https://rise4fun.com/Alive/8OsK
* AND - https://rise4fun.com/Alive/e3tE
This will also allow us to remove some now redundant cases throughout 
the function, but I would like to do this as follow-up. That should make 
tracking down potential issues easier.
Reviewers: spatel, RKSimon, lebedev.ri
Reviewed By: spatel
Differential Revision: https://reviews.llvm.org/D70169

[LegalizeTypes] Merge ExpandIntRes_LLROUND and ExpandIntRes_LLRINT into
one function that handles both. NFC
These too functions are were the same except for which libcall gets 
emitted. Just merge them into one.
This is prep work for some other work including strict fp support.

[LegalizeTypes] Remove PromoteFloat support form
ExpandIntRes_LLROUND_LLRINT.
This code isn't exercised, and was in the wrong place. If we need this,
we would need to promote the type before figuring out which libcall to
use.
I'm choosing to remove it rather than fixing since we don't support
PromoteFloat for LRINT/LROUND/LLRINT/LLROUND when the result type is
legal so I don't see much reason to support it for the case where the
result type isn't legal.

[LegalizeTypes] When expanding the integer result of LLROUND/LLRINT,
also call GetSoftenedFloat if the floating point input needs to be
softened.
Before this we were emitting a bitcast to integer from the lowering code
that itself will need to be legalized. By calling GetSoftenedFloat we
get the integer conversion in one step without needing to relegalize a
bitcast.

[InstCombine] prevent crashing/assert on shift constant expression
(PR44028)
The binary operator cast implies an instruction, but the matcher for
shift does not: https://bugs.llvm.org/show_bug.cgi?id=44028

Make it possible to redirect not only errs() but also outs()
This change is for those who use lld as a library. Context: 
https://reviews.llvm.org/D70287
This patch adds a new parmeter to lld::*::link() so that we can pass an
raw_ostream object representing stdout. Previously, lld::*::link() took
only an stderr object.
Justification for making stdoutOS and stderrOS mandatory: I wanted to 
make link() functions to take stdout and stderr in that order. However,
if we change the function signature from
  bool link(ArrayRef<const char *> args, bool canExitEarly,
           raw_ostream &stderrOS = llvm::errs());
to
  bool link(ArrayRef<const char *> args, bool canExitEarly,
           raw_ostream &stdoutOS = llvm::outs(),
           raw_ostream &stderrOS = llvm::errs());
, then the meaning of existing code that passes stderrOS silently 
changes (stderrOS would be interpreted as stdoutOS). So, I chose to make
existing code not to compile, so that developers can fix their code.
Differential Revision: https://reviews.llvm.org/D70292

llvm/ObjCARC: Use continue to reduce some nesting, NFC

[docs] Fix broken links in Kaleidoscope chapter 3
Several links in this document referred to `LangImpl4.html` or
`LangImpl7.html`. However, now these pages use two digits, so for these 
links to function they need to be modified to `LangImpl04.html`, and so 
on -- note the extra `0`.

[PowerPC] extend PPCPreIncPrep Pass for ds/dq form
Now, PPCPreIncPrep pass changes a loop to update form and update all
load/store with same base accordingly. We can do more for load/store
with same base, for example, convert load/store with same base to ds/dq
form.
Reviewed by: jsji
Differential Revision: https://reviews.llvm.org/D67088

[LegalizeTypes][X86] Add support for expanding the result type of
STRICT_LLROUND and STRICT_LLRINT.
This doesn't handle softening the input type, but we don't handle 
softening any of the strict nodes yet. Skipping that made it easy to
reuse an existing function for creating a libcall from a node with a
chain.

llvm/ObjCARC: Split OptimizeIndividualCallImpl out of
OptimizeIndividualCalls, NFC
Split out a helper function for the individual call optimizations and 
skip useless calls to it (where the instruction is not an ARC 
intrinsic).  Besides reducing indentation (and possibly speeding up 
compile time in some small way), an upcoming patch will add additional 
calls and expand out the `switch`.

Rename __is_foo_iterator traits to reflect their Cpp17 nature.
With the upcoming introduction of iterator concepts in ranges, the
meaning of "__is_contiguous_iterator" changes drastically.
Currently we intend it to mean "does it have this iterator category", 
but it could now also mean "does it meet the requirements of this 
concept", and these can be different.

Fix Windows buildbots
`stdout` and `stderr` might be defined as macros, so we needed to avoid
using them as variable names.

[LegalizeTypes] Remove unnecessary conversion from EVT to MVT to
MVT::SimpleValueType just to assign back to EVT. NFC

[LegalizeTypes] Remove SoftenFloat handling from
ExpandIntRes_LLROUND_LLRINT and remove assert from the strict fp path.
These were both recently added. While the call to GetSoftenedFloat is a
little more optimal, we don't do it in the expand for FP_TO_SINT/UINT so
there's no real reason to do it here. This avoids a FIXME for strict fp.

[Sparc] Fix "Cannot select" error for AtomicFence on 32-bit V9
Summary: This also adds testing of 32-bit V9 atomic lowering, splitting
the 64-bit-only tests out into their own file.
Reviewers: venkatra, jyknight
Reviewed By: jyknight
Subscribers: hiraditya, fedor.sergeev, jfb, llvm-commits, glaubitz
Tags: #llvm
Differential Revision: https://reviews.llvm.org/D69352

DWARF location lists: Add section index dumping
Summary: As discussed in D70081, this adds the ability to dump section 
names/indices to the location list dumper. It does this by moving the 
range specific logic from DWARFDie.cpp:dumpRanges into the 
DWARFAddressRange class.
The trickiest part of this patch is the backflip in the meanings of the 
two dump flags for the location list sections.
The dumping of "raw" location list data is now controlled by
"DisplayRawContents" flag. This frees up the "Verbose" flag to be used 
to control whether we print the section index. Additionally, the 
DisplayRawContents flag is set for section-based dumps whenever the
--verbose option is passed, but this is not done for the "inline" dumps.
Also note that the index dumping currently does not work for the DWARF 
v5 location lists, as the parser does not fill out the appropriate 
fields. This will be done in a separate patch.
Reviewers: dblaikie, probinson, JDevlieghere, SouraVX
Subscribers: sdardis, hiraditya, jrtc27, atanasyan, arphaman, aprantl,
llvm-commits
Tags: #llvm
Differential Revision: https://reviews.llvm.org/D70227

[ARM] Allocatable Global Register Variables for ARM
      Provides support for using r6-r11 as globally scoped
     register variables. This requires a -ffixed-rN flag
     in order to reserve rN against general allocation.
      If for a given GRV declaration the corresponding flag
     is not found, or the the register in question is the
     target's FP, we fail with a diagnostic.
      Differential Revision: https://reviews.llvm.org/D68862

[AST] Attach comment in `/** doc */ typedef struct A {} B` to B as well
as A.
Summary: Semantically they're the same thing, and it's important when
the underlying struct is anonymous.
There doesn't seem to be a problem attaching the same comment to
multiple things as it already happens with `/** doc */ int a, b;`
This affects an Index test but the results look better (name present,
USR points to the typedef).
Fixes https://github.com/clangd/clangd/issues/189
Reviewers: kadircet, lh123
Subscribers: ilya-biryukov, jkorous, arphaman, usaxena95, cfe-commits
Tags: #clang
Differential Revision: https://reviews.llvm.org/D70203

[lldb] [test] Enable lldb-server tests on NetBSD, and set XFAILs
Differential Revision: https://reviews.llvm.org/D70335

[lldb] [Process/NetBSD] Implement thread name getting
Implement thread name getting sysctl() on NetBSD.  Also fix the
incorrect type in pthread_setname_np() in the relevant test.
Differential Revision: https://reviews.llvm.org/D70363

[ARM,MVE] Add intrinsics for vector comparisons.
This adds the `vcmp` family of ACLE MVE intrinsics: vector/vector, 
vector/scalar, and the predicated forms of both. All are represented 
using standard existing IR: vector/scalar comparisons are represented by
making a vector out of the scalar first, and predicated forms are 
represented by taking the bitwise AND of the input predicate and the 
output of the comparison. Existing LLVM-side tests demonstrate that ISel
will pattern-match all of that back down to single MVE VCMPs.
The idiom of handling a vector/scalar operation by generating IR to 
expand the scalar into a second vector is going to be needed for a lot 
of MVE intrinsics, so to make that easy, I've provided a helper function
that automatically works out the element count.
The comparison intrinsics are the first ones that have to //return// a 
predicate, in the user-facing `mve_pred16_t` format. This means we have
to use the `arm_mve_pred_v2i` low-level intrinsic to convert it back
from the logical `<n x i1>` form used in IR. I've done that explicitly
in the code gen specification for the builtins, because it happens much
more rarely in the ACLE API than passing a Predicate as input, so it
didn't seem worth automating in MveEmitter.
Reviewers: ostannard, MarkMurrayARM, dmgreen
Reviewed By: dmgreen
Subscribers: kristof.beyls, hiraditya, cfe-commits, llvm-commits
Tags: #clang, #llvm
Differential Revision: https://reviews.llvm.org/D70297

[ARM,MVE] Add InstCombine rules for pred_i2v / pred_v2i.
If you're writing C code using the ACLE MVE intrinsics that passes the 
result of a vcmp as input to a predicated intrinsic, e.g.
  mve_pred16_t pred = vcmpeqq(v1, v2);
 v_out = vaddq_m(v_inactive, v3, v4, pred);
then clang's codegen for the compare intrinsic will create calls to
`@llvm.arm.mve.pred.v2i` to convert the output of `icmp` into an
`mve_pred16_t` integer representation, and then the next intrinsic will
call `@llvm.arm.mve.pred.i2v` to convert it straight back again. This
will be visible in the generated code as a `vmrs`/`vmsr` pair that move
the predicate value pointlessly out of `p0` and back into it again.
To prevent that, I've added InstCombine rules to remove round trips of 
the form `v2i(i2v(x))` and `i2v(v2i(x))`. Also I've taught InstCombine 
about the known and demanded bits of those intrinsics. As a result, you
now get just the generated code you wanted:
  vpt.u16 eq, q1, q2
 vaddt.u16 q0, q3, q4
Reviewers: ostannard, MarkMurrayARM, dmgreen
Reviewed By: dmgreen
Subscribers: kristof.beyls, hiraditya, llvm-commits
Tags: #llvm
Differential Revision: https://reviews.llvm.org/D70313

[NFC][Test] Add the vavg test for PowerPC

[RISCV] Set triple based on -march flag
For RISC-V the value provided to -march should determine whether to 
compile for 32- or 64-bit RISC-V irrespective of the target provided to 
the Clang driver. This adds a test for this flag for RISC-V and sets the 
Target architecture correctly in these cases.
Differential Revision: https://reviews.llvm.org/D54214

[RISCV] Add assembly mnemonic spell checking
Summary: This allows the assembler to suggest alternative assembly
mnemonics when an invalid one has been provided.
Reviewers: asb, lenary, lewis-revill
Reviewed By: asb
Subscribers: hiraditya, rbar, johnrusso, apazos, sabuasal, niosHD,
kito-cheng, shiva0217, jrtc27, MaskRay, zzheng, edward-jones, rogfer01,
MartinMosbeck, brucehoult, the_o, rkruppe, PkmX, jocewei, psnobl, benna,
Jim, s.egerton, pzheng, sameer.abuasal, llvm-commits
Tags: #llvm
Differential Revision: https://reviews.llvm.org/D69894

Fix signed/unsigned comparison warning. NFCI.

[X86][SSE] Add test for extractelement with multiple uses
Mentioned in D70267

Fix "not all control paths return a value" warning. NFCI.

[clangd] Expose the xref's incomplete flag to clangdServer API.
Summary: so that clangd C++ API users (via ClangdServer) can access it.
Reviewers: sammccall
Subscribers: ilya-biryukov, MaskRay, jkorous, arphaman, kadircet,
usaxena95, cfe-commits
Tags: #clang
Differential Revision: https://reviews.llvm.org/D70380

[SVE][CodeGen] Scalable vector MVT size queries
* Implements scalable size queries for MVTs, split out from D53137.
* Contains a fix for FindMemType to avoid using scalable vector type
 to contain non-scalable types.
* Explicit casts for several places where implicit integer sign
 changes or promotion from 32 to 64 bits caused problems.
* CodeGenDAGPatterns will treat scalable and non-scalable vector types
 as different.
Reviewers: greened, cameron.mcinally, sdesmalen, rovka
Reviewed By: rovka
Differential Revision: https://reviews.llvm.org/D66871

[PowerPC] [NFC] add IR testcases for folding rlwinma.

Fix a print error found while testing llvm-objcopy
A value was not printed as hex. This updates the output and test cases.

[lldb][NFC] Cleanup comments in ClangASTSource.h
The current file doesn't follow the 80 character limit and uses this 
cramped comment style that is hard to read.

Fix uninitialized variable warning. NFC.

llvm-rc - fix uninitialized variable warnings. NFC.

Fix uninitialized variable warning. NFC.

DwarfGenerator - fix uninitialized variable warnings. NFC.

Revert rGc0f6ad7d1f3c : "DWARF location lists: Add section index
dumping"
This reverts commit c0f6ad7d1f3ccb9d0b9ce9ef8dfa06409ccf1b3e to fix the
buildbots.

[OpenMP] Add implementation and tests of Archer tool
The tool provides TSAN annotations for OpenMP synchronization. The tool 
is activated if no other OMPT tool is loaded.
The tool detects whether the application was built with TSan and rejects 
activation according to the OMPT protocol if there is no TSan-rt.
Differential Revision: https://reviews.llvm.org/D45890

Avoid duplicate exe_path definition on recent FreeBSD

llvm-objcopy  - fix uninitialized variable warnings. NFC.

Fix cppcheck shadow variable warning. NFC.

[clangd] Fix diagnostic warnings in the RenameTests, NFC.

Remove useless param tag to fix Wdocumentation warning. NFCI.

[lldb] Fix JSON parser to allow empty arrays
Summary: Bugzilla: https://bugs.llvm.org/show_bug.cgi?id=39405
``` alexc@kitty:~/work/wiredtiger/build_posix$ cat breakpoint.json
[{"Breakpoint" : {"BKPTOptions" : {"AutoContinue" :
false,"ConditionText" : "","EnabledState" : true,"IgnoreCount" :
0,"OneShotState" : false},"BKPTResolver" : {"Options" : {"NameMask" :
[56],"Offset" : 0,"SkipPrologue" : true,"SymbolNames" :
["__wt_btcur_search"]},"Type" : "SymbolName"},"Hardware" :
false,"SearchFilter" : {"Options" : {},"Type" : "Unconstrained","Foo" :
[]}}}]
```
**Before**
```
(lldb) breakpoint read --file breakpoint.json error: Invalid JSON from
input file: /home/alexc/work/wiredtiger/build_posix/breakpoint.json.
```
**After**
```
(lldb) breakpoint read --file breakpoint.json New breakpoints: 
Breakpoint 1: where = libwiredtiger-3.2.2.so`__wt_btcur_search + 15 at
bt_cursor.c:522:5, address = 0x00007ffff576ab2f
```
Reviewers: xbolva00, davide, labath
Reviewed By: davide, labath
Subscribers: mgorny, jingham, labath, davide, JDevlieghere, lldb-commits
Tags: #llvm, #lldb
Differential Revision: https://reviews.llvm.org/D68179

[clangd] Fix some clang-tidy warnings on SourceCodeTests.cpp, NFC.

[AMDGPU][MC][GFX10] Enabled v_movrel*[sdwa|dpp|dpp8] opcodes
See https://bugs.llvm.org/show_bug.cgi?id=43712
Reviewers: arsenm, rampitec
Differential Revision: https://reviews.llvm.org/D70170

Re-commit "DWARF location lists: Add section index dumping"
This reapplies c0f6ad7d1f3ccb9d0b9ce9ef8dfa06409ccf1b3e with an 
additional fix in test/DebugInfo/X86/constant-loclist.ll, which had a 
slightly different output on windows targets. The test now accounts for 
this difference.
The original commit message follows.
Summary: As discussed in D70081, this adds the ability to dump section 
names/indices to the location list dumper. It does this by moving the 
range specific logic from DWARFDie.cpp:dumpRanges into the 
DWARFAddressRange class.
The trickiest part of this patch is the backflip in the meanings of the 
two dump flags for the location list sections.
The dumping of "raw" location list data is now controlled by
"DisplayRawContents" flag. This frees up the "Verbose" flag to be used 
to control whether we print the section index. Additionally, the 
DisplayRawContents flag is set for section-based dumps whenever the
--verbose option is passed, but this is not done for the "inline" dumps.
Also note that the index dumping currently does not work for the DWARF 
v5 location lists, as the parser does not fill out the appropriate 
fields. This will be done in a separate patch.
Reviewers: dblaikie, probinson, JDevlieghere, SouraVX
Subscribers: sdardis, hiraditya, jrtc27, atanasyan, arphaman, aprantl,
llvm-commits
Tags: #llvm
Differential Revision: https://reviews.llvm.org/D70227

arm64_32: support function return in FastISel.

Revert "[DWARF5]Addition of alignment atrribute in typedef DIE."
This reverts commit 423f541c1a322963cf482683fe9777ef0692082d, which 
breaks llvm-c ABI.

[NFC] Fix test reserve_global_reg.ll after 2d739f9

[clangd] Implement rename by using SelectionTree and
findExplicitReferences.
Summary: With the new implemenation, we will have better coverage of
various AST nodes, and fix some known/potential bugs.
Also added the existing clang-renamae tests. Known changed behavior:
- "~Fo^o()" will not trigger the rename, will fix afterwards
- references in macro bodies are not renamed now
This fixes:
- https://github.com/clangd/clangd/issues/167
- https://github.com/clangd/clangd/issues/169
- https://github.com/clangd/clangd/issues/171
Reviewers: ilya-biryukov
Subscribers: MaskRay, jkorous, arphaman, kadircet, usaxena95,
cfe-commits
Tags: #clang
Differential Revision: https://reviews.llvm.org/D69934

[NFC] Clean up debug-names-verify-completeness.s test
This patch replaces the tabs by spaces and avoid the need for a 
debug_str section by moving all strings inline. It also removes the 
hardcoded DIE offsets in the test, which will simplify a follow-up 
patch.

[clangd] Store xref for Macros in ParsedAST.
This patch adds the cross references for Macros in the MainFile. We add
references for the main file to the ParsedAST. We query the references
from it using the SymbolID. Xref outside main file will be added to the
index in a separate patch.

gn build: Merge 2054ed052f1

[ASan] Mark test as UNSUPPORTED for iOS simulator
coverage-fork.cpp uses `fork()` which requires additional permissions in
the iOS simulator sandbox.  We cannot use `sandbox-exec` to grant these
permissions since this is a Posix (not Darwin) test.

[OPENMP50]Fix PR44024: runtime assert in distribute construct.
If the code is emitted for distribute construct, the nonmonotonic 
modifier should not be added.

[dwarfgen] Fix initialization order error. [NFCI]
This commit fixes the `-Werror=reorder` builds.

[Attr] Fix `-ast-print` for `asm` attribute
Without this fix, the tests introduced here produce the following assert
fail:
``` clang:
/home/jdenny/llvm/clang/include/clang/Basic/AttributeCommonInfo.h:163:
unsigned int clang::AttributeCommonInfo::getAttributeSpellingListIndex()
const: Assertion `(isAttributeSpellingListCalculated() || AttrName) &&
"Spelling cannot be found"' failed.
```
The bug was introduced by D67368, which caused `AsmLabelAttr`'s spelling
index to be set to `SpellingNotCalculated`.
Reviewed By: aaron.ballman
Differential Revision: https://reviews.llvm.org/D70349

[yaml2obj][test] Move tests to binary format specific subdirectories
Create COFF/, ELF/, and Minidump and move tests there.
Also
* Rename `*.test` to `*.yaml`
* For yaml2obj RUN lines, use `-o %t` instead of `> %t` for consistency.
 We still have tests that check stdout is the default output, e.g.
 multi-doc.test
* Update tests to consistently use `##` for comments.
 `#` is for RUN and CHECK lines.
* Merge symboless-relocation.yaml and invalid-symboless-relocation.yaml
to ELF/relocation-implicit-symbol-index.test
Reviewed By: grimar, jhenderson
Differential Revision: https://reviews.llvm.org/D70264

[Docs] Add Python caveats under the development section
This adds a page named Caveats with a section on some of the things to 
be aware of related to Python. It's a question we've seen more than once 
pop up and I think it's good to have it documentation on the website. 
Even though some of it might be useful to users, I still put it under
"development" because it requires some understanding of how LLDB is 
built.
Differential revision: https://reviews.llvm.org/D70252

Bump sanitizer macOS deployment target to 10.10
Bump default value for `SANITIZER_MIN_OSX_VERSION` to 10.10 (from 10.9). 
TSan does not work on macOS 10.9 and a nice error message is preferable 
to an "unreferenced symbol" error when loading the TSan runtime.
We could try to only bump the deployment target for TSan, but we would 
have to invest into adding support for this to our CMake build and it 
does not seem worth it.  macOS 10.10 was released in 2014.
rdar://31335781

Bump sanitizer iOS deployment target to 9.0
Bump default value for `-miphoneos-version-min=x` to 9.0 (from 8.0). 
TSan tests that use thread local storage `__thread` (e.g., tls_race.cpp) 
are failing to link for the iOS simulator (arch=x86_64 and
-miphoneos-version-min=8.0) on internal/master (will be submitted to 
Glacier train):
``` ld: targeted OS version does not support use of thread local
variables in _main for architecture x86_64
```
iOS 9.0 was released 2015.

[cmake] Factor out DEFAULT_SANITIZER_MIN_OSX_VERSION

Replace bitfield in lldb::Type with byte-sized members. (NFC)
Due to alginment and packing using separate members takes up the same 
amount of space, but makes it far less cumbersome to deal with it in 
constructors etc.

Fix shared lib build.

[libomptarget][nfc] Move some source into common from nvptx
Summary:
[libomptarget][nfc] Move some source into common from nvptx
Moves some source that compiles cleanly under amdgcn into a common
subdirectory Includes some non-trivial files and some headers. Keeps the
cuda file extension.
The build systems for different architectures seem unlikely to have much
in common. The idea is therefore to set include paths such that files
under common/src compile as if they were under arch/src as the mechanism
for sharing. In particular, files under common/src need to be able to
include target_impl.h.
The corresponding -Icommon is left out in favour of explicit includes on
the basis that the it makes it clearer which files under common are used
by a given architecture.
Reviewers: jdoerfert, ABataev, grokos
Reviewed By: ABataev
Subscribers: jfb, mgorny, openmp-commits
Tags: #openmp
Differential Revision: https://reviews.llvm.org/D70328

[Signal] Allow llvm clients to opt into one-shot SIGPIPE handling
Allow clients of the llvm library to opt-in to one-shot SIGPIPE 
handling, instead of forcing them to undo llvm's SIGPIPE handler 
registration (which is brittle).
The current behavior is preserved for all llvm-derived tools (except 
lldb) by means of a default-`true` flag in the InitLLVM constructor.
This prevents "IO error" crashes in long-lived processes (lldb is the 
motivating example) which both a) load llvm as a dynamic library and b)
*really* need to ignore SIGPIPE.
As llvm signal handlers can be installed when calling into libclang
(say, via RemoveFileOnSignal), thereby overriding a previous SIG_IGN for 
SIGPIPE, there is no clean way to opt-out of "exit-on-SIGPIPE" in the 
current model.
Differential Revision: https://reviews.llvm.org/D70277

[builtins] Implement rounding mode support for i386/x86_64
Differential Revision: https://reviews.llvm.org/D69870

[Remarks][Driver] Use different remark files when targeting multiple
architectures
When the driver is targeting multiple architectures at once, for things 
like Universal Mach-Os, we need to emit different remark files for each 
cc1 invocation to avoid overwriting the files from a different 
invocation.
For example:
$ clang -c -o foo.o -fsave-optimization-record -arch x86_64 -arch
x86_64h
will create two remark files:
* foo-x86_64.opt.yaml
* foo-x86_64h.opt.yaml

Allocate builtins table earlier to fix bug found by ubsan
Follow up to 979da9a4c3ba

Temporarily Revert "Add support for options -frounding-math,
ftrapping-math, -ffp-model=, and -ffp-exception-behavior=" and a
follow-up NFC rearrangement as it's causing a crash on valid. Testcase
is on the original review thread.
This reverts commits af57dbf12e54f3a8ff48534bf1078f4de104c1cd and
e6584b2b7b2de06f1e59aac41971760cac1e1b79

Revert "[Remarks][Driver] Use different remark files when targeting
multiple architectures"
This reverts commit b4e2b112b58154a89171df39dae80044865ff4ff.
Test doesn't appear to pass on Windows, maybe all non-Mac.

[PowerPC] Test case for vector float gather on ppc64le and ppc64
Test case to verify that the expected code is generated for a vector
float gather based on the patterns in tablegen for big and little endian
cases.
Patch by: Kamau Bridgeman
Differential Revision: https://reviews.llvm.org/D69443

Reland: [Remarks][Driver] Use different remark files when targeting
multiple architectures
When the driver is targeting multiple architectures at once, for things 
like Universal Mach-Os, we need to emit different remark files for each 
cc1 invocation to avoid overwriting the files from a different 
invocation.
For example:
$ clang -c -o foo.o -fsave-optimization-record -arch x86_64 -arch
x86_64h
will create two remark files:
* foo-x86_64.opt.yaml
* foo-x86_64h.opt.yaml

[LoopPred/WC] Use a dominating widenable condition to remove analyze
loop exits
This implements a version of the predicateLoopExits transform from
IndVarSimplify extended to exploit widenable conditions - and thus be
much wider in scope of legality. The code structure ends up being almost
entirely different, so I chose to duplicate this into the
LoopPredication pass instead of trying to reuse the code in the IndVars.
The core notions of the transform are as follows:
    If we have a widenable condition which controls entry into the loop,
we're allowed to widen it arbitrarily. Given that, it's simply a
*profitability* question as to what conditions to fold into the
widenable branch.
   To avoid pass ordering issues, we want to avoid widening cases that
would otherwise be dischargeable. Or... widen in a form which can still
be discharged. Thus, we phrase the transform as selecting one
analyzeable exit from the set of analyzeable exits to keep. This avoids
creating pass ordering complexities.
   Since none of the above proves that we actually exit through our
analyzeable exits - we might exit through something else entirely - we
limit ourselves to cases where a) the latch is analyzeable and b) the
latch is predicted taken, and c) the exit being removed is statically
cold.
Differential Revision: https://reviews.llvm.org/D69830

[LegalizeDAG] Convert strict fp nodes to libcalls without losing the
chain.
Previously we mutated the node and then converted it to a libcall. But
this loses the chain information.
This patch keeps the chain, but unfortunately breaks tail call
optimization as the functions involved in deciding if a node is in tail
call position can't handle the chain. But correct ordering seems more
important to be right.
Somehow the SystemZ tests improved. I looked at one of them and it
seemed that we're handling the split vector elements in a different
order and that made the copies work better.
Differential Revision: https://reviews.llvm.org/D70334

Implement __attribute__((objc_direct)),
__attribute__((objc_direct_members))
__attribute__((objc_direct)) is an attribute on methods declaration, and
__attribute__((objc_direct_members)) on implementation, categories or 
extensions.
A `direct` property specifier is added (@property(direct) type name)
These attributes / specifiers cause the method to have no associated 
Objective-C metadata (for the property or the method itself), and the 
calling convention to be a direct C function call.
The symbol for the method has enforced hidden visibility and such direct 
calls are hence unreachable cross image. An explicit C function must be 
made if so desired to wrap them.
The implicit `self` and `_cmd` arguments are preserved, however to 
maintain compatibility with the usual `objc_msgSend` semantics, 3
fundamental precautions are taken:
1) for instance methods, `self` is nil-checked. On arm64 backends this
  typically adds a single instruction (cbz x0, <closest-ret>) to the
  codegen, for the vast majority of the cases when the return type is a
  scalar.
2) for class methods, because the class may not be realized/initialized
  yet, a call to `[self self]` is emitted. When the proper deployment
  target is used, this is optimized to `objc_opt_self(self)`.
   However, long term we might want to emit something better that the
  optimizer can reason about. When inlining kicks in, these calls
  aren't optimized away as the optimizer has no idea that a single call
  is really necessary.
3) the calling convention for the `_cmd` argument is changed: the caller
  leaves the second argument to the call undefined, and the selector is
  loaded inside the body when it's referenced only.
As far as error reporting goes, the compiler refuses:
- making any overloads direct,
- making an overload of a direct method,
- implementations marked as direct when the declaration in the
 interface isn't (the other way around is allowed, as the direct
 attribute is inherited from the declaration),
- marking methods required for protocol conformance as direct,
- messaging an unqualified `id` with a direct method,
- forming any @selector() expression with only direct selectors.
As warnings:
- any inconsistency of direct-related calling convention when
 @selector() or messaging is used,
- forming any @selector() expression with a possibly direct selector.
Lastly an `objc_direct_members` attribute is added that can decorate
`@implementation` blocks and causes methods only declared there (and in 
no `@interface`) to be automatically direct. When decorating an
`@interface` then all methods and properties declared in this block are 
marked direct.
Radar-ID: rdar://problem/2684889 Differential Revision:
https://reviews.llvm.org/D69991 Reviewed-By: John McCall

[X86] Add AMD Matisse (znver2) model number to getHostCPUName and
compiler-rt's getAMDProcessorTypeAndSubtype.
This is the CPUID model used on Ryzen 3000 series (Zen 2/Matisse) CPUs.
Patch by Alex James
Differential Revision: https://reviews.llvm.org/D70279

[ThinLTO] Promotion handling cleanup (NFC)
Summary: Clean up the code that does GV promotion in the ThinLTO
backends.
Specifically, we don't need to check whether we are importing since that 
is already checked and handled correctly in shouldPromoteLocalToGlobal. 
Simply call shouldPromoteLocalToGlobal, and if it returns true we are 
guaranteed that we are promoting, whether or not we are importing (or in 
the exporting module). This also makes the handling in getName() 
consistent with that in getLinkage(), which checks the DoPromote
parameter regardless of whether we are importing or exporting.
Reviewers: steven_wu, pcc, evgeny777
Subscribers: mehdi_amini, inglorion, hiraditya, dexonsmith, llvm-commits
Tags: #llvm
Differential Revision: https://reviews.llvm.org/D70327

Update the docs for building libc++.
Summary: Rewrite the in-tree build to be a clearer tl;dr like we have
for the out-of-tree build.
Reviewers: EricWF, mclow.lists, ldionne
Reviewed By: ldionne
Subscribers: dexonsmith, christof, ldionne, enh, libcxx-commits
Tags: #libc
Differential Revision: https://reviews.llvm.org/D69917

[Sema] Fix a -Wobjc-signed-char-bool false-positive
Unsigned bit-field flags can only have boolean values, so handle that
case in Expr::isKnownToHaveBooleanValue.
rdar://56256999

[X86] Add a 'break;' to the end of the last case in a switch to avoid
surprising the next person to add a case after this one. NFC

Fix _LIBCPP_HAS_ definitions for Android.
Summary: Android added quick_exit()/at_quick_exit() in API level 21, 
aligned_alloc() in API level 28, and timespec_get() in API level 29, but
has the other C11 features at all API levels (since they're basically 
just coming from clang directly).
_LIBCPP_HAS_QUICK_EXIT and _LIBCPP_HAS_TIMESPEC_GET already existed, so
we can reuse them. (And use _LIBCPP_HAS_TIMESPEC_GET in a few more 
places where _LIBCPP_HAS_C11_FEATURES has been used as a proxy. This 
isn't correct for Android.)
_LIBCPP_HAS_ALIGNED_ALLOC is added, to cover aligned_alloc()
(obviously).
Add a missing std:: before aligned_alloc in a cstdlib test, and remove a 
couple of !defined(_WIN32)s now that we're explicitly testing 
TEST_HAS_ALIGNED_ALLOC rather than TEST_HAS_C11_FEATURES.
Reviewers: danalbert, EricWF, mclow.lists
Reviewed By: danalbert
Subscribers: srhines, christof, libcxx-commits
Tags: #libc
Differential Revision: https://reviews.llvm.org/D69929

implement printing out raw section data of xcoff objectfile for
llvm-objdump
SUMMARY: implement printing out raw section data of xcoff objectfile for
llvm-objdump and option -D --disassemble-all option for llvm-objdump
Reviewers: Sean Fertile Subscribers: rupprecht, seiyai,hiraditya
Differential Revision: https://reviews.llvm.org/D70255

Populate CUDA flags on FreeBSD too, as many other toolchains do.
Summary: This allows `clang` to be used to compile CUDA programs.
Compiled simple helloworld.cu with this.
Reviewers: dim, emaste, tra, yaxunl, ABataev
Reviewed By: tra
Subscribers: dim, emaste, cfe-commits
Tags: #clang
Differential Revision: https://reviews.llvm.org/D69990

[ThinLTO] Avoid extra index lookup during promotion
Summary: Pass down the already accessed ValueInfo to
shouldPromoteLocalToGlobal, to avoid an unnecessary extra index lookup.
Add some assertion checking to confirm we have a non-empty VI when 
expected.
Also some misc cleanup, merging the two versions of 
doImportAsDefinition, since one was only called by the other, and 
unnecessarily passed in a member variable.
Reviewers: steven_wu, pcc, evgeny777
Reviewed By: evgeny777
Subscribers: mehdi_amini, inglorion, hiraditya, dexonsmith, arphaman,
llvm-commits
Tags: #llvm
Differential Revision: https://reviews.llvm.org/D70337

[profile] Support online merging with continuous sync mode
Make it possible to use online profile merging ("%m" mode) with 
continuous sync ("%c" mode).
To implement this, the merged profile is locked in the runtime 
initialization step and either a) filled out for the first time or b) 
checked for compatibility. Then, the profile can simply be mmap()'d with 
MAP_SHARED set. With the mmap() in place, counter updates from every 
process which uses an image are mapped onto the same set of physical 
pages assigned by the filesystem cache. After the mmap() is set up, the 
profile is unlocked.
Differential Revision: https://reviews.llvm.org/D69586

[macho] Allow CPUSubtype to be adjusted before writing it to a file
Summary: It's not always possible for a target to provide a MachO
CPUSubtype up front as is required by the current implementation.
Sometimes you need more information like the particular CPU
implementation you are targeting.
Give MCMachObjectTargetWriter subclasses the opportunity to modify the 
CPUSubtype after the MCMachObjectTargetWriter is created but before the 
object starts being written. Typically this would be done in response to 
instructions from a TargetStreamer.
Reviewers: pete
Subscribers: llvm-commits
Tags: #llvm
Differential Revision: https://reviews.llvm.org/D70344

[macho] Allow CPUSubtype to contribute to architecture identification
Summary: Sometimes the CPUSubtype determines the Triple::ArchType that
must be used. Add the subtype to the API's to allow targets that need
this to correctly identify the contents of the binary.
Reviewers: pete
Subscribers: hiraditya, llvm-commits
Tags: #llvm
Differential Revision: https://reviews.llvm.org/D70345

Fix iOSDarwin()'s doc comment.
Summary: I saw the doc comment using the Option + Click in Xcode and I
was confused by the fact that tvOS wasn't listed. The method definition 
also doesn't make it clear that the check for tvOS is taking place as 
the tvOS check is hidden in the isiOS() check.
Reviewers: rjmccall
Reviewed By: rjmccall
Subscribers: dexonsmith, llvm-commits
Tags: #llvm
Differential Revision: https://reviews.llvm.org/D70364
This patch is from Varun Gandhi <varun_gandhi@apple.com>

[libc++] Separate -include and path to the site config file
This apparently breaks weird use cases where the build directory is on a
separate drive. Someone reported that failure to me privately.
I can't remember of a reason for collating the two arguments in the 
first place, so I don't think this should break anything.

[lldb] [unittest] Reenable MainLoopTest.DetectsEOF on NetBSD
The underlying issue is already fixed in the NetBSD kernel for some 
time, so we can finally reenable the test.

[lldb] [unittest] Skip TestStopReplyContainsThreadPcs on NetBSD

[lldb] [test] Mark segv-related tests XFAIL on NetBSD
There seems to be a regression in the kernel causing those tests to
fail.  Mark them XFAIL, to be addressed later.

[lldb] [test] XFAIL more lldb-server tests on NetBSD

[NFC] Fix 'target' condition in checkTargetFeatures
checkTargetFeatures was incorrectly checking for cpu_specific instead of 
just 'target'. While this function was never called in that situation, 
it seemed correct to fix the condition.  Additionally, multiversion 
functions can never be always_inline, but if any function accidentially 
ended up here we shouldn't diagnose.
Note that the adding of target-features to the list is unnecessary since 
the getFunctionFeatureMap actually considers attribute target, however
adding it results in significantly better error messages by putting the
'target' features first (and thus first to fail). Otherwise, the error
message would be the first feature 'implied' by the target attribute,
and not necessarily the feature listed in the attribute itself.

[PowerPC] Improve float vector gather codegen
This patch aims to improve the code generation for float vector gather
on POWER9. Patterns have been implemented to utilize instructions that
deliver improved performance.
Patch by: Kamau Bridgeman
Differential Revision: https://reviews.llvm.org/D62908

[SLP] reduce duplicated check lines in tests; NFC

Adding a test case for read-only data assembly writing for aix
SUMMARY:
Adding a test case  for read-only data assembly writing for aix
Reviewers: daltenty,Xiangling_Liao Subscribers: rupprecht,
seiyai,hiraditya
Differential Revision: https://reviews.llvm.org/D70182

Temporarily revert "[SLP] fix miscompile on min/max reductions with
extra uses (PR43948)" as it causes an ICE on valid. A testcase was
followed up on the original thread.
This reverts commit a3e61946c5bd7bdfab15af76b292e52d6ffa27f7.

ThinLTO: Fix assembler to emit alwaysInline in the summary
Summary: The earlier commit (https://reviews.llvm.org/D70014) missed
this one : If Always_Inline happens to be the only entry in FuncFlags,
then the assembler will not print it in the summary.
Patch by Bharathi Seshadri <bseshadr@cisco.com>
Reviewers: tejohnson
Reviewed By: tejohnson
Subscribers: mehdi_amini, inglorion, hiraditya, steven_wu, dexonsmith,
llvm-commits
Tags: #llvm
Differential Revision: https://reviews.llvm.org/D70323

[llvm-cxxfilt] Improve strip-underscore behavior
Summary: For platform that uses macho format, c++filt should be
stripping the leading underscore by default. Introduce the binutil
compatible "-n" option to control strip-undercore behaivor together with
the existing
"-_" option and fallback to system default if none of them are set.
rdar://problem/57173514
Reviewers: compnerd, erik.pilkington, dexonsmith, mattd
Reviewed By: compnerd, erik.pilkington
Subscribers: jkorous, ributzka, llvm-commits
Tags: #llvm
Differential Revision: https://reviews.llvm.org/D70250

[CodeGen] Assign locations to calls to special struct helpers
Assign artificial locations to calls to special struct-related helper 
functions.
Such calls may not inherit a location if emitted within FinishFunction, 
at which point the lexical scope stack may be empty, causing CGDebugInfo 
to report the current DebugLoc as empty.
Fixes an IR verifier complaint about a call to '__destructor_8_s0' not 
having a !dbg location attached.
rdar://57293361

gn build: (manually) try to merge 1689ad27af

gn build: Merge 30e7ee3c4ba

Revert "[clangd] Implement rename by using SelectionTree and
findExplicitReferences."
This reverts commit 4f80fc2491cc35730a9a84b86975278b7daa8522.
Caused buildbot failure at 
http://lab.llvm.org:8011/builders/llvm-clang-lld-x86_64-scei-ps4-ubuntu-fast/builds/58251

[OpenMP] Remove -Wl,-fini=__kmp_internal_end_fini
Summary: The termination function duplicated the functionality of the
__attribute((destructor))-annotated function __kmp_internal_end_fini, 
and we have no indication that this doesn't work.
The function might cause issues with link-time optimization turned on: 
until very recently, none of the usual linkers was reporting functions 
named in -Wl,-fini as used to the LTO plugin, so it might be dropped. If
the function is dropped, -Wl,-fini=__kmp_internal_end_fini doesn't do
what we want: with ld.bfd and lld it drops the FINI attribute from
.dynamic and with gold we get FINI = 0x0, which leads to a crash on 
cleanup. This can be reproduced by building with
    -DLLVM_ENABLE_PROJECTS="clang;openmp" \
   -DLLVM_ENABLE_LTO=Thin \
   -DLLVM_USE_LINKER=gold
The issue in lld has been fixed in f95273f75aa, but gold remains without 
fix so far.
Fixes PR43927.
Reviewers: JonChesterfield, jdoerfert, AndreyChurbanov
Reviewed By: AndreyChurbanov
Differential Revision: https://reviews.llvm.org/D69927

[Docs] Add reproducer documentation
This adds a page about LLDB reproducers. It describes how to use the 
reproducers on the command line and lists some of the known 
issues/limitations.
Differential revision: https://reviews.llvm.org/D70409

Fix error message missed in commit
dde589389fcb8b5098f7a47f1b781b27d29a0cac.
Patch by Andrew Browne <browneee@google.com>
Reviewers: tejohnson, evgeny777
Reviewed By: tejohnson
Subscribers: arphaman, hiraditya, llvm-commits
Tags: #llvm
Differential Revision: https://reviews.llvm.org/D70195

[CMake] Re-enable -Wno-gnu-anonymous-struct & -Wno-nested-anon-types.
We're checking for support but we're discarding the result. My best 
guess is that these warnings were disabled in the past. However, I don't 
see a reason to keep it that way.

Revert "[CMake] Re-enable -Wno-gnu-anonymous-struct &
-Wno-nested-anon-types."
Whoops, they should be enabled, not disabled.

[Bindings][Go] Fix go.test failure due to missing argument go.test
failed with error ```
/tmp/gopath431502532/src/llvm.org/llvm/bindings/go/llvm/dibuilder.go:514:40:
not enough arguments in call to _Cfunc_LLVMDIBuilderCreateTypedef       
 have (_Ctype_LLVMDIBuilderRef, _Ctype_LLVMMetadataRef, *_Ctype_char,
_Ctype_ulong, _Ctype_LLVMMetadataRef, _Ctype_uint,
_Ctype_LLVMMetadataRef)         want
(*_Ctype_struct_LLVMOpaqueDIBuilder, *_Ctype_struct_LLVMOpaqueMetadata,
*_Ctype_char, _Ctype_ulong, *_Ctype_struct_LLVMOpaqueMetadata,
_Ctype_uint, *_Ctype_struct_LLVMOpaqueMetadata, _Ctype_uint) ``` This
patch fixes above error.
Differential Revision: https://reviews.llvm.org/D70360

Revert "[Bindings][Go] Fix go.test failure due to missing argument"
This reverts commit 88235812a71d99c082e7aa2ef9356d43d1f83a80 due to 
d27a16eb392f39f9ee04ff5194b1eff3e189e6f8.

Fix component build
b11386f9be9b2dc7276a758d64f66833da10bdea broke lld build if
`-DBUILD_SHARED_LIBS=ON` is passed to CMake.

Revert "Fix shared lib build."
This reverts commit 17e37ba57a696198c9744eeba4f8f293f155587a because it
introduced a circular dependency between Core and Common. Because
d0371f473675ede1d79a615ec4fdf0cf5368944c fixed a build issue, we no
longer need that dependency.

Revert "implement printing out raw section data of xcoff objectfile for
llvm-objdump"
This reverts commit 8f8a9f3437d4517f674395da30edb59d5514f7bc.
Reverting since this patch seems to break a lot of llvm buildbots.

[SelectionDAG] Merge the two identical ExpandChainLibCall methods from
LegalizeTypes and LegalizeDAG to one version in TaretLowering.
Reviewers: RKSimon, efriedma, spatel
Reviewed By: efriedma
Subscribers: hiraditya, llvm-commits
Tags: #llvm
Differential Revision: https://reviews.llvm.org/D70354

bugpoint: Add option to disable attribute removal
This takes a long time and never reduces anything useful for me
(e.g. I've been waiting for 3 hours on a testcase and it hasn't found 
any attributes to remove yet). This should probably start by assuming no
attributes matter, and adding back.

AMDGPU: Split test functions to avoid dependency on subtarget
Prepare this test for moving tthe denormal setting out of the subtarget
features.

[clang][IFS] Driver pipeline: generate interface stubs after standard
pipeline.
Up until now, clang interface stubs has replaced the standard PP -> C ->
BE -> ASM -> LNK pipeline. With this change, it will happen in 
conjunction with it. So what when you build your code you will get an 
a.out or lib.so as well as an interface stub file.
Example:
clang -shared -o libfoo.so -emit-interface-stubs ...
will generate both a libfoo.so and a libfoo.ifso. The .so file will 
contain the code from the standard compilation pipeline and the .ifso 
file will contain the ELF stub library.
Differential Revision: https://reviews.llvm.org/D70274

Revert "[clang][IFS] Driver pipeline: generate interface stubs after
standard pipeline."
This reverts commit 58ea00b51fe9b011301484957556872fced7dd08.
Test for .o + .ifs sidecar files is brittle and failing on bots. 
Reverting to unblock.

[lldb-server] Use LLDB_LOG_ERROR to consume Error<> even if logging is
disabled
Differential Revision: https://reviews.llvm.org/D70386

[X86] Add more addcarry tests
Summary: More addcarry tests for incoming
https://reviews.llvm.org/D70079.
Reviewers: davezarzycki, RKSimon, spatel, craig.topper
Reviewed By: spatel
Subscribers: craig.topper, llvm-commits
Tags: #llvm
Differential Revision: https://reviews.llvm.org/D70237

[ARM][MVE] Tail predication conversion
This patch modifies ARMLowOverheadLoops to convert a predicated vector
low-overhead loop into a tail-predicatd one. This is currently a very
basic conversion, with the following restrictions:
- Operates only on single block loops.
- The loop can only contain a single vctp instruction.
- No other instructions can write to the vpr.
- We only allow a subset of the mve instructions in the loop.
TODO: Pass the number of elements, not the number of iterations to 
dlstp/wlstp.
Differential Revision: https://reviews.llvm.org/D69945

Revert 1689ad27af5 "[builtins] Implement rounding mode support for
i386/x86_64"
It broke the build with MSVC:
fp_mode.c(20): error C2065: '__asm__': undeclared identifier
> Differential Revision: https://reviews.llvm.org/D69870

[NFC] Test commit. Please ignore.
As a test commit I fixed a misspelling in one of comments in SLP 
vectorizer.

[clang-format] [NFC] add recent changes to release notes
Summary: clang-tidy keeps nice release notes of what is added, have
clang-format do the same.
Reviewers: klimek, mitchell-stellar, sylvestre.ledru, sammccall
Reviewed By: mitchell-stellar
Subscribers: merge_guards_bot, Eugene.Zelenko, cfe-commits
Tags: #clang-format, #clang
Differential Revision: https://reviews.llvm.org/D70355

[ARM][MVE] Enable narrow vectors for tail pred
Remove the restriction, from the mve tail predication pass, that the all
masked vectors instructions need to be 128-bits. This allows us to
supported extending loads and truncating stores.
Differential Revision: https://reviews.llvm.org/D69946

[APInt] add wrap support for `setBits` and `getBitsSet`
Add two new interfaces getBitsSet and getBitsSetWithWrap
Reviewed by: lebedev.ri, craig.topper
Differential Revision: https://reviews.llvm.org/D69032

Reland "[clangd] Implement rename by using SelectionTree and
findExplicitReferences."
this reland the commit 4f80fc2491cc35730a9a84b86975278b7daa8522 which 
has been reverted at f805c60a093325c16ce4200d2615ef48555d9cb8.
Fixed windows buildbot failure (by adding -fno-delayed-template-parsing
flag).

Add operator<< for object::SectionedAddress
The main motivation for this is better failure messages in unit tests.
Split off from D70394.

Add streaming/equality operators to
DWARFAddressRange/DWARFLocationExpression
The main motivation for this is being able to write simpler assertions 
and get better error messages in unit tests.
Split off from D70394.

Revert "gn build: (manually) try to merge 1689ad27af"
This reverts commit e4ec2ecf6d4768d681a89263c0a4d29a7b7761ad. 1689ad27af
was reverted as well.

[clangd] Fix ps4 buildbot failure.
dynamic_cast on ps4 buildbot seems relying on rtti flag which is off by 
default. Remove the dynamic_cast in the tests.

[clangd] More sensible output for constructors/destructors in hover.
Summary: Previously: both had type void() and return type void. Now:
neither have a type. Constructors return T, destructors return void.
Reviewers: hokein
Subscribers: merge_guards_bot, ilya-biryukov, MaskRay, jkorous,
arphaman, kadircet, usaxena95, cfe-commits
Tags: #clang
Differential Revision: https://reviews.llvm.org/D70317

Mark PR44037 tests as XFAIL on AArch64 Linux dwo
These tests are failing with various assertion failures, but they all 
throw the following error message first:
error: a.out 0x0000002d: adding range [0x14-0x24) which has a base that 
is less than the function's low PC 0x40060c.
See llvm.org/pr44037.
Differential Revision: https://reviews.llvm.org/D70381

[clangd] Fix hover 'local scope' to include class template params
Summary: Fixes the last part of
https://github.com/clangd/clangd/issues/76
Reviewers: kadircet
Subscribers: ilya-biryukov, MaskRay, jkorous, arphaman, usaxena95,
cfe-commits
Tags: #clang
Differential Revision: https://reviews.llvm.org/D70325

[kate] Add various missing keywords
Patch by Pedro Olsen Ferreira.

gn build: Merge 39285a0f02c

gn build: Merge c0fc29c4684

[libunwind] Adjust the signal_frame test for Arm
Summary: This patch adjusts the signal_frame.pass.cpp to pass on Arm
targets:
* When Arm EHABI is used the unwinder does not use DWARF, hence the
 DWARF-specific check unw_is_signal_frame() must be disabled.
* Certain C libraries don't include EH tables, so the unwinder must
 not try to step out of main(). The patch moves the test code out of
 main() into a separate function to avoid this.
Reviewers: saugustine, ostannard, phosek, jfb, mclow.lists
Reviewed By: saugustine
Subscribers: dexonsmith, aprantl, kristof.beyls, christof,
libcxx-commits, pbarrio, labrinea
Tags: #libc
Differential Revision: https://reviews.llvm.org/D70397

[ThinLTO] Make ValueInfo::operator bool() explicit
Differential revision: https://reviews.llvm.org/D70383

[RISCV] Support mutilib in baremetal environment
Currently only support the set of multilibs same to riscv-gnu-toolchain.
Reviewers: espindola, asb, kito-cheng, lenary
Reviewed By: lenary
Differential Revision: https://reviews.llvm.org/D67508

[DependenceAnalysis] Dependecies for loads marked with "ivnariant.load"
should not be shared with general accesses. Fix for
https://bugs.llvm.org/show_bug.cgi?id=42151
Summary: Dependence anlysis has a mechanism to cache results. Thus for
particular memory access the cache keep track of side effects in basic
blocks. The problem is that for invariant loads dependepce analysis
legally ignores many dependencies due to a special semantic rules for
such loads. But later results calculated for invariant load retrived
from the cache for general case acceses. As a result we have wrong
dependence information causing GVN to do illegal transformation. Fixes,
T42151.
Proposed solution is to disable caching of invariant loads. I think such
loads a pretty rare and it doesn't make sense to extend caching
mechanism for them.
Reviewers: reames, chandlerc, skatkov, morisset, jdoerfert
Reviewed By: reames
Subscribers: hiraditya, test, jdoerfert, lebedev.ri, llvm-commits
Tags: #llvm
Differential Revision: https://reviews.llvm.org/D64405

[clang-tidy] Added DefaultOperatorNewCheck.
Summary: Added new checker 'cert-default-operator-new' that checks for 
CERT rule MEM57-CPP. Simple version.
Reviewers: aaron.ballman, alexfh, JonasToth, lebedev.ri
Reviewed By: aaron.ballman
Subscribers: hiraditya, martong, mehdi_amini, mgorny, inglorion,
xazax.hun, dkrupp, steven_wu, dexonsmith, Szelethus, gamesh411,
cfe-commits
Tags: #clang
Differential Revision: https://reviews.llvm.org/D67545

gn build: Merge e8a4c74f115

[mips] Joint MipsMemSimmXXXAsmOperand into the single template class.
NFC

Fix PR44001: assert failure in getFunctionLocalOffsetAfterInsn
Summary: Assert in getFunctionLocalOffsetAfterInsn() fails when
processing a call MachineInstr inside a bundle and compiling with debug
info. This is because labels are added by DwarfDebug::beginInstruction()
which is called for each top-level MI by EmitFunctionBody()'s for-loop
iteration but constructCallSiteEntryDIEs() which calls 
getFunctionLocalOffsetAfterInsn() iterates over all MIs.
This commit modifies constructCallSiteEntryDIEs() to get the associated 
bundle MI for call MIs inside a bundle and use that to when calling 
getFunctionLocalOffsetAfterInsn() and getLabelAfterInsn(). It also skips 
loop iterations for bundle MIs since the loop statements are concerned 
with debug info for each physical instructions and bundles represent a 
group of instructions. It also fix the comment about PCAddr since the 
code is getting the return address and not the call address.
Reviewers: dstenb, vsk, aprantl, djtodoro, dblaikie, NikolaPrica
Subscribers: hiraditya, llvm-commits
Tags: #llvm
Differential Revision: https://reviews.llvm.org/D70293

[lldb] Remove ClangExpressionDeclMap::ResolveUnknownTypes
Summary: This is some really shady code. It's supposed to kick in after
an expression already failed and then try to look up "unknown types"
that for some undocumented reason can't be resolved during/before
parsing. Beside the fact that we never mark any type as `EVUnknownType`
in either swift-lldb or lldb (which means this code is unreachable), 
this code doesn't even make the expression evaluation succeed if if
would ever be executed but instead seems to try to load more debug info
that maybe any following expression evaluations might succeed.
This patch removes ClangExpressionDeclMap::ResolveUnknownTypes and the
related data structures/checks/calls.
Reviewers: davide
Reviewed By: davide
Subscribers: aprantl, abidh, JDevlieghere, lldb-commits
Tags: #lldb
Differential Revision: https://reviews.llvm.org/D70388

[X86][SSE] Remove XFormVExtractWithShuffleIntoLoad to prevent
legalization infinite loops (PR43971)
As detailed in PR43971/D70267, the use of
XFormVExtractWithShuffleIntoLoad causes issues where we end up in
infinite loops of extract(targetshuffle(vecload)) ->
extract(shuffle(vecload)) -> extract(vecload) ->
extract(targetshuffle(vecload)), there are just too many legalization
checks at every stage that we can't guarantee that
extract(shuffle(vecload)) -> scalarload can occur.
At the moment we see a number of minor regressions as we don't fold
extract(shuffle(vecload)) -> scalarload before legal ops, these can be
addressed in future patches and extension of X86ISelLowering's
combineExtractWithShuffle.

[llvm-objdump] Print relocation addends in hexadecimal
Summary: Matches GNU objdump. Makes debugging easier for me as I'm
working out addresses from symbol+addend, so it would be good to be
calculating in a single format.
Reviewers: MaskRay, grimar, jhenderson, bd1976llvm
Reviewed By: jhenderson
Subscribers: sdardis, jrtc27, atanasyan, rupprecht, seiya, llvm-commits
Tags: #llvm
Differential Revision: https://reviews.llvm.org/D69997

Revert "[clang-tidy] Fix readability-redundant-string-init for
c++17/c++2a"
This reverts commit 06f3dabe4a2e85a32ade27c0769b6084c828a206.

Revert "[clang-tidy] modernize-use-override new option
AllowOverrideAndFinal"
This reverts commit 50e99563fb0459f5160572eef3c4e6062b8ad3f2.

[clang-tidy] Fix readability-redundant-string-init for c++17/c++2a
Summary:
`readability-redundant-string-init` was one of several clang-tidy checks
documented as failing for C++17. (The failure mode in C++17 is that it
changes `std::string Name = ""`; to `std::string Name = Name;`, which
actually compiles but crashes at run-time.)
Analyzing the AST with `clang -Xclang -ast-dump` showed that the outer
`CXXConstructExprs` that previously held the correct SourceRange were
being elided in C++17/2a, but the containing `VarDecl` expressions still
had all the relevant information. So this patch changes the fix to get
its source ranges from `VarDecl`.
It adds one test `std::string g = "u", h = "", i = "uuu", j = "", k;` to
confirm proper warnings and fixit replacements in a single `DeclStmt`
where some strings require replacement and others don't. The
readability-redundant-string-init.cpp and
readability-redundant-string-init-msvc.cpp tests now pass for
C++11/14/17/2a.
Reviewers: gribozavr, etienneb, alexfh, hokein, aaron.ballman,
gribozavr2
Patch by: poelmanc
Subscribers: NoQ, MyDeveloperDay, Eugene.Zelenko, dylanmckay,
cfe-commits
Tags: #clang, #clang-tools-extra
Differential Revision: https://reviews.llvm.org/D69238

[clang-tidy] modernize-use-override new option AllowOverrideAndFinal
Summary: In addition to adding `override` wherever possible,
clang-tidy's `modernize-use-override` nicely removes `virtual` when
`override` or `final` is specified, and further removes override when
final is specified. While this is great default behavior, when code
needs to be compiled with gcc at high warning levels that include `gcc
-Wsuggest-override` or `gcc -Werror=suggest-override`, clang-tidy's
removal of the redundant `override` keyword causes gcc to emit a warning
or error. This discrepancy / conflict has been noted by others including
a comment on Stack Overflow and by Mozilla's Firefox developers.
This patch adds an AllowOverrideAndFinal option defaulting to 0 - thus
preserving current behavior - that when enabled allows both `override`
and `final` to co-exist, while still fixing all other issues.
The patch includes a test file verifying all combinations of
virtual/override/final, and mentions the new option in the release
notes.
Reviewers: alexfh, djasper, JonasToth
Patch by: poelmanc
Subscribers: JonasToth, cfe-commits
Tags: #clang
Differential Revision: https://reviews.llvm.org/D70165

[lldb] Also test Get[De]mangledName of SBType in
TestSBTypeClassMembers.py
I just used the mangled names as this test is anyway a Darwin-only
ObjC++ test. We probably should also test this on other platforms but
that will be another commit as we need to untangle the ObjC and C++
parts first.

[ThinLTO] Simplify code. NFC

Revert "[RISCV] Support mutilib in baremetal environment"
This reverts commit b6d7bbfa004310777cd41448ffc377aea082fc8c. 
Driver/riscv64-toolchain.c fails on Windows.

[PowerPC] Regenerate vsx_insert_extract_le.ll tests

[ARM] Regenerate vector lane store tests

[NFC][X86] Fixup comment in CodeGen/X86/cmov.ll
As noted in post-commit review for 
https://reviews.llvm.org/D59035#inline-631659