SuccessChanges

Summary

  1. [mlir] Remove some rarely used OpState members and use Operation members instead. (details)
  2. [clang-format] [PR19056] Add support for access modifiers indentation (details)
  3. [clang][NFC] Extract Target and AuxTarget creation in CompilerInstance to new function (details)
  4. [Basic] Fix Wreturn-type gcc warning (NFC) (details)
  5. [Test] Add one more test with corner cases for non-wrapping IVs (details)
  6. [Sema] Fix MSVC "attribute is not recognized" warning (NFC) (details)
Commit 0b05908feb0117dcfa18485a6c9df5229e32bd7a by csigg
[mlir] Remove some rarely used OpState members and use Operation members instead.

Skipping the deprecation dance here.

Reviewed By: rriddle

Differential Revision: https://reviews.llvm.org/D97494
The file was modifiedmlir/lib/IR/BuiltinDialect.cpp
The file was modifiedmlir/include/mlir/IR/OpDefinition.h
The file was modifiedmlir/include/mlir/IR/BuiltinOps.td
Commit 2a42c759ae7bb09dd448d188138f310d014fcab6 by marek.kurdej
[clang-format] [PR19056] Add support for access modifiers indentation

Adds support for coding styles that make a separate indentation level for access modifiers, such as Code::Blocks or QtCreator.

The new option, `IndentAccessModifiers`, if enabled, forces the content inside classes, structs and unions (“records”) to be indented twice while removing a level for access modifiers. The value of `AccessModifierOffset` is disregarded in this case, aiming towards an ease of use.

======
The PR (https://bugs.llvm.org/show_bug.cgi?id=19056) had an implementation attempt by @MyDeveloperDay already (https://reviews.llvm.org/D60225) but I've decided to start from scratch. They differ in functionality, chosen approaches, and even the option name. The code tries to re-use the existing functionality to achieve this behavior, limiting possibility of breaking something else.

Reviewed By: MyDeveloperDay, curdeius, HazardyKnusperkeks

Differential Revision: https://reviews.llvm.org/D94661
The file was modifiedclang/lib/Format/UnwrappedLineFormatter.cpp
The file was modifiedclang/unittests/Format/FormatTest.cpp
The file was modifiedclang/lib/Format/Format.cpp
The file was modifiedclang/lib/Format/UnwrappedLineParser.cpp
The file was modifiedclang/docs/ReleaseNotes.rst
The file was modifiedclang/lib/Format/UnwrappedLineParser.h
The file was modifiedclang/docs/ClangFormatStyleOptions.rst
The file was modifiedclang/include/clang/Format/Format.h
Commit d412dbe388819dd68bbe4a3967783fdf80400860 by sam.mccall
[clang][NFC] Extract Target and AuxTarget creation in CompilerInstance to new function

As @sammccall mentioned in [[ https://reviews.llvm.org/D97109 | D97109 ]], I've extract the logic of creating Target and AuxTarget into a new function called `createTargetAndAuxTarget`.

Since there are many similar code in clang or other related tools, consolidating them into a single function may help others to maintain the logic handling target related things.

Reviewed By: sammccall

Differential Revision: https://reviews.llvm.org/D97493
The file was modifiedclang/include/clang/Frontend/CompilerInstance.h
The file was modifiedclang/lib/Frontend/CompilerInstance.cpp
Commit d5e0868e5e321e2a2f3bf73599ae9239c5aaa0c9 by nullptr.cpp
[Basic] Fix Wreturn-type gcc warning (NFC)
The file was modifiedclang/include/clang/Basic/Diagnostic.h
Commit cb2bc9aad5de91cc5851aa707c39a68cfae65f0f by mkazantsev
[Test] Add one more test with corner cases for non-wrapping IVs
The file was addedllvm/test/CodeGen/X86/overflowing-iv.ll
Commit e9475a276267f1bc74d9624fc797c7a754b5b90b by nullptr.cpp
[Sema] Fix MSVC "attribute is not recognized" warning (NFC)

MSVC warning:
```
\llvm-project\clang\lib\Sema\SemaChecking.cpp(10323): warning C5030: attribute 'clang::fallthrough' is not recognized
```
The file was modifiedclang/lib/Sema/SemaChecking.cpp