Changes

Summary

  1. [hwasan] Do not use short granule tags as poison tags. (details)
  2. [hwasan] Improve report for addresses within regions. (details)
  3. [mlir] Enable delayed registration of attribute/operation/type interfaces (details)
  4. [lldb] Set return object failed status even if error string is empty (details)
  5. [lldb] Remove redundant calls to set eReturnStatusFailed (details)
  6. [mlir] define a customized DEBUG_TYPE in InterfaceSupport.h (details)
  7. [X86] Add test showing binary differences with -x86-pad-for-align. (details)
  8. [libc] Generate one benchmark per implementation (details)
  9. [X86] Check using default in test added in 0bd5bbb31e0345ae. (details)
  10. [mlir][linalg] Purge linalg.indexed_generic. (details)
  11. [X86] combineSelect - refactor MIN/MAX detection code to make it easier to add additional select(setcc,x,y) folds. NFCI. (details)
  12. [mlir] Split things dependent on LLVM_DEBUG into a .cpp file (details)
  13. [FuncSpec] Precommit test: don't specialise funcs with NoDuplicate instrs. NFC. (details)
  14. [lldb] Remove redundant calls to set eReturnStatusFailed (details)
  15. [mlir] Remove linalg.indexed_generic forward decl. (details)
Commit 18070723ef5cfd7d58bc296fedb67b5e3a88908f by fmayer
[hwasan] Do not use short granule tags as poison tags.

Short granule tags as poison cause a UaF to read the referenced
memory to retrieve the tag, and means we do not detect the UaF
if the last granule's tag is still around.

This only increases the change of not catching a UaF from
0.39 % (1 / 256) to 0.42 % (1 / (256 - 17)).

Reviewed By: eugenis

Differential Revision: https://reviews.llvm.org/D104304
The file was modifiedcompiler-rt/lib/hwasan/hwasan_allocator.cpp
Commit ccc0f777f6967c557ba066070f40e5fac9e0127d by fmayer
[hwasan] Improve report for addresses within regions.

Before: ADDR is located -320 bytes to the right of 1072-byte region
After: ADDR is located 752 bytes inside 1072-byte region

Reviewed By: eugenis, walli99

Differential Revision: https://reviews.llvm.org/D104412
The file was addedcompiler-rt/test/hwasan/TestCases/heap-buffer-overflow-into.c
The file was modifiedcompiler-rt/lib/hwasan/hwasan_report.cpp
Commit d7e891213444e2990397c623fb0250a470421fce by zinenko
[mlir] Enable delayed registration of attribute/operation/type interfaces

This functionality is similar to delayed registration of dialect interfaces. It
allows external interface models to be registered before the dialect containing
the attribute/operation/type interface is loaded, or even before the context is
created.

Reviewed By: rriddle

Differential Revision: https://reviews.llvm.org/D104397
The file was modifiedmlir/lib/IR/Dialect.cpp
The file was modifiedmlir/include/mlir/IR/AttributeSupport.h
The file was modifiedmlir/include/mlir/IR/TypeSupport.h
The file was modifiedmlir/lib/IR/MLIRContext.cpp
The file was modifiedmlir/include/mlir/IR/Dialect.h
The file was modifiedmlir/unittests/IR/InterfaceAttachmentTest.cpp
The file was modifiedmlir/include/mlir/Support/InterfaceSupport.h
Commit 983ed1b58ef9d0f97c9cec2876f631e47609d437 by david.spickett
[lldb] Set return object failed status even if error string is empty

The idea is now that AppendError<...> will set eReturnStatusFailed
for you so you don't have to call SetStatus again.

Previously if the error message was empty, the status wouldn't
be set.

I don't think there are any sitautions where the message is in
fact empty but it potentially could be depending on where
we get the string from.

So let's set the status up front then return early if the message is empty.

Reviewed By: teemperor

Differential Revision: https://reviews.llvm.org/D104380
The file was modifiedlldb/source/Interpreter/CommandReturnObject.cpp
Commit 7a580f3c28cf47a7e489faa1fc1ab7b88d9a5dbd by david.spickett
[lldb] Remove redundant calls to set eReturnStatusFailed

Since https://reviews.llvm.org/D103701 AppendError<...>
sets this for you.

This change includes all of the non-command uses.

Some uses remain where it's either tricky to reason about
the logic, or they aren't paired with AppendError calls.

Reviewed By: teemperor

Differential Revision: https://reviews.llvm.org/D104379
The file was modifiedlldb/source/Interpreter/CommandAlias.cpp
The file was modifiedlldb/source/Plugins/StructuredData/DarwinLog/StructuredDataDarwinLog.cpp
The file was modifiedlldb/source/Interpreter/CommandInterpreter.cpp
The file was modifiedlldb/source/Breakpoint/BreakpointIDList.cpp
The file was modifiedlldb/source/Plugins/LanguageRuntime/RenderScript/RenderScriptRuntime/RenderScriptRuntime.cpp
The file was modifiedlldb/source/Plugins/Process/MacOSX-Kernel/ProcessKDP.cpp
The file was modifiedlldb/source/Plugins/Process/gdb-remote/ProcessGDBRemote.cpp
The file was modifiedlldb/source/Interpreter/ScriptInterpreter.cpp
The file was modifiedlldb/source/API/SBCommandInterpreter.cpp
The file was modifiedlldb/source/Interpreter/Options.cpp
The file was modifiedlldb/source/Plugins/Process/minidump/ProcessMinidump.cpp
Commit 6b6338195c1b1a32a62adb37204022c1760eb899 by zinenko
[mlir] define a customized DEBUG_TYPE in InterfaceSupport.h
The file was modifiedmlir/include/mlir/Support/InterfaceSupport.h
Commit 0bd5bbb31e0345aed8d029d70a4197aed53a3cd5 by flo
[X86] Add test showing binary differences with -x86-pad-for-align.

This patch adds a test case showing how a single extra .loc can cause
binary differences when using -x86-pad-for-align=true.

The issue has been discussed in D94542, PR42138, PR48742.
The file was addedllvm/test/MC/X86/pad-for-align-debug.s
The file was addedllvm/test/MC/X86/Inputs/pad-align-with-debug.s
The file was addedllvm/test/MC/X86/Inputs/pad-align-without-debug.s
Commit 8d64ed854449467a3a5fc4450c71a4525a24c4be by gchatelet
[libc] Generate one benchmark per implementation

We now generate as many benchmarks as there are implementations.

Differential Revision: https://reviews.llvm.org/D102156
The file was modifiedlibc/benchmarks/CMakeLists.txt
The file was modifiedlibc/benchmarks/LibcMemoryBenchmarkMain.cpp
Commit aa6e8e9572d54d8fdcd6e8789ea7076640011066 by flo
[X86] Check using default in test added in 0bd5bbb31e0345ae.

Make sure llvm-mc is invariant with respect to debug locations in the
test (checks update to use the -x86-pad-for-align default value)
The file was modifiedllvm/test/MC/X86/pad-for-align-debug.s
Commit 5b3cb31edbcf99ef15c2de2d29ad0ff9927ba136 by pifon
[mlir][linalg] Purge linalg.indexed_generic.

Differential Revision: https://reviews.llvm.org/D104449
The file was modifiedmlir/include/mlir/Dialect/Linalg/IR/LinalgStructuredOps.td
The file was modifiedmlir/lib/Dialect/Linalg/Transforms/Generalization.cpp
The file was modifiedmlir/lib/Dialect/Linalg/Transforms/Loops.cpp
The file was modifiedmlir/lib/Dialect/Linalg/Transforms/FusionOnTensors.cpp
The file was modifiedmlir/lib/Conversion/LinalgToStandard/LinalgToStandard.cpp
The file was modifiedmlir/test/Dialect/Linalg/invalid.mlir
The file was modifiedmlir/test/Dialect/Linalg/canonicalize-duplicate-inputs.mlir
The file was modifiedmlir/lib/Dialect/Linalg/IR/LinalgOps.cpp
The file was modifiedmlir/test/Dialect/Linalg/roundtrip.mlir
The file was modifiedmlir/lib/Dialect/Linalg/Transforms/Bufferize.cpp
The file was modifiedmlir/lib/Dialect/Linalg/Transforms/Tiling.cpp
The file was modifiedmlir/test/Dialect/Linalg/canonicalize.mlir
The file was modifiedmlir/lib/Dialect/Linalg/Transforms/Fusion.cpp
Commit cdb4fcf9a19ca35b50754791f3986337046d9406 by llvm-dev
[X86] combineSelect - refactor MIN/MAX detection code to make it easier to add additional select(setcc,x,y) folds. NFCI.

I need to add some additional handling to address some of the regressions from D101074
The file was modifiedllvm/lib/Target/X86/X86ISelLowering.cpp
Commit c878d03d60fc91ecad661f4435ce70bf276f3bdb by benny.kra
[mlir] Split things dependent on LLVM_DEBUG into a .cpp file

LLVM_DEBUG in headers is awkward, better avoid it. DEBUG_TYPE in a
header results in a lot of macro redefinition warnings.
The file was modifiedmlir/lib/Support/CMakeLists.txt
The file was addedmlir/lib/Support/InterfaceSupport.cpp
The file was modifiedmlir/include/mlir/Support/InterfaceSupport.h
Commit 3f596842e3d25009c4d62c75e5b24b515bde8e93 by sjoerd.meijer
[FuncSpec] Precommit test: don't specialise funcs with NoDuplicate instrs. NFC.
The file was addedllvm/test/Transforms/FunctionSpecialization/function-specialization-nodup2.ll
Commit eaf60a4411f79a1addfa6c5d8ddf4b47e082881e by david.spickett
[lldb] Remove redundant calls to set eReturnStatusFailed

This is part 2, covering the commands source.

Some uses remain where it's tricky to see what the
logic is or they are not used with AppendError.

Reviewed By: teemperor

Differential Revision: https://reviews.llvm.org/D104448
The file was modifiedlldb/source/Commands/CommandObjectScript.cpp
The file was modifiedlldb/source/Commands/CommandObjectPlugin.cpp
The file was modifiedlldb/source/Commands/CommandObjectStats.cpp
The file was modifiedlldb/source/Commands/CommandObjectType.cpp
The file was modifiedlldb/source/Commands/CommandObjectWatchpoint.cpp
The file was modifiedlldb/source/Commands/CommandObjectReproducer.cpp
The file was modifiedlldb/source/Commands/CommandObjectCommands.cpp
The file was modifiedlldb/source/Commands/CommandObjectLog.cpp
The file was modifiedlldb/source/Commands/CommandObjectSource.cpp
The file was modifiedlldb/source/Commands/CommandObjectThreadUtil.cpp
The file was modifiedlldb/source/Commands/CommandObjectMemory.cpp
The file was modifiedlldb/source/Commands/CommandObjectExpression.cpp
The file was modifiedlldb/source/Commands/CommandObjectMultiword.cpp
The file was modifiedlldb/source/Commands/CommandObjectBreakpointCommand.cpp
The file was modifiedlldb/source/Commands/CommandObjectGUI.cpp
The file was modifiedlldb/source/Commands/CommandObjectApropos.cpp
The file was modifiedlldb/source/Commands/CommandObjectWatchpointCommand.cpp
The file was modifiedlldb/source/Commands/CommandObjectDisassemble.cpp
The file was modifiedlldb/source/Commands/CommandObjectTarget.cpp
The file was modifiedlldb/source/Commands/CommandObjectBreakpoint.cpp
The file was modifiedlldb/source/Commands/CommandObjectSettings.cpp
The file was modifiedlldb/source/Commands/CommandObjectQuit.cpp
The file was modifiedlldb/source/Commands/CommandObjectThread.cpp
The file was modifiedlldb/source/Commands/CommandObjectProcess.cpp
The file was modifiedlldb/source/Commands/CommandObjectFrame.cpp
The file was modifiedlldb/source/Commands/CommandObjectPlatform.cpp
The file was modifiedlldb/source/Commands/CommandObjectHelp.cpp
The file was modifiedlldb/source/Commands/CommandObjectRegister.cpp
The file was modifiedlldb/source/Commands/CommandObjectTrace.cpp
Commit 7cddf56d608f07b8e49f7e2eeb4a20082611adb6 by pifon
[mlir] Remove linalg.indexed_generic forward decl.
The file was modifiedmlir/include/mlir/Dialect/Linalg/IR/LinalgOps.h