UnstableChanges

Summary

  1. [lld] Silence compiler warnings by removing always true/false comparisons (details)
  2. [SCEV] Use ListSeparator (NFC) (details)
  3. [llvm] Fix header guards (NFC) (details)
  4. [CodeGen] Use range-based for loops (NFC) (details)
  5. [SampleFDO] Fix MSVC "namespace uses itself" warning (NFC) (details)
  6. tsan: don't leave unmapped hole in non-app memory (details)
  7. [vim] Add initial syntax definition for .mir files (details)
  8. [vim] Highlight most common MIR syntax not in LLVM IR (details)
  9. [OpenMP] Fix a warning on an unused variable (details)
  10. [clang][Frontend] Fix a crash in DiagnosticRenderer. (details)
  11. [sanitizers] Pass CMAKE_C_FLAGS into TSan buildgo script (details)
  12. [MachineSink] Add a loop sink limit (details)
Commit caff023b77995166c8f335ace3064c04f677cb9c by mikael.holmen
[lld] Silence compiler warnings by removing always true/false comparisons

type is an uint8_t so
type >= 0
is always true and
type < 0
is always false.
The file was modifiedlld/MachO/Arch/X86_64.cpp
The file was modifiedlld/MachO/Arch/ARM64.cpp
Commit df35a183d7d447aa4f452ec1c56f9f04d4c02ee7 by kazu
[SCEV] Use ListSeparator (NFC)
The file was modifiedllvm/lib/Analysis/ScalarEvolution.cpp
Commit 2620459baabee93b7e328399b742848ff87ac515 by kazu
[llvm] Fix header guards (NFC)

Identified with llvm-header-guard.
The file was modifiedllvm/include/llvm/Support/SHA256.h
Commit 3279943adf410d43082c14c0f0d9a7bc499004d1 by kazu
[CodeGen] Use range-based for loops (NFC)
The file was modifiedllvm/lib/CodeGen/MachinePipeliner.cpp
The file was modifiedllvm/lib/CodeGen/MachineScheduler.cpp
Commit a23e6b321ca623b83252f8b1e06a2ad4fc441f89 by nullptr.cpp
[SampleFDO] Fix MSVC "namespace uses itself" warning (NFC)

MSVC warning:
```
SampleProfileLoaderBaseImpl.h(41): warning C4515: 'llvm': namespace uses itself
```
The file was modifiedllvm/include/llvm/Transforms/Utils/SampleProfileLoaderBaseImpl.h
Commit 0984b8de0b0d5d178a8e6e5de1eb89f29493a89e by dvyukov
tsan: don't leave unmapped hole in non-app memory

If an app mmaps lots of memory, a user mmap may end up
in the tsan region for traces. Shadow for this range
overlaps with shadow for other user regions.
This causes havok: from false positives to crashes.
Don't leave unmapped holes in the traces region.

Reviewed-in: https://reviews.llvm.org/D96697
The file was modifiedcompiler-rt/lib/tsan/rtl/tsan_interceptors_posix.cpp
The file was modifiedcompiler-rt/lib/tsan/rtl/tsan_rtl.cpp
The file was addedcompiler-rt/test/tsan/mmap_lots.cpp
Commit c6a96df3752065a9411e517942e2cd928e7af82e by code
[vim] Add initial syntax definition for .mir files

This initial definition handles the yaml container and the embedding of
the inner IRs. As a stopgap, this reuses the LLVM IR syntax highlighting
for the MIR function bodies--even though it's not technically correct,
it produces decent highlighting for a first pass.

Reviewed By: dblaikie

Differential Revision: https://reviews.llvm.org/D95552
The file was addedllvm/utils/vim/ftdetect/mir.vim
The file was addedllvm/utils/vim/syntax/machine-ir.vim
The file was addedllvm/utils/vim/ftplugin/mir.vim
The file was addedllvm/utils/vim/syntax/mir.vim
Commit ed7638a34d32ee427f75c6ca1ef0a9e8661b847d by code
[vim] Highlight most common MIR syntax not in LLVM IR

This adds highlighting for MIR instruction opcodes, physical registers,
and MIR types.

Reviewed By: dblaikie

Differential Revision: https://reviews.llvm.org/D95553
The file was modifiedllvm/utils/vim/syntax/machine-ir.vim
Commit ab8a62057384e1bbfd528a4012cd898511c83b02 by kazu
[OpenMP] Fix a warning on an unused variable
The file was modifiedclang/lib/Sema/SemaOpenMP.cpp
Commit 085dcc82178f94b99783c5730e70a953e4105c00 by 1.int32
[clang][Frontend] Fix a crash in DiagnosticRenderer.

Displaying the problem range could crash if the begin and end of a
range is in different files or macros. After the change such range
is displayed only as the beginning location.

There is a bug for this problem:
https://bugs.llvm.org/show_bug.cgi?id=46540

Reviewed By: steakhal

Differential Revision: https://reviews.llvm.org/D95860
The file was addedclang/test/Analysis/copypaste/Inputs/clone-begin-end-different-file-begin-macro-1.inc
The file was addedclang/test/Analysis/copypaste/clone-begin-end-different-file.cpp
The file was addedclang/test/Frontend/crash-diagnostic-renderer.cpp
The file was addedclang/test/Analysis/copypaste/Inputs/clone-begin-end-different-file-begin-macro-2.inc
The file was addedclang/test/Analysis/copypaste/Inputs/clone-begin-end-different-file-begin-1.inc
The file was addedclang/test/Analysis/copypaste/Inputs/clone-begin-end-different-file-begin-2.inc
The file was addedclang/test/Analysis/copypaste/Inputs/clone-begin-end-different-file-end-macro.inc
The file was modifiedclang/lib/Frontend/DiagnosticRenderer.cpp
The file was addedclang/test/Analysis/copypaste/Inputs/clone-begin-end-different-file-end.inc
Commit ac6c13bfc49f2d67a77144c839ecf49e48cb994c by protze
[sanitizers] Pass CMAKE_C_FLAGS into TSan buildgo script

When compiling with ccache, compiler commands get split into smaller steps
and clang's default -Wunused-command-line-argument complains about unused
include directory arguments. In combination -Werror, compilation aborts.

This patch passes the CMAKE_C_FLAGS into the build script. Configuring with
-DCMAKE_C_FLAGS=-Wno-unused-command-line-argument allows successful testing.

Differential Revision: https://reviews.llvm.org/D96762
The file was modifiedcompiler-rt/lib/tsan/go/buildgo.sh
The file was modifiedcompiler-rt/lib/tsan/CMakeLists.txt
Commit 7f3170ec1943a25a09beb0a989ebc83c9c238f97 by sjoerd.meijer
[MachineSink] Add a loop sink limit

To make sure compile-times don't regress, add an option to restrict the number
of instructions considered for sinking as alias analysis can be expensive and
for the same reason also skip large blocks.

Differential Revision: https://reviews.llvm.org/D96485
The file was modifiedllvm/lib/CodeGen/MachineSink.cpp
The file was addedllvm/test/CodeGen/AArch64/loop-sink-limit.mir