SuccessChanges

Summary

  1. [clang] Print 32 candidates on the first failure, with -fshow-overloads=best. (details)
  2. [debug-info] refactor emitDwarfUnitLength (details)
  3. Revert [MLIR][TOSA] Added Tosa to Standard/SCF Lowerings (const, if, while) (details)
  4. Fix signed-compare warning. (details)
  5. [flang][fir] Add array value operations. (details)
  6. [TableGen] Use ListSeparator (NFC) (details)
  7. [Scalar] Use range-based for loops (NFC) (details)
  8. [llvm-dwarfdump] StringMap -> MapVector to make iteration order stable (details)
  9. [X86] Use correct padding when in 16-bit mode (details)
Commit c90dac27e94ec354a3e8919556ac5bc89b62c731 by justin.lebar
[clang] Print 32 candidates on the first failure, with -fshow-overloads=best.

Previously, -fshow-overloads=best always showed 4 candidates.  The
problem is, when this isn't enough, you're kind of up a creek; the only
option available is to recompile with different flags.  This can be
quite expensive!

With this change, we try to strike a compromise.  The *first* error with
more than 4 candidates will show up to 32 candidates.  All further
errors continue to show only 4 candidates.

The hope is that this way, users will have *some chance* of making
forward progress, without facing unbounded amounts of error spam.

Differential Revision: https://reviews.llvm.org/D95754
The file was modifiedclang/lib/Sema/SemaOverload.cpp
The file was modifiedclang/test/SemaCXX/ambiguous-conversion-show-overload.cpp
The file was modifiedclang/lib/Sema/Sema.cpp
The file was modifiedclang/include/clang/Basic/Diagnostic.h
The file was modifiedclang/test/SemaCXX/overloaded-builtin-operators.cpp
Commit d39bc36b1be72a16dcc4087dce547714ded324a9 by czhengsz
[debug-info] refactor emitDwarfUnitLength

remove `Hi` `Lo` argument from `emitDwarfUnitLength`, so we
can make caller of emitDwarfUnitLength easier.

Reviewed By: MaskRay, dblaikie, ikudrin

Differential Revision: https://reviews.llvm.org/D96409
The file was modifiedllvm/lib/CodeGen/AsmPrinter/AccelTable.cpp
The file was modifiedllvm/unittests/CodeGen/TestAsmPrinter.h
The file was modifiedllvm/lib/CodeGen/AsmPrinter/DwarfDebug.cpp
The file was modifiedllvm/lib/MC/MCStreamer.cpp
The file was modifiedllvm/include/llvm/CodeGen/AsmPrinter.h
The file was modifiedllvm/include/llvm/MC/MCStreamer.h
The file was modifiedllvm/lib/CodeGen/AsmPrinter/AsmPrinterDwarf.cpp
The file was modifiedllvm/unittests/CodeGen/AsmPrinterDwarfTest.cpp
The file was modifiedllvm/test/DebugInfo/X86/dwarf-pubnames-split.ll
The file was modifiedllvm/lib/CodeGen/AsmPrinter/AddressPool.cpp
The file was modifiedllvm/lib/CodeGen/AsmPrinter/DwarfUnit.cpp
Commit c47aa3c8dec4ad54a79cdea57308c59f9d33b7a5 by rob.suderman
Revert [MLIR][TOSA] Added Tosa to Standard/SCF Lowerings (const, if, while)

This reverts commit a813e9be5bc91203508bde239c1a15c5b8f8c0cc.

Results in an ASAN failure due to bypassing rewriter.

Differential Revision: https://reviews.llvm.org/D97518
The file was removedmlir/lib/Conversion/TosaToSCF/TosaToSCF.cpp
The file was removedmlir/include/mlir/Conversion/TosaToSCF/TosaToSCF.h
The file was removedmlir/lib/Conversion/TosaToSCF/CMakeLists.txt
The file was removedmlir/test/Conversion/TosaToSCF/tosa-to-scf.mlir
The file was removedmlir/lib/Conversion/TosaToStandard/TosaToStandardPass.cpp
The file was modifiedmlir/lib/Conversion/CMakeLists.txt
The file was modifiedmlir/include/mlir/Conversion/Passes.h
The file was removedmlir/lib/Conversion/TosaToStandard/CMakeLists.txt
The file was removedmlir/lib/Conversion/TosaToSCF/TosaToSCFPass.cpp
The file was removedmlir/include/mlir/Conversion/TosaToStandard/TosaToStandard.h
The file was removedmlir/lib/Conversion/TosaToStandard/TosaToStandard.cpp
The file was modifiedmlir/include/mlir/Conversion/Passes.td
The file was removedmlir/test/Conversion/TosaToStandard/tosa-to-standard.mlir
The file was modifiedmlir/lib/Conversion/PassDetail.h
Commit e890fffcab8b7e95deba4269c14db9fab003a737 by justin.lebar
Fix signed-compare warning.

Introduced in my c90dac27e94ec354a3e8919556ac5bc89b62c731.
The file was modifiedclang/lib/Sema/Sema.cpp
Commit 67360decc3d4bda363c2fa2550eb1c2b876c8cf0 by eschweitz
[flang][fir] Add array value operations.

We lower expressions with rank > 0 to a set of high-level array operations.
These operations are then analyzed and refined to more primitve
operations in subsequent pass(es).

This patch upstreams these array operations and some other helper ops.

Authors: Eric Schweitz, Rajan Walia, Kiran Chandramohan, et.al.

https://github.com/flang-compiler/f18-llvm-project/pull/565

Differential Revision: https://reviews.llvm.org/D97421
The file was modifiedflang/test/Fir/fir-ops.fir
The file was modifiedflang/lib/Optimizer/Dialect/FIROps.cpp
The file was modifiedflang/include/flang/Optimizer/Dialect/FIROps.td
The file was modifiedflang/include/flang/Optimizer/Dialect/FIRType.h
The file was modifiedflang/lib/Optimizer/Dialect/FIRType.cpp
Commit edd92e018a7ba764f0e217ba8fd155ee1c12cf6a by kazu
[TableGen] Use ListSeparator (NFC)
The file was modifiedllvm/utils/TableGen/CallingConvEmitter.cpp
Commit 5fc9e309856997337dc6fdbc46ac36e37225b139 by kazu
[Scalar] Use range-based for loops (NFC)
The file was modifiedllvm/lib/Transforms/Scalar/LoopUnswitch.cpp
The file was modifiedllvm/lib/Transforms/Scalar/LICM.cpp
The file was modifiedllvm/lib/Transforms/Scalar/LoopRerollPass.cpp
The file was modifiedllvm/lib/Transforms/Scalar/LoopInterchange.cpp
The file was modifiedllvm/lib/Transforms/Scalar/DCE.cpp
The file was modifiedllvm/lib/Transforms/Scalar/LowerMatrixIntrinsics.cpp
The file was modifiedllvm/lib/Transforms/Scalar/SimpleLoopUnswitch.cpp
The file was modifiedllvm/lib/Transforms/Scalar/GVN.cpp
The file was modifiedllvm/lib/Transforms/Scalar/StructurizeCFG.cpp
The file was modifiedllvm/lib/Transforms/Scalar/NaryReassociate.cpp
Commit 599711dce58719f137b82449fc9f9dee8f9252c4 by i
[llvm-dwarfdump] StringMap -> MapVector to make iteration order stable

Exposed by D97396
The file was modifiedllvm/test/tools/llvm-dwarfdump/X86/statistics.ll
The file was modifiedllvm/tools/llvm-dwarfdump/Statistics.cpp
The file was modifiedllvm/tools/llvm-dwarfdump/llvm-dwarfdump.h
The file was modifiedllvm/test/tools/llvm-dwarfdump/X86/section_sizes_macho.test
The file was modifiedllvm/tools/llvm-dwarfdump/SectionSizes.cpp
The file was modifiedllvm/test/tools/llvm-dwarfdump/X86/section_sizes_coff.test
The file was modifiedllvm/test/tools/llvm-dwarfdump/X86/section_sizes_elf.test
Commit a9f9ceb35f8117ca2c969dfa6614412e00797d45 by isanbard
[X86] Use correct padding when in 16-bit mode

In 16-bit mode, some of the nop patterns used in 32-bit mode can end up
mangling other instructions. For instance, an aligned "movz" instruction
may have the 0x66 and 0x67 prefixes omitted, because the nop that's used
messes things up.

       xorl    %ebx, %ebx
       .p2align 4, 0x90
       movzbl  (%esi,%ebx), %ecx

Use instead nop patterns we know 16-bit mode can handle.

Differential Revision: https://reviews.llvm.org/D97268
The file was addedllvm/test/MC/X86/code16gcc-align.s
The file was modifiedllvm/lib/Target/X86/MCTargetDesc/X86AsmBackend.cpp