FailedChanges

Summary

  1. Revert "Differential Revision: https://reviews.llvm.org/D99812" (details)
  2. [libc++] Enable tests for the experimental library by default (details)
  3. [PowerPC] [GlobalISel] Implementation of formal arguments lowering in the IRTranslator for the PPC backend (details)
  4. [coro] Preserve scope line for compiler generated functions (details)
  5. [MC] Change "unexpected tokens" to "expected newline" and remove unneeded "in .xxx directive" (details)
  6. [MC] Delete unneeded MCAsmParser &Parser (details)
  7. [profile] Add -fprofile-instr-generate tests for weak definition and various linkages (details)
  8. [InstrProfiling] Delete linkage/visibility toggling for Windows (details)
  9. Recommit "Fix tmp files being left on Windows builds." with a fix for (details)
  10. Fix llvm/test/tools/llvm-dwp/X86/type_dedup_v5.test (details)
  11. [clangd] Improve resolution of static method calls in HeuristicResolver (details)
  12. [AArch64] Add regression test for missed bfi optimization. (details)
  13. Fix "control reaches end of non-void function" warnings on ppc64le (details)
  14. [clang] Fix fail of OpenMP/tile_codegen_tile_for.cpp. (details)
Commit 3e5ddb83e387281bc9b3dea8766bcc633a6fcee5 by gandhi21299
Revert "Differential Revision: https://reviews.llvm.org/D99812"

This reverts commit c729f2a48a6ef6b20554494c5630082c89c3680c.
The file was modifiedllvm/lib/Target/PowerPC/PPCISelLowering.cpp
The file was addedllvm/test/CodeGen/PowerPC/GlobalISel/irtranslator-ret.ll
The file was modifiedllvm/lib/Target/PowerPC/GISel/PPCCallLowering.cpp
The file was modifiedllvm/lib/Target/PowerPC/PPCISelLowering.h
The file was modifiedllvm/lib/Target/PowerPC/GISel/PPCCallLowering.h
The file was removedllvm/test/CodeGen/PowerPC/GlobalISel/irtranslator-args-lowering.ll
Commit 875ff8e059b73f65f5ad08d416a0a9caf0673d1a by Louis Dionne
[libc++] Enable tests for the experimental library by default

This matches the fact that we build the experimental library by default.
Otherwise, by default we'd be building the library but not testing it,
which is inconsistent.

Differential Revision: https://reviews.llvm.org/D102109
The file was modifiedlibcxx/utils/libcxx/test/params.py
The file was modifiedlibcxxabi/test/lit.site.cfg.in
The file was modifiedlibcxx/test/configs/libcxx-trunk-static.cfg.in
The file was modifiedlibunwind/test/lit.site.cfg.in
Commit 1c5ff0b03f4e5b03619f58634396b5370d61b086 by gandhi21299
[PowerPC] [GlobalISel] Implementation of formal arguments lowering in the IRTranslator for the PPC backend

Differential Revision: https://reviews.llvm.org/D99812
The file was modifiedllvm/lib/Target/PowerPC/PPCISelLowering.cpp
The file was addedllvm/test/CodeGen/PowerPC/GlobalISel/irtranslator-args-lowering.ll
The file was modifiedllvm/lib/Target/PowerPC/GISel/PPCCallLowering.cpp
The file was modifiedllvm/lib/Target/PowerPC/GISel/PPCCallLowering.h
The file was removedllvm/test/CodeGen/PowerPC/GlobalISel/irtranslator-ret.ll
The file was modifiedllvm/lib/Target/PowerPC/PPCISelLowering.h
Commit 60ce8babf77e65836d844741fbe50f297ad00781 by davelee.com
[coro] Preserve scope line for compiler generated functions

Coro-split functions with an active suspend point have their scope line set to
the line of the suspend point. However for compiler generated functions, this
results in debug info with unconventional results: a file named
`<compiler-generated>` with a non-zero line number. The convention for
`<compiler-generated>` is that the line number is zero.

This change propagates the scope line only for non-compiler generated
functions.

Differential Revision: https://reviews.llvm.org/D102412
The file was modifiedllvm/test/Transforms/Coroutines/coro-async.ll
The file was modifiedllvm/lib/Transforms/Coroutines/CoroSplit.cpp
Commit c980d93d91280a8e0a6618ece1960bb71c45d950 by i
[MC] Change "unexpected tokens" to "expected newline" and remove unneeded "in .xxx directive"
The file was modifiedllvm/lib/Target/X86/AsmParser/X86AsmParser.cpp
The file was modifiedllvm/test/MC/COFF/cv-fpo-errors.s
Commit aba67ba7840a771262ddc72e090bd653170ff85a by i
[MC] Delete unneeded MCAsmParser &Parser
The file was modifiedllvm/lib/Target/X86/AsmParser/X86AsmParser.cpp
Commit effb87dfa810a28e763f914fe3e6e984782cc846 by i
[profile] Add -fprofile-instr-generate tests for weak definition and various linkages
The file was addedcompiler-rt/test/profile/Linux/coverage-linkage-lld.cpp
The file was addedcompiler-rt/test/profile/Windows/coverage-weak-lld.cpp
The file was addedcompiler-rt/test/profile/Linux/coverage-linkage.cpp
The file was addedcompiler-rt/test/profile/Linux/coverage-weak-lld.cpp
The file was addedcompiler-rt/test/profile/Windows/coverage-linkage.cpp
The file was addedcompiler-rt/test/profile/Windows/coverage-linkage-lld.cpp
Commit 87c43f3aa99d778755c7f5420e955885f855ecad by i
[InstrProfiling] Delete linkage/visibility toggling for Windows

The linkage/visibility of `__profn_*` variables are derived
from the profiled functions.

    extern_weak => linkonce
    available_externally => linkonce_odr
    internal => private
    extern => private
    _ => unchanged

The linkage/visibility of `__profc_*`/`__profd_*` variables are derived from
`__profn_*` with linkage/visibility wrestling for Windows.

The changes can be folded to the following without changing semantics.

```
if (TT.isOSBinFormatCOFF() && !NeedComdat) {
  Linkage = GlobalValue::InternalLinkage;
  Visibility = GlobalValue::DefaultVisibility;
}
```

That said, I think we can just delete the code block.

An extern/internal function will now use private `__profc_*`/`__profd_*`
variables, instead of internal ones. This saves some symbol table entries.

A non-comdat {linkonce,weak}_odr function will now use hidden external
`__profc_*`/`__profd_*` variables instead of internal ones.  There is potential
object file size increase because such symbols need `/INCLUDE:` directives.
However such non-comdat functions are rare (note that non-comdat weak
definitions don't prevent duplicate definition error).

The behavior changes match ELF.

Reviewed By: rnk

Differential Revision: https://reviews.llvm.org/D103355
The file was modifiedllvm/test/Instrumentation/InstrProfiling/linkage.ll
The file was modifiedcompiler-rt/test/profile/Windows/coverage-weak-lld.cpp
The file was modifiedllvm/test/Instrumentation/InstrProfiling/platform.ll
The file was modifiedllvm/test/Instrumentation/InstrProfiling/profiling.ll
The file was modifiedllvm/lib/Transforms/Instrumentation/InstrProfiling.cpp
Commit 9d070b2f4889887f9ce497592ef01df7b9601a1c by akhuang
Recommit "Fix tmp files being left on Windows builds." with a fix for
incorrect std::string use. (Also remove redundant call to
RemoveFileOnSignal.)

Clang writes object files by first writing to a .tmp file and then
renaming to the final .obj name. On Windows, if a compile is killed
partway through the .tmp files don't get deleted.

Currently it seems like RemoveFileOnSignal takes care of deleting the
tmp files on Linux, but on Windows we need to call
setDeleteDisposition on tmp files so that they are deleted when
closed.

This patch switches to using TempFile to create the .tmp files we write
when creating object files, since it uses setDeleteDisposition on Windows.
This change applies to both Linux and Windows for consistency.

Differential Revision: https://reviews.llvm.org/D102876

This reverts commit 20797b129f844d4b12ffb2b12cf33baa2d42985c.
The file was modifiedclang/include/clang/Frontend/CompilerInstance.h
The file was modifiedllvm/lib/Support/Windows/Path.inc
The file was modifiedclang/lib/Frontend/CompilerInstance.cpp
The file was modifiedllvm/lib/Support/Path.cpp
Commit 2541075c22aec261e45e2c4edba65b29ed472d2e by jyknight
Fix llvm/test/tools/llvm-dwp/X86/type_dedup_v5.test

It was writing files to the source dir after
316da543af14fb4b40ef0377fe770f430745f5ea.
The file was modifiedllvm/test/tools/llvm-dwp/X86/type_dedup_v5.test
Commit f976b9997ee55a130b139efe7b6e6f3b0384016b by zeratul976
[clangd] Improve resolution of static method calls in HeuristicResolver

Differential Revision: https://reviews.llvm.org/D101741
The file was modifiedclang-tools-extra/clangd/unittests/InlayHintTests.cpp
The file was modifiedclang-tools-extra/clangd/HeuristicResolver.cpp
Commit d8b9ed72ee838145a5c48d8b6fdccd00dc200c42 by efriedma
[AArch64] Add regression test for missed bfi optimization.

(See https://reviews.llvm.org/D60358 for the transform that breaks this
case.)
The file was modifiedllvm/test/CodeGen/AArch64/bitfield-insert.ll
Commit b2c8bcbab8a44c4582632845697b9425c3200230 by yitzhakm
Fix "control reaches end of non-void function" warnings on ppc64le

Warnings can be found here: https://lab.llvm.org/buildbot/#/builders/76/builds/2640

Reviewed By: ymandel

Differential Revision: https://reviews.llvm.org/D103565
The file was modifiedclang/lib/ASTMatchers/GtestMatchers.cpp
Commit 64e5a3bbdde25af0fd9f2b9b8539e23f36c80601 by llvm-project
[clang] Fix fail of OpenMP/tile_codegen_tile_for.cpp.

Clang's version string can be customized using CLANG_VENDOR which the
test did not consider. Change the test to accept any version string.
The file was modifiedclang/test/OpenMP/tile_codegen_tile_for.cpp