Changes

Summary

  1. [tools, utils] Use StringRef::contains (NFC) (details)
  2. [flang] Fix buildbot (new warnings on old code) (details)
  3. [NFC][X86] Add MC tests for all untested VIA PadLock instructions (details)
  4. [X86] Don't add implicit REP prefix to VIA PadLock xstore (details)
Commit 4e3eebc6bd326441c11f5ecd71284d42157c302d by kazu
[tools, utils] Use StringRef::contains (NFC)
The file was modifiedllvm/utils/TableGen/X86RecognizableInstr.cpp
The file was modifiedllvm/tools/llvm-profgen/ProfileGenerator.cpp
The file was modifiedllvm/tools/llvm-profdata/llvm-profdata.cpp
The file was modifiedllvm/utils/TableGen/X86FoldTablesEmitter.cpp
The file was modifiedllvm/tools/llvm-cov/CoverageFilters.cpp
The file was modifiedllvm/tools/llvm-profgen/PerfReader.cpp
The file was modifiedllvm/utils/TableGen/AsmMatcherEmitter.cpp
Commit fc3f92a8f457d3067aeb7043e876cfa437c24e31 by pklausler
[flang] Fix buildbot (new warnings on old code)

The clang-aarch64-full-2stage buildbot is complaining about a
warning with three instances in f18 code (none modified recently).
The warning is for using the | bitwise OR operator on bool operands.

In one instance, the bitwise operator was being used instead of the
logical || operator in order to avoid short-circuting.  The fix
requires using some temporary variables.  In the other two instances,
the bitwise operator seemed more idiomatic in context, but can be
replaced without harm with the logical operator.

Pushing without review as confidence is high and nobody wants
a buildbot to stay sad for long.
The file was modifiedflang/lib/Semantics/check-declarations.cpp
The file was modifiedflang/lib/Evaluate/tools.cpp
Commit b432583d28ee99313fa834139be9535639957d76 by jrtc27
[NFC][X86] Add MC tests for all untested VIA PadLock instructions

We currently only test the encoding of xstore but none of the other
instructions, which should all have their implicit REP prefix be
verified as working.

Reviewed By: craig.topper

Differential Revision: https://reviews.llvm.org/D112354
The file was modifiedllvm/test/MC/X86/padlock.s
Commit 2d8c18fbbdd1b07ab0d36ac49ef63f4d243afb8b by jrtc27
[X86] Don't add implicit REP prefix to VIA PadLock xstore

Commit 8fa3e8fa1492 added an implicit REP prefix to all VIA PadLock
instructions, but GNU as doesn't add one to xstore, only all the others.
This resulted in a kernel panic regression in FreeBSD upon updating to
LLVM 11 (https://bugs.freebsd.org/259218) which includes the commit in
question. This partially reverts that commit.

Reviewed By: craig.topper

Differential Revision: https://reviews.llvm.org/D112355
The file was modifiedllvm/lib/Target/X86/X86InstrSystem.td
The file was modifiedllvm/test/MC/X86/padlock.s