Changes

Summary

  1. [NFC] Correct arc draft option (details)
  2. [clang-tidy] Tidy up spelling, grammar, and inconsistencies in documentation (NFC) (details)
  3. [lldb] [Host/FreeBSD] Remove unused variable (NFC) (details)
  4. [lldb] [Host/SerialPort] Fix build with GCC 7 (details)
  5. [www] Fix Ninja build instructions on Windows (details)
  6. [mlir] Add polynomial approximation for vectorized math::Rsqrt (details)
  7. [mlir][Linalg] NFC - Reorganize options nesting. (details)
  8. [SCEV] Remove computeLoadConstantCompareExitLimit() (NFCI) (details)
  9. Revert "[mlir][Linalg] NFC - Reorganize options nesting." (details)
Commit 7088da480c33955036d2e7a032a11d88157b5d17 by shivam98.tkg
[NFC] Correct arc draft option
The file was modifiedllvm/docs/Phabricator.rst
Commit 5de69e16ea9ab916401f4a8390fff91f18bbba2a by kazu
[clang-tidy] Tidy up spelling, grammar, and inconsistencies in documentation (NFC)

Differential Revision: https://reviews.llvm.org/D112356
The file was modifiedclang-tools-extra/docs/clang-tidy/checks/readability-identifier-naming.rst
The file was modifiedclang-tools-extra/docs/clang-tidy/checks/cert-oop11-cpp.rst
The file was modifiedclang-tools-extra/docs/clang-tidy/checks/cert-dcl21-cpp.rst
The file was modifiedclang-tools-extra/docs/clang-tidy/checks/abseil-string-find-str-contains.rst
The file was modifiedclang-tools-extra/docs/clang-tidy/checks/readability-function-cognitive-complexity.rst
The file was modifiedclang-tools-extra/docs/clang-tidy/checks/bugprone-misplaced-operator-in-strlen-in-alloc.rst
The file was modifiedclang-tools-extra/docs/clang-tidy/checks/openmp-use-default-none.rst
The file was modifiedclang-tools-extra/docs/clang-tidy/checks/bugprone-not-null-terminated-result.rst
The file was modifiedclang-tools-extra/docs/clang-tidy/checks/misc-throw-by-value-catch-by-reference.rst
The file was modifiedclang-tools-extra/docs/clang-tidy/checks/cppcoreguidelines-special-member-functions.rst
The file was modifiedclang-tools-extra/docs/clang-tidy/checks/bugprone-macro-parentheses.rst
The file was modifiedclang-tools-extra/docs/clang-tidy/checks/bugprone-branch-clone.rst
The file was modifiedclang-tools-extra/docs/clang-tidy/checks/readability-string-compare.rst
The file was modifiedclang-tools-extra/docs/clang-tidy/checks/readability-qualified-auto.rst
The file was modifiedclang-tools-extra/docs/clang-tidy/checks/bugprone-easily-swappable-parameters.rst
The file was modifiedclang-tools-extra/docs/clang-tidy/checks/bugprone-virtual-near-miss.rst
The file was modifiedclang-tools-extra/docs/clang-tidy/checks/modernize-use-noexcept.rst
The file was modifiedclang-tools-extra/docs/clang-tidy/checks/modernize-loop-convert.rst
The file was modifiedclang-tools-extra/docs/clang-tidy/checks/boost-use-to-string.rst
The file was modifiedclang-tools-extra/docs/clang-tidy/checks/cppcoreguidelines-virtual-class-destructor.rst
The file was modifiedclang-tools-extra/docs/clang-tidy/checks/hicpp-multiway-paths-covered.rst
The file was modifiedclang-tools-extra/docs/clang-tidy/checks/bugprone-sizeof-expression.rst
The file was modifiedclang-tools-extra/docs/clang-tidy/checks/hicpp-signed-bitwise.rst
The file was modifiedclang-tools-extra/docs/clang-tidy/checks/readability-suspicious-call-argument.rst
The file was modifiedclang-tools-extra/docs/clang-tidy/index.rst
The file was modifiedclang-tools-extra/docs/clang-tidy/checks/android-cloexec-open.rst
The file was modifiedclang-tools-extra/docs/clang-tidy/checks/concurrency-mt-unsafe.rst
The file was modifiedclang-tools-extra/docs/clang-tidy/checks/bugprone-suspicious-string-compare.rst
The file was modifiedclang-tools-extra/docs/clang-tidy/checks/bugprone-implicit-widening-of-multiplication-result.rst
The file was modifiedclang-tools-extra/docs/clang-tidy/Contributing.rst
The file was modifiedclang-tools-extra/docs/clang-tidy/checks/readability-data-pointer.rst
The file was modifiedclang-tools-extra/docs/clang-tidy/checks/readability-magic-numbers.rst
The file was modifiedclang-tools-extra/docs/clang-tidy/checks/abseil-duration-conversion-cast.rst
The file was modifiedclang-tools-extra/docs/clang-tidy/checks/cert-err09-cpp.rst
The file was modifiedclang-tools-extra/docs/clang-tidy/checks/readability-identifier-length.rst
The file was modifiedclang-tools-extra/docs/clang-tidy/checks/modernize-use-default-member-init.rst
The file was modifiedclang-tools-extra/docs/clang-tidy/checks/readability-const-return-type.rst
The file was modifiedclang-tools-extra/docs/clang-tidy/checks/modernize-replace-disallow-copy-and-assign-macro.rst
The file was modifiedclang-tools-extra/docs/clang-tidy/checks/readability-redundant-declaration.rst
The file was modifiedclang-tools-extra/docs/clang-tidy/checks/modernize-pass-by-value.rst
The file was modifiedclang-tools-extra/docs/clang-tidy/checks/openmp-exception-escape.rst
The file was modifiedclang-tools-extra/docs/clang-tidy/checks/performance-inefficient-algorithm.rst
The file was modifiedclang-tools-extra/docs/clang-tidy/checks/modernize-use-nullptr.rst
The file was modifiedclang-tools-extra/docs/clang-tidy/checks/android-cloexec-pipe2.rst
The file was modifiedclang-tools-extra/docs/clang-tidy/checks/cppcoreguidelines-init-variables.rst
The file was modifiedclang-tools-extra/docs/clang-tidy/checks/misc-static-assert.rst
The file was modifiedclang-tools-extra/docs/clang-tidy/checks/modernize-use-auto.rst
The file was modifiedclang-tools-extra/docs/clang-tidy/checks/modernize-avoid-c-arrays.rst
The file was modifiedclang-tools-extra/docs/clang-tidy/checks/bugprone-unhandled-exception-at-new.rst
The file was modifiedclang-tools-extra/docs/clang-tidy/checks/bugprone-too-small-loop-variable.rst
The file was modifiedclang-tools-extra/docs/clang-tidy/checks/abseil-no-internal-dependencies.rst
The file was modifiedclang-tools-extra/docs/clang-tidy/checks/modernize-avoid-bind.rst
The file was modifiedclang-tools-extra/docs/clang-tidy/checks/objc-nsinvocation-argument-lifetime.rst
The file was modifiedclang-tools-extra/docs/clang-tidy/checks/readability-else-after-return.rst
The file was modifiedclang-tools-extra/docs/clang-tidy/checks/cppcoreguidelines-narrowing-conversions.rst
Commit ff56d80eaa5ea59801843a39be4c65887dbb8b71 by mgorny
[lldb] [Host/FreeBSD] Remove unused variable (NFC)
The file was modifiedlldb/source/Host/freebsd/HostInfoFreeBSD.cpp
Commit ea9e9d61b521adaaa2d7f03712f9f6b9e9dfe8a1 by martin
[lldb] [Host/SerialPort] Fix build with GCC 7
The file was modifiedlldb/source/Host/common/File.cpp
Commit c5348355ee66fbfc97e0dbb0234398792c4b68d9 by shivam98.tkg
[www] Fix Ninja build instructions on Windows

The `clang` target used in the line below is only generated with `LLVM_ENABLE_PROJECTS=clang`.

Without this change, running `ninja clang` will fail with:
```
ninja: error: unknown target 'clang', did you mean 'clean'?
```

Reviewed By: xgupta

Differential Revision: https://reviews.llvm.org/D112257
The file was modifiedclang/www/get_started.html
Commit 35553d452b32e9356352df8536fa0485207a9274 by ezhulenev
[mlir] Add polynomial approximation for vectorized math::Rsqrt

This patch adds a polynomial approximation that matches the
approximation in Eigen.

Note that the approximation only applies to vectorized inputs;
the scalar rsqrt is left unmodified.

The approximation is protected with a flag since it emits an AVX2
intrinsic (generated via the X86Vector). This is the only reasonably
clean way that I could find to generate the exact approximation that
I wanted (i.e. an identical one to Eigen's).

I considered two alternatives:

1. Introduce a Rsqrt intrinsic in LLVM, which doesn't exist yet.
   I believe this is because there is no definition of Rsqrt that
   all backends could agree on, since hardware instructions that
   implement it have widely varying degrees of precision.
   This is something that the standard could mandate, but Rsqrt is
   not part of IEEE754, so I don't think this option is feasible.

2. Emit fdiv(1.0, sqrt) with fast math flags to allow reciprocal
   transformations. Although portable, this doesn't allow us
   to generate exactly the code we want; it is the LLVM backend,
   and not MLIR, who controls what code is generated based on the
   target CPU.

Reviewed By: ezhulenev

Differential Revision: https://reviews.llvm.org/D112192
The file was addedmlir/test/mlir-cpu-runner/X86Vector/lit.local.cfg
The file was modifiedmlir/include/mlir/Dialect/Math/Transforms/Passes.h
The file was modifiedutils/bazel/llvm-project-overlay/mlir/BUILD.bazel
The file was modifiedmlir/test/Dialect/Math/polynomial-approximation.mlir
The file was modifiedmlir/test/lib/Dialect/Math/CMakeLists.txt
The file was modifiedmlir/lib/Dialect/Math/Transforms/CMakeLists.txt
The file was modifiedmlir/lib/Dialect/Math/Transforms/PolynomialApproximation.cpp
The file was addedmlir/test/mlir-cpu-runner/X86Vector/math_polynomial_approx_avx2.mlir
The file was modifiedmlir/test/lib/Dialect/Math/TestPolynomialApproximation.cpp
The file was modifiedutils/bazel/llvm-project-overlay/mlir/test/BUILD.bazel
Commit 4703a07e6cc170666abb62d91307978ab4992d9c by nicolas.vasilache
[mlir][Linalg] NFC - Reorganize options nesting.

This removes duplication and makes nesting more clear.
It also reduces the amount of changes necessary for exposing future options.

Differential revision:  https://reviews.llvm.org/D112344
The file was modifiedmlir/lib/Dialect/Linalg/Transforms/CodegenStrategy.cpp
The file was modifiedmlir/test/lib/Dialect/Linalg/TestLinalgCodegenStrategy.cpp
The file was modifiedmlir/lib/Dialect/Linalg/Transforms/LinalgStrategyPasses.cpp
The file was modifiedmlir/include/mlir/Conversion/VectorToSCF/VectorToSCF.h
The file was modifiedmlir/include/mlir/Dialect/Linalg/Transforms/CodegenStrategy.h
The file was modifiedmlir/include/mlir/Dialect/Linalg/Transforms/Transforms.h
Commit 4f5e9a2bb28e1cf4a12c9330f52e664542400ec7 by nikita.ppv
[SCEV] Remove computeLoadConstantCompareExitLimit() (NFCI)

The functionality of this method is already covered by
computeExitCountExhaustively() in a more general fashion. It was
added at a time when exhaustive exit count calculation did not
support constant folding loads yet. I double checked that dropping
this code causes no binary changes in test-suite.

Differential Revision: https://reviews.llvm.org/D112343
The file was modifiedllvm/include/llvm/Analysis/ScalarEvolution.h
The file was modifiedllvm/lib/Analysis/ScalarEvolution.cpp
Commit e03b4431132ed7d46aea9cc37323e966cdb5283e by nicolas.vasilache
Revert "[mlir][Linalg] NFC - Reorganize options nesting."

This reverts commit 4703a07e6cc170666abb62d91307978ab4992d9c.

Didnt' mean to push this yet, sorry about the noise.
The file was modifiedmlir/include/mlir/Dialect/Linalg/Transforms/CodegenStrategy.h
The file was modifiedmlir/test/lib/Dialect/Linalg/TestLinalgCodegenStrategy.cpp
The file was modifiedmlir/lib/Dialect/Linalg/Transforms/CodegenStrategy.cpp
The file was modifiedmlir/lib/Dialect/Linalg/Transforms/LinalgStrategyPasses.cpp
The file was modifiedmlir/include/mlir/Conversion/VectorToSCF/VectorToSCF.h
The file was modifiedmlir/include/mlir/Dialect/Linalg/Transforms/Transforms.h