Changes

Update comment for <template-param-decl> mangling to match extended
mangling rule in r371004.
llvm-svn: 371252

GlobalISel: Support physical register inputs in patterns
llvm-svn: 371253

GlobalISel: Add G_FMAD instruction
llvm-svn: 371254

[ORC] Add a missing #include atomic.
Hopefully this will fix the bot build failures from r371245.
llvm-svn: 371255

[analyzer] pr43179: Make CallDescription defensive against C variadic
functions.
Most functions that our checkers react upon are not C-style variadic
functions, and therefore they have as many actual arguments as they have
formal parameters.
However, it's not impossible to define a variadic function with the same
name. This will crash any checker that relies on CallDescription to
check the number of arguments but silently assumes that the number of
parameters is the same.
Change CallDescription to check both the number of arguments and the
number of parameters by default.
If we're intentionally trying to match variadic functions, allow
specifying arguments and parameters separately (possibly omitting any of
them). For now we only have one CallDescription which would make use of
those, namely __builtin_va_start itself.
Differential Revision: https://reviews.llvm.org/D67019
llvm-svn: 371256

[analyzer] Add minimal support for fix-it hints.
Allow attaching fixit hints to Static Analyzer BugReports.
Fixits are attached either to the bug report itself or to its notes
(path-sensitive event notes or path-insensitive extra notes).
Add support for fixits in text output (including the default text output
that goes without notes, as long as the fixit "belongs" to the warning).
Add support for fixits in the plist output mode.
Implement a fixit for the path-insensitive DeadStores checker. Only dead 
initialization warning is currently covered.
Implement a fixit for the path-sensitive VirtualCall checker when the
virtual method is not pure virtual (in this case the "fix" is to
suppress the warning by qualifying the call).
Both fixits are under an off-by-default flag for now, because they 
require more careful testing.
Differential Revision: https://reviews.llvm.org/D65182
llvm-svn: 371257

[Core] Remove use of ClangASTContext in DumpDataExtractor
Summary: DumpDataExtractor uses ClangASTContext in order to get the
proper llvm fltSemantics for the type it needs so that it can dump
floats in a more precise way. However, there's no reason that this
behavior needs to be specific ClangASTContext. Instead, I think it makes
sense to ask TypeSystems for the float semantics for a type of a given
size.
Differential Revision: https://reviews.llvm.org/D67239
llvm-svn: 371258

[test] Add a FIXME test for stop-command-source-on-error
Modifying the interpreter settings is tricky because they don't take 
effect until we create a new command interpreter, which should be merely 
an implementation detail. This leads to confusing and unexpected 
scenarios.
This adds a test cases with FIXMEs for some of the odd scenarios I 
encountered. I didn't XFAIL the test because I don't think there's a way 
to get an unexpected PASS if any of the commands succeeds and splitting 
up the file in multiple tests seems excessive.
llvm-svn: 371259

[X86] Replace -mcpu with -mattr on some tests.
llvm-svn: 371260

[X86] Add a AVX512VBMI command line to min-legal-vector-width.ll. Always
enable fast-variable-shuffle
Trying to minimize the features we need to manipulate when this is
updated for D67259.
The VBMI is interesting because it enables some improved combining for
truncates.
I enabled fast-variable-shuffle because all the CPUs we're going to add
implicitly enable it. So they can share check lines.
llvm-svn: 371261

[IR] CallBrInst: scan+update arg list when indirect dest list changes
Summary: There's an unspoken invariant of callbr that the list of
BlockAddress Constants in the "function args" list match the BasicBlocks
in the
"other labels" list. (This invariant is being added to the LangRef in 
https://reviews.llvm.org/D67196).
When modifying the any of the indirect destinations of a callbr 
instruction (possible jump targets), we need to update the function 
arguments if the argument is a BlockAddress whose BasicBlock refers to 
the indirect destination BasicBlock being replaced.  Otherwise, many 
transforms that modify successors will end up violating that invariant. 
A recent change to the arm64 Linux kernel exposed this bug, which 
prevents the kernel from booting.
I considered maintaining a mapping from indirect destination BasicBlock 
to argument operand BlockAddress, but this ends up being a one to 
potentially many (though usually one) mapping.  Also, the list of 
arguments to a function (or more typically inline assembly) ends up 
being less than 10.  The implementation is significantly simpler to just 
rescan the full list of arguments. Because of the one to potentially 
many relationship, the full arg list must be scanned (we can't stop at 
the first instance).
Thanks to the following folks that reported the issue and helped debug 
it:
* Nathan Chancellor
* Will Deacon
* Andrew Murray
* Craig Topper
Link: https://bugs.llvm.org/show_bug.cgi?id=43222 Link:
https://github.com/ClangBuiltLinux/linux/issues/649 Link:
https://lists.infradead.org/pipermail/linux-arm-kernel/2019-September/678330.html
Reviewers: craig.topper, chandlerc
Reviewed By: craig.topper
Subscribers: void, javed.absar, kristof.beyls, hiraditya, llvm-commits,
nathanchance, srhines
Tags: #llvm
Differential Revision: https://reviews.llvm.org/D67252
llvm-svn: 371262

[ORC][RPC] Join server thread before checking condition in unit test.
Otherwise we have a race on the sent-messages count.
llvm-svn: 371263

[InstCombine] Refactor substitution of instruction in the parent BB
(NFC)
Add the new method `LibCallSimplifier::substituteInParent()` that calls
`LibCallSimplifier::replaceAllUsesWith()' and
`LibCallSimplifier::eraseFromParent()` back to back, simplifying the 
resulting code.
llvm-svn: 371264

[AArch64][GlobalISel] Enable the localizer for optimized builds.
Despite the fact that the localizer's original motivation was to fix
horrendous constant spilling at -O0, shortening live ranges still has
net benefits even with optimizations enabled.
On an -Os build of CTMark, doing this improves code size by 0.5%
geomean.
There are a few regressions, bullet increasing in size by 0.5%. One
example from bullet where code size increased slightly was due to
GlobalISel actually now generating the same code as SelectionDAG. So we
actually have an opportunity in future to implement better heuristics
for localization and therefore be
*better* than SDAG in some cases. In relation to other optimizations
though that one is relatively minor.
Differential Revision: https://reviews.llvm.org/D67303
llvm-svn: 371266

Update lld tests dynamic-list.s and symbol-override.s to use llvm-nm
The following tests failed on Windows bots due to nm not being 
available:
  lld/test/ELF/dynamic-list.s
 lld/test/ELF/symbol-override.s
llvm-svn: 371267

Use musttail for variadic method thunks when possible
This avoids cloning variadic virtual methods when the target supports 
musttail and the return type is not covariant. I think we never 
implemented this previously because it doesn't handle the covariant 
case. But, in the MS ABI, there are some cases where vtable thunks must 
be emitted even when the variadic method defintion is not available, so 
it looks like we need to implement this. Do it for both ABIs, since it's 
a nice size improvement and simplification for Itanium.
Emit an error when emitting thunks for variadic methods with a covariant 
return type. This case is essentially not implementable unless the ABI 
provides a way to perfectly forward variadic arguments without a tail 
call.
Fixes PR43173.
Differential Revision: https://reviews.llvm.org/D67028
llvm-svn: 371269