SuccessChanges

Summary

  1. [sanitizer] Remove disabled line (details)
  2. [sanitizer] Fix COMPILER_RT_DEBUG assignment (details)
  3. Added missing comma in clang-ppc64le-rhel builder configuration. (details)
Commit ac6a7e6e071c77bc081de358266075a938a11e39 by Vitaly Buka
[sanitizer] Remove disabled line
The file was modifiedzorg/buildbot/builders/sanitizers/buildbot_qemu.sh (diff)
Commit 76d050f0ff7e2517953936571ced397817a4a2e0 by Vitaly Buka
[sanitizer] Fix COMPILER_RT_DEBUG assignment
The file was modifiedzorg/buildbot/builders/sanitizers/buildbot_qemu.sh (diff)
Commit 8bbdd35de2d2a8513bbe4f62250ca1cf8f0a38fd by gkistanova
Added missing comma in clang-ppc64le-rhel builder configuration.
The file was modifiedbuildbot/osuosl/master/config/builders.py (diff)

Summary

  1. [ADT] Factor out in_place_t and expose in Optional ctor (details)
  2. [ADT] Add new type traits for type pack indexes (details)
  3. Revert "Reset the wakeup timeout when we re-enter the continue wait." (details)
  4. [clang][AVR] Redefine [u]int16_t to be compatible with avr-gcc (details)
  5. [RISCV][test] Add new tests of or/xor in the zbs extension (details)
  6. [LV] Unconditionally branch from middle to scalar preheader if the scalar loop must execute (details)
  7. Revert "[LV] Unconditionally branch from middle to scalar preheader if the scalar loop must execute" (details)
  8. [AMDGPU] Do not check denorm for LDS FP atomic with unsafe flag (details)
  9. [LV] Unconditionally branch from middle to scalar preheader if the scalar loop must execute (try 3) (details)
  10. [lld/mac] Inline a check (details)
  11. [lldb/API] Use a valid LineEntry object in SBCompileUnit::FindLineEntryIndex (details)
  12. [mlir][tosa] Cleanup of tosa.rescale lowering to linalg (details)
  13. [Matrix] Fold the transpose into the matmul operand used to fetch scalars (details)
Commit af5247c9347dcf1e30443786bdddf23ca705867a by scott.linder
[ADT] Factor out in_place_t and expose in Optional ctor

Differential Revision: https://reviews.llvm.org/D100671
The file was modifiedclang/include/clang/Basic/DirectoryEntry.h
The file was modifiedllvm/include/llvm/ADT/Optional.h
The file was modifiedllvm/include/llvm/ADT/STLForwardCompat.h
The file was modifiedllvm/unittests/ADT/OptionalTest.cpp
Commit a6d3987b8ef3b7616f0835b89515c4264f2a7a64 by scott.linder
[ADT] Add new type traits for type pack indexes

Similar versions of these already exist, this effectively just just
factors them out into STLExtras. I plan to use these in future patches.

Differential Revision: https://reviews.llvm.org/D100672
The file was modifiedllvm/include/llvm/ADT/STLExtras.h
The file was modifiedllvm/include/llvm/ADT/PointerUnion.h
The file was modifiedllvm/unittests/ADT/STLExtrasTest.cpp
Commit 82a38837150099288a1262391ef43e1fd69ffde4 by jingham
Revert "Reset the wakeup timeout when we re-enter the continue wait."

This reverts commit bd5751f3d249ec0798060bd98c07272174c52af0.
This patch series is causing us to every so often miss switching
the state from eStateRunning to eStateStopped when we get the stop
packet from the debug server.

Reverting till I can figure out how that could be happening.
The file was modifiedlldb/source/Plugins/Process/gdb-remote/GDBRemoteClientBase.h
The file was modifiedlldb/source/Plugins/Process/gdb-remote/GDBRemoteRegisterContext.cpp
The file was modifiedlldb/unittests/Process/gdb-remote/GDBRemoteClientBaseTest.cpp
The file was modifiedlldb/source/Target/TargetProperties.td
The file was modifiedlldb/source/Plugins/Platform/gdb-server/PlatformRemoteGDBServer.cpp
The file was modifiedlldb/unittests/Process/gdb-remote/GDBRemoteCommunicationClientTest.cpp
The file was modifiedlldb/source/Plugins/Process/gdb-remote/GDBRemoteCommunicationClient.cpp
The file was modifiedlldb/source/Plugins/Process/gdb-remote/ProcessGDBRemote.cpp
The file was modifiedlldb/source/Plugins/Process/gdb-remote/GDBRemoteClientBase.cpp
The file was modifiedlldb/include/lldb/Target/Process.h
The file was modifiedlldb/source/Plugins/Process/gdb-remote/GDBRemoteCommunicationClient.h
The file was modifiedlldb/source/Target/Process.cpp
The file was modifiedlldb/unittests/tools/lldb-server/tests/TestClient.cpp
The file was addedlldb/test/API/functionalities/gdb_remote_client/TestHaltFails.py
Commit b99e2c56166a3a74ac9c49512c584d5b158ac9c6 by powerman1st
[clang][AVR] Redefine [u]int16_t to be compatible with avr-gcc

Reviewed By: efriedma

Differential Revision: https://reviews.llvm.org/D102547
The file was modifiedclang/lib/Frontend/InitPreprocessor.cpp
The file was modifiedclang/lib/Basic/TargetInfo.cpp
The file was modifiedclang/lib/Basic/Targets/AVR.h
The file was modifiedclang/include/clang/Basic/TargetInfo.h
The file was modifiedclang/lib/Basic/Targets/AVR.cpp
Commit 3cf7983cbe4aba26487709184a0062a6f59aaa9e by powerman1st
[RISCV][test] Add new tests of or/xor in the zbs extension

Reviewed By: craig.topper

Differential Revision: https://reviews.llvm.org/D102625
The file was modifiedllvm/test/CodeGen/RISCV/rv64zbs.ll
The file was modifiedllvm/test/CodeGen/RISCV/rv32zbs.ll
Commit c23ce54b36b1a52eb280ea1d59802b56d6dd9800 by listmail
[LV] Unconditionally branch from middle to scalar preheader if the scalar loop must execute

This is a resubmit of 3e5ce4 (which was reverted by 7fe41ac).  The original commit caused a PPC build bot failure we never really got to the bottom of.  I can't reproduce the issue, and the bot owner was non-responsive.  In the meantime, we stumbled across an issue which seems possibly related, and worked around a latent bug in 80e8025.  My best guess is that the original patch exposed that latent issue at higher frequency, but it really is just a guess.

Original commit message follows...

If we know that the scalar epilogue is required to run, modify the CFG to end the middle block with an unconditional branch to scalar preheader. This is instead of a conditional branch to either the preheader or the exit block.

The motivation to do this is to support multiple exit blocks. Specifically, the current structure forces us to identify immediate dominators and *which* exit block to branch from in the middle terminator. For the multiple exit case - where we know require scalar will hold - these questions are ill formed.

This is the last change needed to support multiple exit loops, but since the diffs are already large enough, I'm going to land this, and then enable separately. You can think of this as being NFCIish prep work, but the changes are a bit too involved for me to feel comfortable tagging the review that way.

Differential Revision: https://reviews.llvm.org/D94892
The file was modifiedllvm/lib/Transforms/Vectorize/LoopVectorize.cpp
The file was modifiedllvm/test/Transforms/LoopVectorize/loop-form.ll
The file was modifiedllvm/lib/Transforms/Utils/LoopVersioning.cpp
The file was modifiedllvm/test/Transforms/LoopVectorize/first-order-recurrence-complex.ll
The file was modifiedllvm/test/Transforms/LoopVectorize/interleaved-accesses.ll
Commit d16da7343d40bc974c1906a271128fbaa3035db5 by listmail
Revert "[LV] Unconditionally branch from middle to scalar preheader if the scalar loop must execute"

This reverts commit c23ce54b36b1a52eb280ea1d59802b56d6dd9800.  I apparently missed some newly added non-x86 tests.
The file was modifiedllvm/test/Transforms/LoopVectorize/loop-form.ll
The file was modifiedllvm/lib/Transforms/Vectorize/LoopVectorize.cpp
The file was modifiedllvm/test/Transforms/LoopVectorize/interleaved-accesses.ll
The file was modifiedllvm/lib/Transforms/Utils/LoopVersioning.cpp
The file was modifiedllvm/test/Transforms/LoopVectorize/first-order-recurrence-complex.ll
Commit 45764efb6928bdd6fa4260f4ac6b9b6d12180301 by Stanislav.Mekhanoshin
[AMDGPU] Do not check denorm for LDS FP atomic with unsafe flag

This is already how it is handled for global and flat atomics.

Differential Revision: https://reviews.llvm.org/D102366
The file was modifiedllvm/lib/Target/AMDGPU/SIISelLowering.cpp
The file was modifiedllvm/test/CodeGen/AMDGPU/fp64-atomics-gfx90a.ll
Commit 6d3e3ae8a9ca10e063d541a959f4fe4cdb003dba by listmail
[LV] Unconditionally branch from middle to scalar preheader if the scalar loop must execute (try 3)

Resubmit after fixing test/Transforms/LoopVectorize/ARM/mve-gather-scatter-tailpred.ll

Previous commit message...

This is a resubmit of 3e5ce4 (which was reverted by 7fe41ac).  The original commit caused a PPC build bot failure we never really got to the bottom of.  I can't reproduce the issue, and the bot owner was non-responsive.  In the meantime, we stumbled across an issue which seems possibly related, and worked around a latent bug in 80e8025.  My best guess is that the original patch exposed that latent issue at higher frequency, but it really is just a guess.

Original commit message follows...

If we know that the scalar epilogue is required to run, modify the CFG to end the middle block with an unconditional branch to scalar preheader. This is instead of a conditional branch to either the preheader or the exit block.

The motivation to do this is to support multiple exit blocks. Specifically, the current structure forces us to identify immediate dominators and *which* exit block to branch from in the middle terminator. For the multiple exit case - where we know require scalar will hold - these questions are ill formed.

This is the last change needed to support multiple exit loops, but since the diffs are already large enough, I'm going to land this, and then enable separately. You can think of this as being NFCIish prep work, but the changes are a bit too involved for me to feel comfortable tagging the review that way.

Differential Revision: https://reviews.llvm.org/D94892
The file was modifiedllvm/test/Transforms/LoopVectorize/loop-form.ll
The file was modifiedllvm/lib/Transforms/Utils/LoopVersioning.cpp
The file was modifiedllvm/test/Transforms/LoopVectorize/interleaved-accesses.ll
The file was modifiedllvm/lib/Transforms/Vectorize/LoopVectorize.cpp
The file was modifiedllvm/test/Transforms/LoopVectorize/first-order-recurrence-complex.ll
The file was modifiedllvm/test/Transforms/LoopVectorize/ARM/mve-gather-scatter-tailpred.ll
Commit bc588f9961117d5705e97eb2191e901e92fe9094 by thakis
[lld/mac] Inline a check

`match()` can only return for non-empty vectors, but at least in
non-LTO builds that isn't clear to the compiler. Help it out.
This is a minor but measurable speedup on my machine (but less
than what we might've lost in https://reviews.llvm.org/D100818#2764272 --
bot note higher N on this measurement here, so higher confidence here):

    % ministat at_main at_branch
    x at_main
    + at_branch
        N           Min           Max        Median           Avg        Stddev
    x  30     3.9243979     4.0395119      3.987375     3.9826236   0.027567796
    +  30     3.8495831     4.0009291      3.931325     3.9347135   0.037832878
    Difference at 95.0% confidence
            -0.0479101 +/- 0.0171102
            -1.20298% +/- 0.429622%
            (Student's t, pooled s = 0.0331007)

No behavior change.

Eventually we should apply these lists at symbol parse time instead of
every time shouldExportSymbol() though :)

Differential Revision: https://reviews.llvm.org/D102655
The file was modifiedlld/MachO/SyntheticSections.cpp
Commit 1b4d5b3bf30656d39d94985a63f1c0514fcc6526 by medismail.bennani
[lldb/API] Use a valid LineEntry object in SBCompileUnit::FindLineEntryIndex

This patch updates `SBCompileUnit::FindLineEntryIndex` to pass a valid
`LineEntry` pointer to `CompileUnit::FindLineEntry`.

This caused `LineTable::FindLineEntryIndexByFileIndexImpl` to return its
`best_match` initial value (UINT32_MAX).

rdar://78115426

Differential Revision: https://reviews.llvm.org/D102658

Signed-off-by: Med Ismail Bennani <medismail.bennani@gmail.com>
The file was addedlldb/test/API/functionalities/find-line-entry/main.c
The file was modifiedlldb/source/API/SBCompileUnit.cpp
The file was addedlldb/test/API/functionalities/find-line-entry/Makefile
The file was addedlldb/test/API/functionalities/find-line-entry/TestFindLineEntry.py
Commit a91fb4328f255298dcc17dcb982db6831a53f81a by rob.suderman
[mlir][tosa] Cleanup of tosa.rescale lowering to linalg

Comment was poorly written. Changed to bail on contradictory information in
the double round.

Reviewed By: NatashaKnk

Differential Revision: https://reviews.llvm.org/D102651
The file was modifiedmlir/lib/Conversion/TosaToStandard/TosaToStandard.cpp
The file was modifiedmlir/lib/Conversion/TosaToLinalg/TosaToLinalg.cpp
Commit fcffd087c6bc1364678c1549ffc7a26fd8bea930 by anemet
[Matrix] Fold the transpose into the matmul operand used to fetch scalars

For column-major this is:
  A * B^t
whereas for row-major:
  A^t * B

Differential Revision: https://reviews.llvm.org/D101762
The file was modifiedllvm/test/Transforms/LowerMatrixIntrinsics/multiply-double-row-major.ll
The file was addedllvm/test/Transforms/LowerMatrixIntrinsics/multiply-right-transpose.ll
The file was modifiedllvm/lib/Transforms/Scalar/LowerMatrixIntrinsics.cpp
The file was addedllvm/test/Transforms/LowerMatrixIntrinsics/multiply-left-transpose-row-major.ll