SuccessChanges

Summary

  1. [Verifier] Significantly speed up IsolatedFromAbove checking. NFC. (details)
  2. [clang-format] New BreakInheritanceList style AfterComma (details)
  3. [AArch64][GlobalISel] Fix a crash during selection of a G_ZEXT(s8 = G_LOAD) (details)
  4. [Internalize] Simplify comdat renaming with noduplicates after D103043 (details)
  5. [lld/mac] Don't crash on -order_file with assembly inputs on arm64 (details)
Commit bde21b624585255dbd28c0bc0e93d37045b5a9a9 by clattner
[Verifier] Significantly speed up IsolatedFromAbove checking. NFC.

The implementation had a couple of problems, including checking
"isProperAncestor" in an inefficient way.  It also recursed into
other "isolated from above" ops.  In the case of CIRCT, we get
three levels of isolated ops:

  mlir::ModuleOp
    firrtl::CircuitOp
       firrtl::FModuleOp

The verification for module would recurse into the circuits and
fmodules checking them.  The verifier hook for circuit would
recurse into all the modules reverifying them, fmoduleop would
then reverify them.  The same happens for mlir::ModuleOp and Func.

While here, fix an old design problem: IsolatedFromAbove checking
was implemented by a method on the Region class, which isn't
actually general and isn't used by anything else.  Move it over
to be a trait impl verifier method like the others and specialize
it for its task.

Differential Revision: https://reviews.llvm.org/D103345
The file was modifiedmlir/include/mlir/IR/Region.h
The file was modifiedmlir/include/mlir/IR/OpDefinition.h
The file was modifiedmlir/lib/IR/Operation.cpp
The file was modifiedmlir/lib/IR/Region.cpp
Commit 09b75f480d1d578d48307fd7f3b024b66a75712f by lichray
[clang-format] New BreakInheritanceList style AfterComma

This inheritance list style has been widely adopted by Symantec,
a division of Broadcom Inc. It breaks after the commas that
separate the base-specifiers:

    class Derived : public Base1,
                    private Base2
    {
    };

Differential Revision: https://reviews.llvm.org/D103204
The file was modifiedclang/docs/ReleaseNotes.rst
The file was modifiedclang/lib/Format/Format.cpp
The file was modifiedclang/unittests/Format/FormatTest.cpp
The file was modifiedclang/include/clang/Format/Format.h
The file was modifiedclang/docs/ClangFormatStyleOptions.rst
The file was modifiedclang/lib/Format/TokenAnnotator.cpp
Commit 018a9641ff1a488f3ffbe1251666696fa5b29915 by Amara Emerson
[AArch64][GlobalISel] Fix a crash during selection of a G_ZEXT(s8 = G_LOAD)

We have special handling for a zext of a load <32b because the load does a zext
for free. In that case, we just select the G_ZEXT as if it were a copy but this
triggered the copy checking code to balk at the mismatched size.

This was being hidden because normally these get combined into G_ZEXTLOAD but
for atomics this doesn't happen. The test case here just uses a normal load
because the particular atomic isn't supported yet anyway.
The file was modifiedllvm/lib/Target/AArch64/GISel/AArch64InstructionSelector.cpp
The file was addedllvm/test/CodeGen/AArch64/GlobalISel/select-zext-as-copy.mir
Commit 38dbdde7924cb1ab5919dc49bbd7d3ad420967f1 by i
[Internalize] Simplify comdat renaming with noduplicates after D103043

I realized that we can use `comdat noduplicates` which is available on ELF.
Add a special case for wasm which doesn't support the feature.
The file was removedllvm/test/Transforms/Internalize/comdat-empty-moduleid.ll
The file was modifiedllvm/include/llvm/Transforms/IPO/Internalize.h
The file was modifiedllvm/lib/Transforms/IPO/Internalize.cpp
The file was modifiedllvm/test/Transforms/Internalize/comdat.ll
Commit c4053cd14eb9b5fe12b4ea9bc99bd83548d1f371 by thakis
[lld/mac] Don't crash on -order_file with assembly inputs on arm64

.s files with `-g` generate __debug_aranges on darwin/arm64 for some
reason, and those lead to `nullptr` symbols. Don't crash on that.

Fixes PR50517.

Differential Revision: https://reviews.llvm.org/D103350
The file was modifiedlld/MachO/Writer.cpp
The file was modifiedlld/test/MachO/order-file.s