SuccessChanges

Summary

  1. DetailedRecordsBackend.cpp - tidy implicit header dependencies. NFCI. (details)
  2. DetailedRecordsBackend.cpp - printSectionHeading - avoid std::string creation/copies. (details)
  3. DIPrinter.h - tidy implicit header dependencies. NFCI. (details)
  4. BoundsChecking.cpp - tidy implicit header dependencies. NFCI. (details)
  5. RawError.h - remove unused <string> include. NFCI. (details)
  6. [LoopUnroll] Test multi-exit runtime unrolling with predictable exit (NFC) (details)
  7. [lld/mac] clarify comment (details)
  8. DirectoryWatcher: also wait for the notifier thread (details)
  9. [SPARC] Legalize truncation and extension between fp128 and half (details)
Commit a03d09f423a41098fe92286da8de25c5ade4ba25 by llvm-dev
DetailedRecordsBackend.cpp - tidy implicit header dependencies. NFCI.

We don't use <algorithm>, <set> or <vector>, but we do use std::pair (<utility>).
The file was modifiedllvm/lib/TableGen/DetailedRecordsBackend.cpp
Commit d1b57086d55afcfa94711a0b09c22a4113f6261f by llvm-dev
DetailedRecordsBackend.cpp - printSectionHeading - avoid std::string creation/copies.

Don't create std::string from constant c-strings or pass std::string by value - we can use StringRef instead.
The file was modifiedllvm/lib/TableGen/DetailedRecordsBackend.cpp
Commit 033e594c594b4ba32213997a64af97e0c2bf321c by llvm-dev
DIPrinter.h - tidy implicit header dependencies. NFCI.

We don't use <string> but we do use std::unique_ptr (<memory>) and llvm::Optional<>
The file was modifiedllvm/include/llvm/DebugInfo/Symbolize/DIPrinter.h
Commit 9efe89d82ff95e72d25772c5c7eb1f55e0b7492e by llvm-dev
BoundsChecking.cpp - tidy implicit header dependencies. NFCI.

We don't use <vector> but we do use std::pair (<utility>)
The file was modifiedllvm/lib/Transforms/Instrumentation/BoundsChecking.cpp
Commit 4089e0bbfafd23704a1afef74f65369445a8b02b by llvm-dev
RawError.h - remove unused <string> include. NFCI.
The file was modifiedllvm/include/llvm/DebugInfo/PDB/Native/RawError.h
Commit 6ecc99210cdc87cff7d47484695b812196a9e905 by nikita.ppv
[LoopUnroll] Test multi-exit runtime unrolling with predictable exit (NFC)

The (prior to prologue insertion) predictable exit shouldn't get
folded here. Make sure it isn't...
The file was addedllvm/test/Transforms/LoopUnroll/runtime-loop-known-exit.ll
Commit 7d4c8a2b8f16a2d1cf8120c75d941e99b8a8200a by thakis
[lld/mac] clarify comment

This is a "we should do X in the future" fixme, not an "X might go wrong"
fixme.
The file was modifiedlld/MachO/UnwindInfoSection.cpp
Commit 527a1821e6f8e115db3335a3341c7ac491725a0d by Saleem Abdulrasool
DirectoryWatcher: also wait for the notifier thread

Ultimately the DirectoryWatcher is not ready until the notifier thread
is also active.  Failure to wait for the notifier thread may result in
loss of events.  While this is not catastrophic in practice, the tests
are sensitive to this as depending on the thread scheduler, the thread
may fail to being execution before the operations are completed by the
fixture.  Running this in a tight loop shows no regressions locally as
previously, but this failure mode was been sighted once on a builder.
The file was modifiedclang/lib/DirectoryWatcher/windows/DirectoryWatcher-windows.cpp
Commit 5be3a1a06483a5958a1a5dbffda386fd4ce579fe by thatlemon
[SPARC] Legalize truncation and extension between fp128 and half

Lower truncations and expansions between fp128 and half values into libcalls.
Expand truncating stores into two separate truncation and a store operations.

Reviewed By: jrtc27

Differential Revision: https://reviews.llvm.org/D104185
The file was modifiedllvm/lib/Target/Sparc/SparcISelLowering.cpp
The file was modifiedllvm/test/CodeGen/SPARC/fp16-promote.ll