FailedChanges

Summary

  1. [hwasan] Remove unused declaration shadowBase (NFC) (details)
  2. [ValueMapper] Remove unused declaration remapFunction (NFC) (details)
  3. [CodeGen] Use pred_empty (NFC) (details)
  4. [NFC] Reduce code duplication in binop processing in computeExitLimitFromCondCached (details)
  5. [llvm-readobj] - Don't crash when relocation table goes past the EOF. (details)
  6. [libc++] [www] Mark P0482 as "In Progress", as some parts of it are already implemented. (details)
  7. [clangd] Attempt at fixing ExternalIndex tests on windows (details)
  8. [lldb] [Process/FreeBSD] Add missing 'override' kws to POSIXStopInfo (details)
  9. [lldb] [Process/Utility] Declare register overlaps between ST and MM (details)
  10. [lldb] [test] Fix qRegisterInfo lldb-server tests to handle missing registers (details)
  11. [lldb] [Process/FreeBSDRemote] Fix regset names and related tests (details)
  12. [clang-tidy] Fix a nullptr-access crash in unused-raii-check. (details)
  13. [lldb] Prevent 'process connect' from using local-only plugins (details)
  14. [LoopFlatten] Widen IV, support ZExt. (details)
  15. [DebugInfo] Refactor code for emitting DWARF expressions for FP constants (details)
  16. [clangd] Second attempt at fixing windows buildbots (details)
  17. [llvm-readobj] - Stop using `unwrapOrError` in `DumpStyle<ELFT>::getGroups()` (details)
  18. [SCEV] Fix incorrect treatment of max taken count. PR48225 (details)
  19. [llvm-readelf/obj] - Fix the possible crash when dumping group sections. (details)
  20. [AST] Build recovery expression by default for all language. (details)
  21. [mlir][Linalg] NFC - Factor out Linalg functionality for shape and loop bounds computation (details)
Commit 186d129320c85dd3b1a108acf96046d811a6f8cf by kazu
[hwasan] Remove unused declaration shadowBase (NFC)

The function was introduced on Jan 23, 2019 in commit
73078ecd381b5ce95638c7a8e41fcabb6c27703a.

Its definition was removed on Oct 27, 2020 in commit
0930763b4baf926a39dd2d0571fd9e2102ec3831, leaving the declaration
unused.
The file was modifiedllvm/lib/Transforms/Instrumentation/HWAddressSanitizer.cpp
Commit df73b8c174820557608bf364dcf4dfb2bdc1811e by kazu
[ValueMapper] Remove unused declaration remapFunction (NFC)

The function declaration with two parameters was introduced on Apr 16
2016 in commit f0d73f95c15f909c6034f1735632695248bb75a8 without a
corresponding definition.
The file was modifiedllvm/lib/Transforms/Utils/ValueMapper.cpp
Commit 85d6af393c6e9ff8437e567dbf9e40d2026b7bc8 by kazu
[CodeGen] Use pred_empty (NFC)
The file was modifiedllvm/lib/CodeGen/WasmEHPrepare.cpp
The file was modifiedllvm/lib/CodeGen/CodeGenPrepare.cpp
Commit 47e31d1b5eac6a7b69a50404ecdc35daf18c01f9 by mkazantsev
[NFC] Reduce code duplication in binop processing in computeExitLimitFromCondCached

Handling of `and` and `or` vastly uses copy-paste. Factored out into
a helper function as preparation step for further fix (see PR48225).

Differential Revision: https://reviews.llvm.org/D91864
Reviewed By: nikic
The file was modifiedllvm/lib/Analysis/ScalarEvolution.cpp
The file was modifiedllvm/include/llvm/Analysis/ScalarEvolution.h
Commit 2584e1e324c97eeeacc1e421e5f3191a708c3d2d by grimar
[llvm-readobj] - Don't crash when relocation table goes past the EOF.

It is possible to trigger reading past the EOF by breaking fields like
DT_PLTRELSZ, DT_RELSZ or DT_RELASZ

This patch adds a validation in `DynRegionInfo` helper class.

Differential revision: https://reviews.llvm.org/D91787
The file was modifiedllvm/tools/llvm-readobj/ELFDumper.cpp
The file was modifiedllvm/test/tools/llvm-readobj/ELF/broken-dynamic-reloc.test
Commit de212de22edc5ce9786c1814c829fefcd94ab564 by marek
[libc++] [www] Mark P0482 as "In Progress", as some parts of it are already implemented.
The file was modifiedlibcxx/www/cxx2a_status.html
Commit 0dc2589d4a72474f3956d4472ad25a1085dda260 by kadircet
[clangd] Attempt at fixing ExternalIndex tests on windows
The file was modifiedclang-tools-extra/clangd/unittests/ConfigCompileTests.cpp
Commit 7b7c372e3fcadfd5ee6ab3fb68d9f0f1c25e0247 by mgorny
[lldb] [Process/FreeBSD] Add missing 'override' kws to POSIXStopInfo

Differential Revision: https://reviews.llvm.org/D91934
The file was modifiedlldb/source/Plugins/Process/FreeBSD/POSIXStopInfo.h
Commit 8f2f9a82e2cc333d36ddd1b6bb0523623e065cdc by mgorny
[lldb] [Process/Utility] Declare register overlaps between ST and MM

Explicitly declare register overlaps/invalidation between ST(i) and MMi
registers.

Differential Revision: https://reviews.llvm.org/D91728
The file was modifiedlldb/source/Plugins/Process/Utility/RegisterContextPOSIX_x86.h
The file was modifiedlldb/source/Plugins/Process/Utility/RegisterInfos_i386.h
The file was modifiedlldb/source/Plugins/Process/Utility/RegisterContextPOSIX_x86.cpp
The file was modifiedlldb/source/Plugins/Process/Utility/RegisterInfos_x86_64.h
Commit 9367b57dadb7a8515fa454cb4bb8e4cc45bf57d2 by mgorny
[lldb] [test] Fix qRegisterInfo lldb-server tests to handle missing registers

Fix qRegisterInfo tests to handle Exx error response when querying
registers that are not supported on the platform in question.  This
is how FreeBSD and NetBSD platforms reporting missing registers right
now, and there certainly is value from verifying the remaining
registers.

This change fixes the test for FreeBSD but NetBSD has other regressions
that still need to be researched.

Differential Revision: https://reviews.llvm.org/D91922
The file was modifiedlldb/test/API/tools/lldb-server/TestLldbGdbServer.py
Commit 8018e7b447dacb37a520fe989ab42c0586730961 by mgorny
[lldb] [Process/FreeBSDRemote] Fix regset names and related tests

Restore Linux-alike regset names for AVX/MPX registers
as TestLldbGdbServer seems to depend on them.  At the same time, fix
TestRegisters to be aware that they are not available on FreeBSD
and NetBSD, at least until we figure out a better way of reporting
unsupported register sets.

Differential Revision: https://reviews.llvm.org/D91923
The file was modifiedlldb/test/API/commands/register/register/register_command/TestRegisters.py
The file was modifiedlldb/source/Plugins/Process/FreeBSDRemote/NativeRegisterContextFreeBSD_x86_64.cpp
The file was modifiedlldb/test/API/tools/lldb-server/TestLldbGdbServer.py
Commit 66ace4dc0275c8d7740bc5ff57c20e85e6660371 by hokein.wu
[clang-tidy] Fix a nullptr-access crash in unused-raii-check.

I saw this crash in our internal production, but unfortunately didn't get
reproduced testcase, we likely hit this crash when the AST is ill-formed
(e.g. broken code).

Reviewed By: gribozavr2

Differential Revision: https://reviews.llvm.org/D91614
The file was modifiedclang-tools-extra/clang-tidy/bugprone/UnusedRaiiCheck.cpp
Commit 18e4272a4fe4667a44f4d323140645a83ddfd864 by mgorny
[lldb] Prevent 'process connect' from using local-only plugins

Add a 'can_connect' parameter to Process plugin initialization, and use
it to filter plugins to these capable of remote connections.  This is
used to prevent 'process connect' from picking up a plugin that can only
be used locally, e.g. the legacy FreeBSD plugin.

Differential Revision: https://reviews.llvm.org/D91810
The file was modifiedlldb/source/Plugins/Process/gdb-remote/ProcessGDBRemote.cpp
The file was modifiedlldb/source/Plugins/Process/mach-core/ProcessMachCore.h
The file was modifiedlldb/source/Target/Process.cpp
The file was modifiedlldb/source/Plugins/Process/FreeBSD/ProcessFreeBSD.h
The file was modifiedlldb/include/lldb/Target/Process.h
The file was modifiedlldb/test/API/functionalities/gdb_remote_client/TestProcessConnect.py
The file was modifiedlldb/source/Plugins/Platform/Windows/PlatformWindows.cpp
The file was modifiedlldb/source/Plugins/Process/elf-core/ProcessElfCore.h
The file was modifiedlldb/source/Plugins/Process/minidump/ProcessMinidump.cpp
The file was modifiedlldb/source/Plugins/Process/MacOSX-Kernel/ProcessKDP.cpp
The file was modifiedlldb/include/lldb/Target/ProcessTrace.h
The file was modifiedlldb/source/Plugins/Process/FreeBSD/ProcessFreeBSD.cpp
The file was modifiedlldb/source/Plugins/Process/elf-core/ProcessElfCore.cpp
The file was modifiedlldb/source/Commands/CommandObjectTarget.cpp
The file was modifiedlldb/source/API/SBTarget.cpp
The file was modifiedlldb/source/Plugins/Platform/gdb-server/PlatformRemoteGDBServer.cpp
The file was modifiedlldb/source/Target/Platform.cpp
The file was modifiedlldb/source/Plugins/Process/gdb-remote/ProcessGDBRemote.h
The file was modifiedlldb/source/Plugins/Platform/POSIX/PlatformPOSIX.cpp
The file was modifiedlldb/source/Plugins/Process/Windows/Common/ProcessWindows.h
The file was modifiedlldb/source/Target/ProcessTrace.cpp
The file was modifiedlldb/test/Shell/Commands/command-process-connect.test
The file was modifiedlldb/source/Plugins/Process/Windows/Common/ProcessWindows.cpp
The file was modifiedlldb/source/Target/Target.cpp
The file was modifiedlldb/source/Plugins/Process/mach-core/ProcessMachCore.cpp
The file was modifiedlldb/source/Target/TraceSessionFileParser.cpp
The file was modifiedlldb/source/Plugins/Process/minidump/ProcessMinidump.h
The file was modifiedlldb/include/lldb/lldb-private-interfaces.h
The file was modifiedlldb/include/lldb/Target/Target.h
The file was modifiedlldb/source/Plugins/Process/MacOSX-Kernel/ProcessKDP.h
Commit 33b2c88fa8223dbf15846ce18cc957e33e0d67fc by sjoerd.meijer
[LoopFlatten] Widen IV, support ZExt.

I disabled the widening in fa5cb4b because it run in an assert, which was
related to replacing values with different types. I forgot that an extend could
also be a zero-extend, which I have added now. This means that the approach now
is to create and insert a trunc value of the outerloop for each user, and use
that to replace IV values.

Differential Revision: https://reviews.llvm.org/D91690
The file was modifiedllvm/test/Transforms/LoopFlatten/widen-iv.ll
The file was modifiedllvm/lib/Transforms/Scalar/LoopFlatten.cpp
Commit 6ef7835afca246e623e9990dcd8c71204f5691e5 by pavel
[DebugInfo] Refactor code for emitting DWARF expressions for FP constants

This patch moves the selection of the style used to emit the numbers
(DW_OP_implicit_value vs. DW_OP_const+DW_OP_stack_value) into
DwarfExpression::addUnsignedConstant. This logic is not FP-specific, and
it will be needed for large integers too.

The refactor also makes DW_OP_implicit_value (DW_OP_stack_value worked
already) be used for floating point constants other than float and
double, so I've added a _Float16 test for it.

Split off from D90916.

Differential Revision: https://reviews.llvm.org/D91058
The file was modifiedllvm/lib/CodeGen/AsmPrinter/DwarfExpression.cpp
The file was addedllvm/test/DebugInfo/ARM/implicit_value-_Float16.ll
The file was modifiedllvm/lib/CodeGen/AsmPrinter/DwarfExpression.h
The file was modifiedllvm/lib/CodeGen/AsmPrinter/DwarfDebug.cpp
Commit fee78fb0049ae2556c99768a06421d7cdbb9d016 by kadircet
[clangd] Second attempt at fixing windows buildbots
The file was modifiedclang-tools-extra/clangd/unittests/ConfigCompileTests.cpp
Commit 4dcdf0df31259c1c02a1f7bbaa7ae45ca6c814dc by grimar
[llvm-readobj] - Stop using `unwrapOrError` in `DumpStyle<ELFT>::getGroups()`

With this we are able to diagnose possible issues much better and
don't exit on an error.

Differential revision: https://reviews.llvm.org/D91867
The file was modifiedllvm/test/tools/llvm-readobj/ELF/groups.test
The file was modifiedllvm/tools/llvm-readobj/ELFDumper.cpp
Commit 48d7cc6ae23b0e5b1922457462d0f6e4582a1ae7 by mkazantsev
[SCEV] Fix incorrect treatment of max taken count. PR48225

SCEV makes a logical mistake when handling EitherMayExit in
case when both conditions must be met to exit the loop. The
mistake looks like follows: "if condition `A` fails within at most `X` first
iterations, and `B` fails within at most `Y` first iterations, then `A & B`
fails at most within `min (X, Y)` first iterations". This is wrong, because
both of them must fail at the same time.

Simple example illustrating this is following: we have an IV with step 1,
condition `A` = "IV is even", condition `B` = "IV is odd". Both `A` and `B`
will fail within first two iterations. But it doesn't mean that both of them
will fail within first two first iterations at the same time, which would mean
that IV is neither even nor odd at the same time within first 2 iterations.

We can only do so for known exact BE counts, but not for max.

Differential Revision: https://reviews.llvm.org/D91942
Reviewed By: nikic
The file was modifiedllvm/test/Analysis/ScalarEvolution/pr48225.ll
The file was modifiedllvm/lib/Analysis/ScalarEvolution.cpp
Commit 76a626b2061bc8a33656a49ebcabbfa75c317d4c by grimar
[llvm-readelf/obj] - Fix the possible crash when dumping group sections.

It is possible to trigger a crash/misbehavior when the st_name field of
the signature symbol goes past the end of the string table.

This patch fixes it.

Differential revision: https://reviews.llvm.org/D91943
The file was modifiedllvm/test/tools/llvm-readobj/ELF/groups.test
The file was modifiedllvm/tools/llvm-readobj/ELFDumper.cpp
Commit b1444edbf41c1fe9f7e676df6e873e9c9318283e by hokein.wu
[AST] Build recovery expression by default for all language.

The dependency mechanism for C has been implemented, and we have rolled out
this to all internal users, didn't see crashy issues, we consider it is stable
enough.

Differential Revision: https://reviews.llvm.org/D89046
The file was modifiedclang/test/CodeGen/SystemZ/builtins-systemz-zvector2-error.c
The file was modifiedclang/include/clang/Basic/LangOptions.def
The file was modifiedclang/test/OpenMP/declare_variant_messages.c
The file was modifiedclang/lib/Frontend/CompilerInvocation.cpp
The file was modifiedclang/test/CodeGen/SystemZ/builtins-systemz-zvector-error.c
The file was modifiedclang/test/Sema/typo-correction.c
The file was modifiedclang/include/clang/AST/Expr.h
The file was modifiedclang/test/Sema/enum.c
The file was modifiedclang/test/CodeGen/SystemZ/builtins-systemz-zvector3-error.c
The file was modifiedclang/test/Sema/__try.c
The file was modifiedclang/test/Parser/objc-foreach-syntax.m
The file was modifiedclang/test/CodeGen/builtins-ppc-error.c
The file was modifiedclang/test/Index/complete-switch.c
The file was modifiedclang/test/OpenMP/begin_declare_variant_messages.c
Commit 01c4418544b7934f8216a6616562bbaf34dc6979 by nicolas.vasilache
[mlir][Linalg] NFC - Factor out Linalg functionality for shape and loop bounds computation

This revision refactors code used in various Linalg transformations and makes it a first class citizen to the LinalgStructureOpInterface. This is in preparation to allowing more advanced Linalg behavior but is otherwise NFC.

Differential revision: https://reviews.llvm.org/D91863
The file was modifiedmlir/include/mlir/Dialect/Linalg/IR/LinalgStructuredOpsInterface.td
The file was modifiedmlir/lib/Dialect/Linalg/Transforms/Tiling.cpp
The file was modifiedmlir/lib/Dialect/Linalg/Transforms/Loops.cpp
The file was modifiedmlir/lib/Dialect/Linalg/Transforms/Bufferize.cpp
The file was modifiedmlir/test/Dialect/Linalg/invalid.mlir
The file was modifiedmlir/include/mlir/Dialect/Linalg/Utils/Utils.h
The file was modifiedmlir/include/mlir/Dialect/Linalg/IR/LinalgOps.h
The file was modifiedmlir/lib/Dialect/Linalg/Utils/Utils.cpp
The file was modifiedmlir/include/mlir/Dialect/Linalg/Transforms/Transforms.h
The file was modifiedmlir/lib/Dialect/Linalg/IR/LinalgOps.cpp