FailedChanges

Summary

  1. [libc builder] Fix type in integration test command. (details)
Commit d93182bd9603056049608bc9d26fa5f003ed216d by paulatoth
[libc builder] Fix type in integration test command.
The file was modifiedzorg/buildbot/builders/annotated/libc-linux.py (diff)

Summary

  1. [SampleFDO] Add use-sample-profile function attribute. (details)
  2. [MTE] Move tagging in pipeline (details)
  3. [NFC, StackSafety] Change type of internal container (details)
  4. [NFC,MTE] Drop unneeded attribute from test (details)
  5. [JumpThreading] Simplify FindMostPopularDest (NFC) (details)
  6. [AArch64][GlobalISel] Select zip1 and zip2 (details)
  7. Revert "[NFC, StackSafety] Change type of internal container" (details)
  8. Replace dyn_cast<>() with isa<>() when the result isn't used (NFC) (details)
  9. [AMDGPU] Make SGPR spills exec mask agnostic (details)
  10. Fix build: TableGen uses `is<T>` instead of `isa<T>` as predicate (details)
  11. [lldb/Interpreter] Remove redundant argument (NFC) (details)
  12. [flang] Implemented 2 Semantic checks for DATA statement and fixed a few bugs (details)
  13. [Support] Add file lock/unlock functions (details)
  14. [X86] Add CLWB to Tremont CPU. Remove CLDEMOTE, MOVDIRI, MOVDIR64B, and WAITPKG to match gcc. (details)
  15. [CodeGen] Fix warnings in getPackedVectorTypeFromPredicateType (details)
  16. [NFC][PowerPC] Remove unused node PPCISD::VMADDFP and PPCISD::VNMSUBFP (details)
  17. [Driver] Add negative option for -fkeep-static-consts (details)
  18. [NFC, StackSafety] Change type of internal container (details)
Commit 7a6c89427c9babc8e4a69e8a2b61bbf4a4b80c56 by wmi
[SampleFDO] Add use-sample-profile function attribute.

When sampleFDO is enabled, people may expect they can use
-fno-profile-sample-use to opt-out using sample profile for a certain file.
That could be either for debugging purpose or for performance tuning purpose.
However, when thinlto is enabled, if a function in file A compiled with
-fno-profile-sample-use is imported to another file B compiled with
-fprofile-sample-use, the inlined copy of the function in file B may still
get its profile annotated.

The inconsistency may even introduce profile unused warning because if the
target is not compiled with explicit debug information flag, the function
in file A won't have its debug information enabled (debug information will
be enabled implicitly only when -fprofile-sample-use is used). After it is
imported into file B which is compiled with -fprofile-sample-use, profile
annotation for the outline copy of the function will fail because the
function has no debug information, and that will trigger  profile unused
warning.

We add a new attribute use-sample-profile to control whether a function
will use its sample profile no matter for its outline or inline copies.
That will make the behavior of -fno-profile-sample-use consistent.

Differential Revision: https://reviews.llvm.org/D79959
The file was modifiedllvm/test/LTO/Resolution/X86/load-sample-prof.ll
The file was modifiedllvm/test/Transforms/SampleProfile/inline-topdown.ll
The file was modifiedllvm/test/Transforms/SampleProfile/function_metadata.ll
The file was modifiedllvm/test/Transforms/SampleProfile/entry_counts_missing_dbginfo.ll
The file was modifiedllvm/test/Transforms/SampleProfile/inline-mergeprof.ll
The file was modifiedllvm/test/Transforms/SampleProfile/Inputs/profile-symbol-list.ll
The file was modifiedllvm/test/Transforms/SampleProfile/section-accurate-samplepgo.ll
The file was modifiedllvm/test/Transforms/SampleProfile/entry_counts_cold.ll
The file was modifiedllvm/test/Transforms/SampleProfile/profile-format-compress.ll
The file was modifiedllvm/test/LTO/Resolution/X86/load-sample-prof-icp.ll
The file was modifiedllvm/test/Transforms/SampleProfile/calls.ll
The file was modifiedllvm/test/Transforms/SampleProfile/inline.ll
The file was addedllvm/test/Transforms/Inline/partial-inline-incompat-attrs.ll
The file was modifiedllvm/test/Transforms/SampleProfile/coverage-warning.ll
The file was modifiedllvm/test/Transforms/SampleProfile/inline-combine.ll
The file was modifiedllvm/test/Transforms/SampleProfile/indirect-call-gcc.ll
The file was modifiedllvm/test/Transforms/SampleProfile/warm-inline-instance.ll
The file was modifiedllvm/test/Transforms/SampleProfile/gcc-simple.ll
The file was modifiedllvm/test/Transforms/SampleProfile/cov-zero-samples.ll
The file was modifiedllvm/test/Transforms/SampleProfile/inline-callee-update.ll
The file was modifiedllvm/test/Transforms/SampleProfile/syntax.ll
The file was modifiedllvm/test/Transforms/SampleProfile/indirect-call.ll
The file was modifiedllvm/test/Transforms/SampleProfile/inline-coverage.ll
The file was modifiedllvm/test/Transforms/SampleProfile/remap.ll
The file was modifiedllvm/test/Transforms/SampleProfile/inline-stats.ll
The file was modifiedllvm/test/Transforms/SampleProfile/profile-format.ll
The file was modifiedllvm/test/LTO/Resolution/X86/load-sample-prof-lto.ll
The file was modifiedllvm/test/Transforms/SampleProfile/inline-cold-callsite-samplepgo.ll
The file was modifiedllvm/lib/Transforms/IPO/SampleProfile.cpp
The file was modifiedllvm/test/Transforms/SampleProfile/discriminator.ll
The file was modifiedllvm/test/Transforms/SampleProfile/inline-cold.ll
The file was modifiedllvm/test/Transforms/SampleProfile/cold-indirect-call.ll
The file was modifiedllvm/test/Transforms/SampleProfile/nolocinfo.ll
The file was addedllvm/test/Transforms/Inline/inline-incompat-attrs.ll
The file was modifiedllvm/test/Transforms/SampleProfile/branch.ll
The file was modifiedllvm/test/Transforms/SampleProfile/early-inline.ll
The file was modifiedllvm/test/Transforms/SampleProfile/offset.ll
The file was addedllvm/test/Transforms/SampleProfile/use-sample-profile-attr.ll
The file was modifiedllvm/test/Transforms/SampleProfile/profile-sample-accurate.ll
The file was modifiedllvm/test/Transforms/SampleProfile/propagate.ll
The file was modifiedllvm/include/llvm/IR/Attributes.td
The file was modifiedclang/lib/CodeGen/CodeGenFunction.cpp
The file was modifiedllvm/test/Transforms/SampleProfile/fnptr.ll
The file was modifiedllvm/test/Transforms/SampleProfile/remarks.ll
The file was addedclang/test/CodeGen/use-sample-profile-attr.c
The file was modifiedllvm/test/Transforms/SampleProfile/entry_counts.ll
The file was addedllvm/test/Transforms/SampleProfile/Inputs/use-sample-profile-attr.prof
Commit f48bc44ace1a100bef676e630d5089779e7b87bf by Vitaly Buka
[MTE] Move tagging in pipeline

Summary:
This removes two analyses from pipeline.

Depends on D80771.

Reviewers: eugenis

Reviewed By: eugenis

Subscribers: hiraditya, llvm-commits

Tags: #llvm

Differential Revision: https://reviews.llvm.org/D80780
The file was modifiedllvm/test/CodeGen/AArch64/O3-pipeline.ll
The file was modifiedllvm/lib/Target/AArch64/AArch64TargetMachine.cpp
Commit f62813e7eae148a6175de28bfa384524a9f2bf94 by Vitaly Buka
[NFC, StackSafety] Change type of internal container

Summary: Depends on D80771.

Reviewers: eugenis

Reviewed By: eugenis

Subscribers: hiraditya, llvm-commits

Tags: #llvm

Differential Revision: https://reviews.llvm.org/D80847
The file was modifiedllvm/lib/Analysis/StackSafetyAnalysis.cpp
Commit 85fdec988fc55d56988d57fa88e2b870f6e0e8e9 by Vitaly Buka
[NFC,MTE] Drop unneeded attribute from test

Summary: Depends on D80847.

Reviewers: eugenis

Reviewed By: eugenis

Subscribers: hiraditya, steven_wu, dexonsmith, cfe-commits

Tags: #clang

Differential Revision: https://reviews.llvm.org/D80954
The file was modifiedclang/test/Driver/memtag_lto.c
Commit f355c7fc2f8fb0db829313b8e43f974ed730cf6d by kazu
[JumpThreading] Simplify FindMostPopularDest (NFC)

Summary:
This patch simplifies FindMostPopularDest without changing the
functionality.

Given a list of jump threading destinations, the function finds the
most popular destination.  To ensure determinism when there are
multiple destinations with the highest popularity, the function picks
the first one in the successor list with the highest popularity.

Without this patch:

- The function populates DestPopularity -- a histogram mapping
  destinations to their respective occurrence counts.

- Then we iterate over DestPopularity, looking for the highest
  popularity while building a vector of destinations with the highest
  popularity.

- Finally, we iterate the successor list, looking for the destination
  with the highest popularity.

With this patch:

- We implement DestPopularity with MapVector instead of DenseMap.  We
  populate the map with popularity 0 for all successors in the order
  they appear in the successor list.

- We build the histogram in the same way as before.

- We simply use std::max_element on DestPopularity to find the most
  popular destination.  The use of MapVector ensures determinism.

Reviewers: wmi, efriedma

Reviewed By: wmi

Subscribers: hiraditya, llvm-commits

Tags: #llvm

Differential Revision: https://reviews.llvm.org/D81030
The file was modifiedllvm/lib/Transforms/Scalar/JumpThreading.cpp
Commit 8b96703652ade915eb444b8dae91ae6a16d32d75 by Jessica Paquette
[AArch64][GlobalISel] Select zip1 and zip2

Port the code to recognize a zip1/zip2 shuffle mask from AArch64ISelLowering
and put it into the post-legalizer combiner.

Add G_ZIP1 and G_ZIP2 to AArch64InstrGISel.td and hook them up as equivalent
nodes to AArch64zip1 and AArch64zip2. This allows us to select them.

Minor code size improvements for SPECINT2000 at -O3 on 197.parser, 252.eon, and
186.crafty.

Differential Revision: https://reviews.llvm.org/D80969
The file was modifiedllvm/lib/Target/AArch64/AArch64Combine.td
The file was modifiedllvm/lib/Target/AArch64/AArch64InstrGISel.td
The file was addedllvm/test/CodeGen/AArch64/GlobalISel/postlegalizer-combiner-zip.mir
The file was addedllvm/test/CodeGen/AArch64/GlobalISel/select-zip.mir
The file was modifiedllvm/lib/Target/AArch64/AArch64PostLegalizerCombiner.cpp
Commit f9bb101d394d62027ba33e132691540f1e63cea8 by joker.eph
Revert "[NFC, StackSafety] Change type of internal container"

This reverts commit f62813e7eae148a6175de28bfa384524a9f2bf94.
GCC 5.3 build is broken.
The file was modifiedllvm/lib/Analysis/StackSafetyAnalysis.cpp
Commit a09bb6d77b39d3f87c76b525b355e158245a63cd by joker.eph
Replace dyn_cast<>() with isa<>() when the result isn't used (NFC)

Fixed warning reported by some GCC version.
The file was modifiedmlir/lib/TableGen/Operator.cpp
Commit da33c96d4762e0e59f1eff16f60d5c1575490331 by carl.ritson
[AMDGPU] Make SGPR spills exec mask agnostic

Explicitly set the exec mask for SGPR spills and reloads.
This fixes a bug where SGPR spills to memory could be incorrect
if the exec mask was 0 (or differed between spill and reload).

Additionally pack scalar subregisters (upto 16/32 per VGPR),
so that the majority of scalar types can be spilt or reloaded
with a simple memory access.  This should amortize some of the
additional overhead of manipulating the exec mask.

Reviewed By: arsenm

Differential Revision: https://reviews.llvm.org/D80282
The file was modifiedllvm/test/CodeGen/AMDGPU/control-flow-fastregalloc.ll
The file was modifiedllvm/test/CodeGen/AMDGPU/spill-wide-sgpr.ll
The file was modifiedllvm/lib/Target/AMDGPU/SIRegisterInfo.cpp
The file was modifiedllvm/test/CodeGen/AMDGPU/partial-sgpr-to-vgpr-spills.ll
The file was modifiedllvm/test/CodeGen/AMDGPU/spill-m0.ll
The file was modifiedllvm/lib/Target/AMDGPU/SIRegisterInfo.h
The file was addedllvm/test/CodeGen/AMDGPU/sgpr-spill.mir
The file was modifiedllvm/test/CodeGen/AMDGPU/spill-scavenge-offset.ll
The file was modifiedllvm/test/CodeGen/AMDGPU/si-spill-sgpr-stack.ll
Commit 48c800cc1bff13d1f5ae5e457a064cf6627280f1 by joker.eph
Fix build: TableGen uses `is<T>` instead of `isa<T>` as predicate
The file was modifiedmlir/lib/TableGen/Operator.cpp
Commit def72b91950d44a68b8613f25fa1a09926171222 by Jonas Devlieghere
[lldb/Interpreter] Remove redundant argument (NFC)
The file was modifiedlldb/source/Interpreter/CommandReturnObject.cpp
Commit 70f1b4b4122088c1bd7324b519bc449dbfeaf298 by asudhaku
[flang] Implemented 2 Semantic checks for DATA statement and fixed a few bugs

Summary
  - Implemented C876, C877
  - Fixed IsConstantExpr to check C879
  - Fixed bugs in few test cases - data01.f90, block-data01.f90,
  pre-fir-tree02.f90
  - Modified implementation of C8106 to identify all automatic objects
  and modified equivalence01.f90 to reflect the changes

Differential Revision: https://reviews.llvm.org/D78424
The file was modifiedflang/test/Semantics/block-data01.f90
The file was modifiedflang/test/Semantics/data01.f90
The file was modifiedflang/include/flang/Semantics/tools.h
The file was modifiedflang/lib/Semantics/tools.cpp
The file was modifiedflang/lib/Evaluate/check-expression.cpp
The file was modifiedflang/test/Semantics/data03.f90
The file was modifiedflang/test/Semantics/equivalence01.f90
The file was modifiedflang/lib/Semantics/check-data.cpp
The file was modifiedflang/test/Lower/pre-fir-tree02.f90
The file was addedflang/test/Semantics/data04.f90
The file was modifiedflang/lib/Semantics/resolve-names-utils.cpp
Commit f51bc4fb60fbcef26d18eff549fc68307fd46489 by sepavloff
[Support] Add file lock/unlock functions

New functions `lockFile`, `tryLockFile` and `unlockFile` implement
simple file locking. They lock or unlock entire file. This must be
enough to support simulataneous writes to log files in parallel builds.

Differential Revision: https://reviews.llvm.org/D78896
The file was modifiedllvm/lib/Support/Windows/Path.inc
The file was modifiedllvm/unittests/Support/Path.cpp
The file was modifiedllvm/include/llvm/Support/FileSystem.h
The file was modifiedllvm/lib/Support/Unix/Path.inc
Commit bb1d8bf2707bdca89c1f5e719057f1000232ccc3 by craig.topper
[X86] Add CLWB to Tremont CPU. Remove CLDEMOTE, MOVDIRI, MOVDIR64B, and WAITPKG to match gcc.
The file was modifiedclang/test/Preprocessor/predefined-arch-macros.c
The file was modifiedclang/lib/Basic/Targets/X86.cpp
The file was modifiedllvm/lib/Target/X86/X86.td
Commit e602cd878e308133cbbfdb73df686de2aa890bc1 by david.sherwood
[CodeGen] Fix warnings in getPackedVectorTypeFromPredicateType

Use getVectorElementCount() instead of getVectorNumElements().
The code changed in this patch is covered by an existing test:

  CodeGen/AArch64/sve-intrinsics-contiguous-prefetches.ll

Differential Revision: https://reviews.llvm.org/D80615
The file was modifiedllvm/lib/Target/AArch64/AArch64ISelDAGToDAG.cpp
Commit a462561ceec6aa6daffb5ee01dd029dbdaa6d603 by qshanz
[NFC][PowerPC] Remove unused node PPCISD::VMADDFP and PPCISD::VNMSUBFP

These two nodes were added by 69caef2b781130a7d0eeaf8898eb346b6423ae03 in 2005
and they are not used by PowerPC backend anymore. And the ISD::FMA is a prefer
way for VMADDFP if we really want to create that node. For VNMSUBFP, we will
also add a more generic node FNMSUB in D76585 if we really want it.

Reviewed By: qiucf

Differential Revision: https://reviews.llvm.org/D80429
The file was modifiedllvm/lib/Target/PowerPC/PPCInstrInfo.td
The file was modifiedllvm/lib/Target/PowerPC/PPCISelLowering.h
The file was modifiedllvm/lib/Target/PowerPC/PPCISelLowering.cpp
The file was modifiedllvm/lib/Target/PowerPC/PPCInstrAltivec.td
Commit ac47588bc4ff5927a01ed6fcd269ce86aba52a7c by shengchen.kan
[Driver] Add negative option for -fkeep-static-consts
The file was modifiedclang/include/clang/Driver/Options.td
The file was modifiedclang/lib/Driver/ToolChains/Clang.cpp
Commit e128f01be996f5f9a0e0cf5565d8a0696783b85d by Vitaly Buka
[NFC, StackSafety] Change type of internal container

Summary: Depends on D80771.

Reviewers: eugenis

Reviewed By: eugenis

Subscribers: mehdi_amini, hiraditya, llvm-commits

Tags: #llvm

Differential Revision: https://reviews.llvm.org/D80847
The file was modifiedllvm/lib/Analysis/StackSafetyAnalysis.cpp

Summary

  1. [libc builder] Fix type in integration test command. (details)
Commit d93182bd9603056049608bc9d26fa5f003ed216d by paulatoth
[libc builder] Fix type in integration test command.
The file was modifiedzorg/buildbot/builders/annotated/libc-linux.py