Commit
cb4d0bf9976ccb0da2850ea894254635f96fa9c2
by springerm[mlir][linalg][bufferize][NFC] Collect equivalent FuncOp BBArgs in PostAnalysisStep
Collect equivalent BBArgs right after the equivalence analysis of the FuncOp and before bufferizing. This is in preparation of decoupling bufferization from aliasInfo.
Also gather equivalence info for CallOps, which was missing in the previous commit.
Differential Revision: https://reviews.llvm.org/D114847
|
 | mlir/include/mlir/Dialect/Linalg/ComprehensiveBufferize/BufferizableOpInterface.h |
 | mlir/include/mlir/Dialect/Linalg/ComprehensiveBufferize/ComprehensiveBufferize.h |
 | mlir/lib/Dialect/Linalg/ComprehensiveBufferize/ModuleBufferization.cpp |
 | mlir/lib/Dialect/Linalg/ComprehensiveBufferize/ComprehensiveBufferize.cpp |
 | mlir/test/Dialect/Linalg/comprehensive-module-bufferize.mlir |
 | mlir/test/Dialect/Linalg/comprehensive-module-bufferize-analysis.mlir |
Commit
3ec6b1bfacebd65450662c75215a96ae59769368
by nicolas.vasilache[mlir] Add default implementations for methods in `TilingInterface`.
Adding the default implementation of `getLoopIteratorTypes` and `getLoopBounds` allows ExternalModels to override these methods.
Reviewed By: nicolasvasilache
Differential Revision: https://reviews.llvm.org/D115101
|
 | mlir/include/mlir/Interfaces/TilingInterface.td |
Commit
a96d8285101546c92116246939c2d53c57b88cf0
by pmatos[WebAssembly] Implementation of intrinsic for ref.null and HeapType removal
This patch implements the intrinsic for ref.null. In the process of implementing int_wasm_ref_null_func() and int_wasm_ref_null_extern() intrinsics, it removes the redundant HeapType.
This also causes the textual assembler syntax for ref.null to change. Instead of receiving an argument: `func` or `extern`, the instruction mnemonic is either ref.null_func or ref.null_extern, without the need for a further operand.
Reviewed By: tlively
Differential Revision: https://reviews.llvm.org/D114979
|
 | llvm/lib/IR/Function.cpp |
 | llvm/lib/Target/WebAssembly/MCTargetDesc/WebAssemblyMCTargetDesc.h |
 | llvm/lib/Target/WebAssembly/MCTargetDesc/WebAssemblyMCCodeEmitter.cpp |
 | llvm/lib/Target/WebAssembly/WebAssemblyInstrRef.td |
 | llvm/test/CodeGen/WebAssembly/funcref-call.ll |
 | llvm/test/MC/WebAssembly/reference-types.s |
 | llvm/lib/Target/WebAssembly/Disassembler/WebAssemblyDisassembler.cpp |
 | llvm/test/CodeGen/WebAssembly/funcref-table_call.ll |
 | llvm/lib/Target/WebAssembly/Utils/WebAssemblyTypeUtilities.h |
 | llvm/include/llvm/IR/IntrinsicsWebAssembly.td |
 | llvm/lib/Target/WebAssembly/AsmParser/WebAssemblyAsmParser.cpp |
 | llvm/lib/Target/WebAssembly/MCTargetDesc/WebAssemblyInstPrinter.h |
 | llvm/lib/Target/WebAssembly/Utils/WebAssemblyTypeUtilities.cpp |
 | llvm/include/llvm/IR/Intrinsics.td |
 | llvm/utils/TableGen/IntrinsicEmitter.cpp |
 | llvm/lib/Target/WebAssembly/WebAssemblyISelLowering.cpp |
 | llvm/lib/Target/WebAssembly/MCTargetDesc/WebAssemblyInstPrinter.cpp |
 | llvm/test/CodeGen/WebAssembly/ref-null.ll |
 | llvm/lib/Target/WebAssembly/WebAssemblyMCInstLower.cpp |
 | llvm/lib/Target/WebAssembly/WebAssemblyInstrInfo.td |
Commit
e9fb4dc9e918e23384550df9b66c2fd87cb1ffdd
by springerm[mlir][linalg][bufferize] Remove buffer equivalence from bufferize
Remove all function calls related to buffer equivalence from bufferize implementations.
Add a new PostAnalysisStep for scf.for that ensures that yielded values are equivalent to the corresponding BBArgs. (This was previously checked in `bufferize`.) This will be relaxed in a subsequent commit.
Note: This commit changes two test cases. These were broken by design and should not have passed. With the new scf.for PostAnalysisStep, this bug was fixed.
Differential Revision: https://reviews.llvm.org/D114927
|
 | mlir/lib/Dialect/Linalg/ComprehensiveBufferize/SCFInterfaceImpl.cpp |
 | mlir/include/mlir/Dialect/Linalg/ComprehensiveBufferize/SCFInterfaceImpl.h |
 | mlir/lib/Dialect/Linalg/ComprehensiveBufferize/ModuleBufferization.cpp |
 | mlir/lib/Dialect/Linalg/ComprehensiveBufferize/TensorInterfaceImpl.cpp |
 | mlir/test/Dialect/Linalg/comprehensive-module-bufferize-analysis.mlir |
 | mlir/lib/Dialect/Linalg/ComprehensiveBufferize/LinalgInterfaceImpl.cpp |
 | mlir/lib/Dialect/Linalg/Transforms/ComprehensiveBufferizePass.cpp |
 | mlir/lib/Dialect/Linalg/ComprehensiveBufferize/BufferizableOpInterface.cpp |
 | mlir/lib/Dialect/Linalg/ComprehensiveBufferize/ArithInterfaceImpl.cpp |
Commit
9873ef409c4a937c566e20e7a88af049d212ce03
by balazs.benics[analyzer] Ignore flex generated files
Some projects [1,2,3] have flex-generated files besides bison-generated ones. Unfortunately, the comment `"/* A lexical scanner generated by flex */"` generated by the tools is not necessarily at the beginning of the file, thus we need to quickly skim through the file for this needle string.
Luckily, StringRef can do this operation in an efficient way.
That being said, now the bison comment is not required to be at the very beginning of the file. This allows us to detect a couple more cases [4,5,6].
Alternatively, we could say that we only allow whitespace characters before matching the bison/flex header comment. That would prevent the (probably) unnecessary string search in the buffer. However, I could not verify that these tools would actually respect this assumption.
Additionally to this, e.g. the Twin project [1] has other non-whitespace characters (some preprocessor directives) before the flex-generated header comment. So the heuristic in the previous paragraph won't work with that. Thus, I would advocate the current implementation.
According to my measurement, this patch won't introduce measurable performance degradation, even though we will do 2 linear scans.
I introduce the ignore-bison-generated-files and ignore-flex-generated-files to disable skipping these files. Both of these options are true by default.
[1]: https://github.com/cosmos72/twin/blob/master/server/rcparse_lex.cpp#L7 [2]: https://github.com/marcauresoar/make-examples/blob/22362cdcf9dd7c597b5049ce7f176621e2e9ac7a/sandbox/count-words/lexer.c#L6 [3]: https://github.com/vladcmanea/2nd-faculty-year-Formal-Languages---Automata-assignments/blob/11abdf64629d9eb741438ba69f04636769d5a374/lab1/lex.yy.c#L6
[4]: https://github.com/KritikaChoudhary/System-Software-Lab/blob/47f5b2cfe2a2738fd54eae9f8439817f6a22034e/B_yacc/1/y1.tab.h#L2 [5]: https://github.com/VirtualMonitor/VirtualMonitor/blob/71d1bf9b1e7b392a7bd0c73dc217138dc5865651/src/VBox/Additions/x11/x11include/xorg-server-1.8.0/parser.h#L2 [6]: https://github.com/bspaulding/DrawTest/blob/3f773ceb13de14275429036b9cbc5aa19e29bab9/Framework/OpenEars.framework/Versions/A/Headers/jsgf_parser.h#L2
Reviewed By: xazax.hun
Differential Revision: https://reviews.llvm.org/D114510
|
 | clang/include/clang/StaticAnalyzer/Core/AnalyzerOptions.def |
 | clang/lib/StaticAnalyzer/Frontend/AnalysisConsumer.cpp |
 | clang/test/Analysis/analyzer-config.c |
 | clang/test/Analysis/yaccignore.c |
 | clang/test/Analysis/flexignore.c |
Commit
e761c49a14a8fb84898694d68218dba906aa9272
by springerm[mlir][linalg][bufferize][NFC] Utilize isWritable for FuncOps
This is a cleanup of ModuleBufferization. Instead of storing information about writable function arguments in BufferizationAliasInfo, we can use isWritable and make the decision there, based on dialect-specifc bufferization state.
Differential Revision: https://reviews.llvm.org/D114930
|
 | mlir/include/mlir/Dialect/Linalg/ComprehensiveBufferize/BufferizableOpInterface.td |
 | mlir/lib/Dialect/Linalg/ComprehensiveBufferize/SCFInterfaceImpl.cpp |
 | mlir/include/mlir/Dialect/Linalg/ComprehensiveBufferize/BufferizableOpInterface.h |
 | mlir/lib/Dialect/Linalg/ComprehensiveBufferize/BufferizationInterfaceImpl.cpp |
 | mlir/lib/Dialect/Linalg/ComprehensiveBufferize/ComprehensiveBufferize.cpp |
 | mlir/lib/Dialect/Linalg/ComprehensiveBufferize/LinalgInterfaceImpl.cpp |
 | mlir/lib/Dialect/Linalg/ComprehensiveBufferize/BufferizableOpInterface.cpp |
 | mlir/lib/Dialect/Linalg/ComprehensiveBufferize/ModuleBufferization.cpp |
 | mlir/lib/Dialect/Linalg/ComprehensiveBufferize/ArithInterfaceImpl.cpp |