Changes

Summary

  1. [lldb] NFC: less nesting in SearchFilter.cpp (details)
  2. [lldb][NFC] Migrate FileSpec::Dump to raw_ostream (details)
  3. [clangd] (take 2) Try harder to find a plausible `clang` as argv0, (details)
  4. gn build: Merge 99768b243cd (details)
  5. [clang-tidy] Fix PR26274 (details)
  6. [lldb/DWARF] Remove DWARFDebugRangesBase abstract class (details)
  7. [lldb/IRExecutionUnit] Stop searching based on demangled names (details)
  8. [lldb] Migrate VMRange::Dump to raw_ostream (details)
  9. [lldb/DWARF] Fix DW_AT_rnglists_base handling for dwo files (details)
  10. [lldb][NFC] Remove ability to pass a custom printf format to (details)
  11. [lldb/DWARF] Fix DW_AT_addr_base & DW_AT_low_pc interaction (details)
Commit 51ce067a442ee6381527b12d113f51906b0245a8 by kkleine
[lldb] NFC: less nesting in SearchFilter.cpp
I was working on SearchFilter.cpp and felt it a bit too complex in some
cases in terms of nesting and logic flow.
Reviewers: teemperor, JDevlieghere
Subscribers: lldb-commits
Tags: #lldb
Differential Revision: https://reviews.llvm.org/D71022
The file was modifiedlldb/source/Core/SearchFilter.cpp
Commit 4dac97eb1e6563750e682e482e68f29ac076a4f7 by Raphael Isemann
[lldb][NFC] Migrate FileSpec::Dump to raw_ostream
The file was modifiedlldb/source/Core/FormatEntity.cpp
The file was modifiedlldb/source/Core/Module.cpp
The file was modifiedlldb/include/lldb/Utility/FileSpec.h
The file was modifiedlldb/source/Utility/ProcessInfo.cpp
The file was modifiedlldb/source/Plugins/LanguageRuntime/RenderScript/RenderScriptRuntime/RenderScriptRuntime.cpp
The file was modifiedlldb/source/Utility/FileSpec.cpp
The file was modifiedlldb/source/Breakpoint/BreakpointLocation.cpp
The file was modifiedlldb/source/Commands/CommandObjectTarget.cpp
The file was modifiedlldb/source/Symbol/LineEntry.cpp
The file was modifiedlldb/source/Plugins/SymbolVendor/MacOSX/SymbolVendorMacOSX.cpp
The file was modifiedlldb/source/Core/FileSpecList.cpp
The file was modifiedlldb/source/Interpreter/OptionValueFileSpecList.cpp
The file was modifiedlldb/source/Symbol/SymbolContext.cpp
Commit 99768b243cd7afd312745da58b20ea067f39f89e by sam.mccall
[clangd] (take 2) Try harder to find a plausible `clang` as argv0,
particularly on Mac.
Summary: This was originally committed in
88bccded8fa169481fa367debf5ec615640635a1, and reverted in
93f77617abba512d2861e2fc50ce385883f587b6.
This version is now much more testable: the "detect toolchain
properties" part is still not tested but also not active in tests. All
the command manipulation based on the detected properties is directly
tested, and also not active in other tests.
Fixes https://github.com/clangd/clangd/issues/211 Fixes
https://github.com/clangd/clangd/issues/178
Reviewers: kbobyrev, ilya-biryukov
Subscribers: mgorny, ormris, cfe-commits, usaxena95, kadircet, arphaman,
jkorous, MaskRay
Tags: #clang
Differential Revision: https://reviews.llvm.org/D71029
The file was addedclang-tools-extra/clangd/CompileCommands.cpp
The file was modifiedclang-tools-extra/clangd/GlobalCompilationDatabase.h
The file was modifiedclang-tools-extra/clangd/ClangdLSPServer.cpp
The file was modifiedclang-tools-extra/clangd/unittests/CMakeLists.txt
The file was modifiedclang-tools-extra/clangd/unittests/ClangdTests.cpp
The file was modifiedclang-tools-extra/clangd/CMakeLists.txt
The file was modifiedclang-tools-extra/clangd/unittests/GlobalCompilationDatabaseTests.cpp
The file was modifiedclang-tools-extra/clangd/unittests/BackgroundIndexTests.cpp
The file was addedclang-tools-extra/clangd/unittests/CompileCommandsTests.cpp
The file was addedclang-tools-extra/clangd/CompileCommands.h
The file was modifiedclang-tools-extra/clangd/GlobalCompilationDatabase.cpp
Commit 64df0f359955bb835d7cfbdb0dc0e7b67269f93d by llvmgnsyncbot
gn build: Merge 99768b243cd
The file was modifiedllvm/utils/gn/secondary/clang-tools-extra/clangd/BUILD.gn
The file was modifiedllvm/utils/gn/secondary/clang-tools-extra/clangd/unittests/BUILD.gn
Commit fac4e3c5f8a018599cbd9363a735b1c13e8f8a05 by alexfh
[clang-tidy] Fix PR26274
Summary: This commit fixes http://llvm.org/PR26274 in a simpler and more
correct way than 4736d63f752f8d13f4c6a9afd558565c32119718 did. See
https://reviews.llvm.org/D69855#1767089 for details.
Reviewers: gribozavr, aaron.ballman, gribozavr2
Reviewed By: aaron.ballman, gribozavr2
Subscribers: gribozavr2, merge_guards_bot, xazax.hun, cfe-commits
Tags: #clang
Differential Revision: https://reviews.llvm.org/D70974
The file was removedclang-tools-extra/test/clang-tidy/checkers/google-readability-nested-namespace-comments.cpp
The file was addedclang-tools-extra/test/clang-tidy/checkers/google-readability-namespace-comments-c++17.cpp
The file was modifiedclang-tools-extra/test/clang-tidy/checkers/google-readability-namespace-comments.cpp
The file was modifiedclang-tools-extra/clang-tidy/readability/NamespaceCommentCheck.cpp
Commit 6e1f3170e061b16c9096a769508f0a6d7eb95b9c by pavel
[lldb/DWARF] Remove DWARFDebugRangesBase abstract class
now that we use llvm to parse debug_rnglists, this abstraction is not
useful.
The file was modifiedlldb/source/Plugins/SymbolFile/DWARF/DWARFDebugRanges.h
The file was modifiedlldb/source/Plugins/SymbolFile/DWARF/DWARFUnit.cpp
Commit 0d2472ff6f604af842059d9a0098db274515a2d3 by pavel
[lldb/IRExecutionUnit] Stop searching based on demangled names
Summary: This was causing problems on linux, where we'd end up calling
the deleting destructor instead of a regular one (because they have the
same demangled name), making a lot of mischief in the process.
The only place where this was necessary (according to the test suite, at
least) was to call a base structor instead of a complete one, but this
is now handled in a more targeted fashion.
TestCallOverriddenMethod is now re-enabled as it now passes reliably.
Reviewers: teemperor, JDevlieghere
Subscribers: lldb-commits
Tags: #lldb
Differential Revision: https://reviews.llvm.org/D70722
The file was modifiedlldb/packages/Python/lldbsuite/test/commands/expression/call-overridden-method/TestCallOverriddenMethod.py
The file was modifiedlldb/source/Expression/IRExecutionUnit.cpp
Commit 777d1f7272b52cbe372e7234a7247b189e416062 by Raphael Isemann
[lldb] Migrate VMRange::Dump to raw_ostream
The file was modifiedlldb/include/lldb/Utility/VMRange.h
The file was modifiedlldb/source/Expression/DWARFExpression.cpp
The file was modifiedlldb/source/Core/Section.cpp
The file was modifiedlldb/source/Utility/VMRange.cpp
Commit 5ee8e673135891072789f0f9bf14a5d82f0f8e01 by pavel
[lldb/DWARF] Fix DW_AT_rnglists_base handling for dwo files
the value of DW_AT_rnglists_base of the skeleton unit is for that unit
alone (e.g. used in DW_AT_ranges of the unit DIE) and should not apply
to the split unit.
The split unit has a hardcoded range list base value -- we should
initialize range list code whenever we detect a nonempty
debug_rnglists.dwo section.
The file was modifiedlldb/source/Plugins/SymbolFile/DWARF/DWARFUnit.cpp
The file was addedlldb/test/Shell/SymbolFile/DWARF/debug_rnglists-dwo.s
Commit b6e2cf3270dab43dbc6ffad4695c5c14789bc5e5 by Raphael Isemann
[lldb][NFC] Remove ability to pass a custom printf format to
DataExtractor::PutToLog
This is luckily not used anywhere.
The file was modifiedlldb/source/Utility/DataExtractor.cpp
The file was modifiedlldb/include/lldb/Utility/DataExtractor.h
Commit f69f92344adaada1f8f3cfcd711037227432b062 by pavel
[lldb/DWARF] Fix DW_AT_addr_base & DW_AT_low_pc interaction
In DWARF5 DW_AT_low_pc (and DW_AT_entry_pc, and possibly others) can use
DW_FORM_addrx to refer to the address indirectly. This means we need to
have processed the DW_AT_addr_base attribute before we can do anything
with these.
Since we were processing the unit attributes serially, this created a
problem in cases where the DW_AT_addr_base comes after DW_AT_low_pc --
we would end up computing the wrong unit base address, which also
corrupted any values which later depended on that (for instance range
lists). Clang currently always emits DW_AT_addr_base last.
The fix is simple -- process DW_AT_addr_base first, regardless of its
position in the attribute list.
The file was addedlldb/test/Shell/SymbolFile/DWARF/DW_AT_low_pc-addrx.s
The file was modifiedlldb/source/Plugins/SymbolFile/DWARF/DWARFUnit.cpp